Xcode: removed purchases-ios SPM reference#3166
Merged
Merged
Conversation
The project no longer depends on `purchases-ios` through SPM. This was needed for 2 reasons: - `v3LoadShedderIntegration` - `BackendCustomEntitlementsIntegrationTests` Both of these depend on `RevenueCat_CustomEntitlementComputation`, which is only an SPM library. This solution allows us to build it but without having to clone the repo separately through a dependency, and instead embedding a reference to the _local_ Package. `v3LoadShedderIntegration` depended on the 3.x release, so I've simply removed it from the workspace. It can still be modified and ran directly by opening the project.
bd24ddf to
af64643
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3166 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 220 220
Lines 15742 15742
=======================================
Hits 13639 13639
Misses 2103 2103 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 13, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Sep 14, 2023
**This is an automatic release.** ### Bugfixes * Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via Toni Rico (@tonidero) ### Performance Improvements * `OperationDispatcher`: add support for "long" delays (#3168) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: add tests for ghost transfer behavior (#3135) via NachoSoto (@NachoSoto) * `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto (@NachoSoto) * `Integration Tests`: another flaky failure (#3165) via NachoSoto (@NachoSoto) * `Integration Tests`: fix flaky test failure due to leftover transaction (#3167) via NachoSoto (@NachoSoto) * `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto (@NachoSoto) * `Integration Tests`: improve flaky tests (#3163) via NachoSoto (@NachoSoto) * `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto) * Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto) * `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto) * `CircleCI`: change all jobs to use `Xcode 14.x` and replace `xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project no longer depends on
purchases-iosthrough SPM.This was needed for 2 reasons:
v3LoadShedderIntegrationBackendCustomEntitlementsIntegrationTestsBoth of these depend on
RevenueCat_CustomEntitlementComputation, which is only an SPM library.This solution allows us to build it but without having to clone the repo separately through a dependency, and instead embedding a reference to the local Package.
v3LoadShedderIntegrationdepended on the 3.x release, so I've simply removed it from the workspace. It can still be modified and ran directly by opening the project.This solves at least 2 major current annoyances:
BackendIntegrationTestslead to compile errors because the local changes weren't seen when buildingRevenueCat_CustomEntitlementComputation.RevenueCat.xcworkspace/xcshareddata/swiftpm/Package.resolvedto point to the latest commit inmain, sometimes even making it crash.New setup: