Skip to content

Xcode 13: remove conditional code#3147

Merged
NachoSoto merged 2 commits into
mainfrom
remove-xcode-13-support
Sep 6, 2023
Merged

Xcode 13: remove conditional code#3147
NachoSoto merged 2 commits into
mainfrom
remove-xcode-13-support

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Clean up thanks to #2421

@NachoSoto NachoSoto requested a review from a team September 5, 2023 20:20
@NachoSoto NachoSoto changed the title Removed checks for Xcode 13 Xcode 13: remove conditional code Sep 5, 2023
@NachoSoto NachoSoto force-pushed the circle-ci-xcode-13-jobs branch from 11d0506 to 509e414 Compare September 5, 2023 21:22
@NachoSoto NachoSoto force-pushed the remove-xcode-13-support branch from ee05b31 to cebea21 Compare September 5, 2023 21:24
@codecov

codecov Bot commented Sep 5, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (7d8f0e0) 86.59% compared to head (cebea21) 86.61%.

❗ Current head cebea21 differs from pull request most recent head cc65d6f. Consider uploading reports for the commit cc65d6f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
+ Coverage   86.59%   86.61%   +0.02%     
==========================================
  Files         219      219              
  Lines       15715    15715              
==========================================
+ Hits        13608    13612       +4     
+ Misses       2107     2103       -4
Files Changed Coverage Δ
Sources/Identity/CustomerInfo.swift 95.12% <ø> (ø)
.../LocalReceiptParsing/BasicTypes/AppleReceipt.swift 100.00% <ø> (ø)
...LocalReceiptParsing/BasicTypes/InAppPurchase.swift 100.00% <ø> (ø)
Sources/Misc/Concurrency/Lock.swift 100.00% <ø> (ø)
Sources/Misc/SystemInfo.swift 94.11% <ø> (ø)
Sources/Purchasing/CachingProductsManager.swift 95.32% <ø> (ø)
Sources/Purchasing/EntitlementInfo.swift 80.64% <ø> (ø)
...ources/Purchasing/NonSubscriptionTransaction.swift 100.00% <ø> (ø)
Sources/Purchasing/ProductsManager.swift 91.66% <ø> (ø)
...asing/StoreKit2/StoreKit2TransactionListener.swift 94.93% <ø> (ø)
... and 9 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tonidero
tonidero approved these changes Sep 6, 2023
View reviewed changes

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these PRs :)

Base automatically changed from circle-ci-xcode-13-jobs to main September 6, 2023 16:32
@NachoSoto NachoSoto force-pushed the remove-xcode-13-support branch from cebea21 to 4aba42b Compare September 6, 2023 16:42
@NachoSoto NachoSoto enabled auto-merge (squash) September 6, 2023 16:42
@NachoSoto NachoSoto disabled auto-merge September 6, 2023 17:05
@NachoSoto
Removed Package@swift-5.6
cc65d6f 
This is only for Xcode 13
NachoSoto
NachoSoto commented Sep 6, 2023
View reviewed changes
Comment thread Package@swift-5.6.swift
@@ -1,56 +0,0 @@
// swift-tools-version:5.6

@NachoSoto NachoSoto Sep 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also no longer needed 🎉

@NachoSoto NachoSoto enabled auto-merge (squash) September 6, 2023 17:07
@NachoSoto NachoSoto merged commit 8243593 into main Sep 6, 2023
@NachoSoto NachoSoto deleted the remove-xcode-13-support branch September 6, 2023 17:59
NachoSoto added a commit that referenced this pull request Sep 7, 2023
@NachoSoto
Xcode 13: removed last Swift 5.7 checks
e3a5fcf 
Follow up to #3147.
@NachoSoto NachoSoto mentioned this pull request Sep 7, 2023
Merged
NachoSoto added a commit that referenced this pull request Sep 7, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15
15060c5 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
@NachoSoto NachoSoto mentioned this pull request Sep 7, 2023
Merged
NachoSoto added a commit that referenced this pull request Sep 7, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15 (#3162)
b991af9 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
NachoSoto added a commit that referenced this pull request Sep 7, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15 (#3162)
d797a94 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
NachoSoto added a commit that referenced this pull request Sep 7, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15 (#3162)
fc90196 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
NachoSoto added a commit that referenced this pull request Sep 8, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15 (#3162)
485ed0e 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
This was referenced Sep 13, 2023
Closed
Merged
NachoSoto pushed a commit that referenced this pull request Sep 14, 2023
@RCGitBot
[AUTOMATIC] Release/4.25.10 (#3208)
1f5a7f5 
**This is an automatic release.**

### Bugfixes
* Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via
Toni Rico (@tonidero)
### Performance Improvements
* `OperationDispatcher`: add support for "long" delays (#3168) via
NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: add tests for ghost transfer behavior (#3135) via
NachoSoto (@NachoSoto)
* `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto
(@NachoSoto)
* `Integration Tests`: another flaky failure (#3165) via NachoSoto
(@NachoSoto)
* `Integration Tests`: fix flaky test failure due to leftover
transaction (#3167) via NachoSoto (@NachoSoto)
* `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improve flaky tests (#3163) via NachoSoto
(@NachoSoto)
* `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto)
* Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto)
* `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto)
* `CircleCI`: change all jobs to use `Xcode 14.x` and replace
`xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
NachoSoto added a commit that referenced this pull request Sep 14, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15 (#3162)
d77aa40 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
NachoSoto added a commit that referenced this pull request Sep 14, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15 (#3162)
c7008c1 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
NachoSoto added a commit that referenced this pull request Sep 15, 2023
@NachoSoto
Paywalls: support fuzzy-Locale search in iOS 15 (#3162)
a08b0b3 
See #2847.

Thanks to @vegaro for pointing this out.

Also removed all checks for Xcode 13 (see #3161 and #3147).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonidero tonidero tonidero approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NachoSoto @tonidero