Codable: improved decoding errors#3153
Merged
Merged
Conversation
This adds the type to the errors. ``` 2023-09-06 15:58:05.394583-0700 xctest[55784:3435527] [codable] DEBUG: ℹ️ Encountered error when decoding JSON: not an event 2023-09-06 15:58:05.407965-0700 xctest[55784:3435527] [codable] ERROR: 😿‼️ Couldn't decode data from json, it was corrupted: Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "Something looked like a 'null' but wasn't around line 1, column 0." UserInfo={NSDebugDescription=Something looked like a 'null' but wasn't around line 1, column 0., NSJSONSerializationErrorIndex=0})) ``` ``` 2023-09-06 16:03:29.606223-0700 xctest[57222:3447821] [codable] DEBUG: ℹ️ Encountered error when decoding JSON for 'PaywallStoredEvent': this is not an event 2023-09-06 16:03:29.606329-0700 xctest[57222:3447821] [codable] ERROR: 😿‼️ Couldn't decode data from json, it was corrupted: Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "Something looked like a 'true' but wasn't around line 1, column 0." UserInfo={NSDebugDescription=Something looked like a 'true' but wasn't around line 1, column 0., NSJSONSerializationErrorIndex=0})) ```
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3153 +/- ##
==========================================
+ Coverage 86.60% 86.61% +0.01%
==========================================
Files 219 219
Lines 15715 15715
==========================================
+ Hits 13610 13612 +2
+ Misses 2105 2103 -2
☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Sep 7, 2023
This was referenced Sep 13, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Sep 14, 2023
**This is an automatic release.** ### Bugfixes * Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via Toni Rico (@tonidero) ### Performance Improvements * `OperationDispatcher`: add support for "long" delays (#3168) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: add tests for ghost transfer behavior (#3135) via NachoSoto (@NachoSoto) * `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto (@NachoSoto) * `Integration Tests`: another flaky failure (#3165) via NachoSoto (@NachoSoto) * `Integration Tests`: fix flaky test failure due to leftover transaction (#3167) via NachoSoto (@NachoSoto) * `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto (@NachoSoto) * `Integration Tests`: improve flaky tests (#3163) via NachoSoto (@NachoSoto) * `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto) * Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto) * `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto) * `CircleCI`: change all jobs to use `Xcode 14.x` and replace `xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the type to the errors.
Before:
After: