[BC5] Use rc-ignore-offer instead of rc-ignore-befault-offer#889
Merged
Conversation
rc-ignore-offer instead of rc-ignore-befault-offer
mcastany
approved these changes
Mar 21, 2023
tonidero
approved these changes
Mar 21, 2023
| val validOffers = this | ||
| .filter { !it.isBasePlan } | ||
| .filter { !it.tags.contains("rc-ignore-default-offer") } | ||
| .filter { !it.tags.contains("rc-ignore-offer") } |
Contributor
There was a problem hiding this comment.
Nitpick: should we extract this to a constant?
Member
Author
There was a problem hiding this comment.
Prrooobbaaabbbbllllllyyyyyyy 😇
jefago
approved these changes
Mar 21, 2023
Codecov Report
@@ Coverage Diff @@
## bc5-support #889 +/- ##
============================================
Coverage 84.09% 84.09%
============================================
Files 155 155
Lines 5382 5382
Branches 763 763
============================================
Hits 4526 4526
Misses 565 565
Partials 291 291
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
joshdholtz
added a commit
that referenced
this pull request
Mar 23, 2023
### Breaking Changes * Rename `introTrial` to `introOffer` on `SubscriptionOptions` (#890) via Josh Holtz (@joshdholtz) * Use `rc-ignore-offer` instead of `rc-ignore-befault-offer` (#889) via Josh Holtz (@joshdholtz) * AmazonStoreProduct updates (#881) via beylmk (@beylmk) * Remove Parcelable implementation for classes with ProductDetails as a member (#866) via beylmk (@beylmk) * Make Activity first param in PurchaseParams (#882) via Josh Holtz (@joshdholtz) ### New Features * Re-enable `observerMode` and `syncPurchases()` (#878) via Josh Holtz (@joshdholtz) ### Bugfixes * Re-add `price_string` header on postReceipt (#879) via Josh Holtz (@joshdholtz) ### Other Changes * Cleaning up some TODOs in the code (#883) via Josh Holtz (@joshdholtz) * Amazon Offering Parsing (#824) via beylmk (@beylmk) * Merge main -> bc5-support 2023-03-15 (#875) via Toni Rico (@tonidero) * Fix purchase tester navigation (#871) via beylmk (@beylmk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CF-1291
Turns out that
rc-ignore-default-offeris too long for Google Play to handle 🙈 Max 20 characters so now usingrc-ignore-offerDescription
Giant find replace for
rc-ignore-default-offertorc-ignore-offer