[BC5] Make Activity first param in PurchaseParams#882
Merged
joshdholtz merged 1 commit intoMar 17, 2023
Merged
Conversation
joshdholtz
commented
Mar 16, 2023
Comment on lines
+21
to
+23
| private val oneDayAgo = 1.days.ago() | ||
| private val twoDaysAgo = 2.days.ago() | ||
| private val oneDayFromNow = 1.days.fromNow() |
Member
Author
There was a problem hiding this comment.
Dates are only created once now to prevent slightly off timestamps causing equal tests to fail
Codecov Report
@@ Coverage Diff @@
## bc5-support #882 +/- ##
===============================================
- Coverage 82.01% 81.99% -0.02%
===============================================
Files 150 150
Lines 5349 5349
Branches 756 756
===============================================
- Hits 4387 4386 -1
Misses 681 681
- Partials 281 282 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
beylmk
approved these changes
Mar 17, 2023
beylmk
left a comment
Contributor
There was a problem hiding this comment.
👍 looks good! we'll wanna remember to update v6 migration w this later..
tonidero
added a commit
that referenced
this pull request
Mar 21, 2023
### Description This fixes a flaky test in `EntitlementInfoTest`. Copied fix in #882 Basically, we were creating multiple `EntitlementInfoTest` and comparing them but the dates could be different which caused the test to fail.
Merged
joshdholtz
added a commit
that referenced
this pull request
Mar 23, 2023
### Breaking Changes * Rename `introTrial` to `introOffer` on `SubscriptionOptions` (#890) via Josh Holtz (@joshdholtz) * Use `rc-ignore-offer` instead of `rc-ignore-befault-offer` (#889) via Josh Holtz (@joshdholtz) * AmazonStoreProduct updates (#881) via beylmk (@beylmk) * Remove Parcelable implementation for classes with ProductDetails as a member (#866) via beylmk (@beylmk) * Make Activity first param in PurchaseParams (#882) via Josh Holtz (@joshdholtz) ### New Features * Re-enable `observerMode` and `syncPurchases()` (#878) via Josh Holtz (@joshdholtz) ### Bugfixes * Re-add `price_string` header on postReceipt (#879) via Josh Holtz (@joshdholtz) ### Other Changes * Cleaning up some TODOs in the code (#883) via Josh Holtz (@joshdholtz) * Amazon Offering Parsing (#824) via beylmk (@beylmk) * Merge main -> bc5-support 2023-03-15 (#875) via Toni Rico (@tonidero) * Fix purchase tester navigation (#871) via beylmk (@beylmk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CF-1283
Might be good to move the
Activityparam as the first param inPurchaseParamsto make things Android consistent (see comment here)Description
Activityis now first paramEntitlementInfoTestthat had nothing to do with this but I think was failing because of creating dates on my machine but weren't equal because milliseconds off? 🤷♂️