Skip to content

[BC5] Re-add price_string header on postReceipt#879

Merged
joshdholtz merged 1 commit into
bc5-supportfrom
bc5-support-postReceipt-price_string-header
Mar 16, 2023
Merged

[BC5] Re-add price_string header on postReceipt#879
joshdholtz merged 1 commit into
bc5-supportfrom
bc5-support-postReceipt-price_string-header

Conversation

@joshdholtz

@joshdholtz joshdholtz commented Mar 16, 2023

Copy link
Copy Markdown
Member

Motivation

CF-1198

The price_string was removed but is needed for Amazon debugging.

Description

  • Adds price_string as an extra header on postReceiptData

@joshdholtz joshdholtz requested a review from a team March 16, 2023 11:25
@joshdholtz joshdholtz added the pr:fix A bug fix label Mar 16, 2023
@codecov

codecov Bot commented Mar 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #879 (fc384e6) into bc5-support (2a70043) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##           bc5-support     #879   +/-   ##
============================================
  Coverage        80.27%   80.27%           
============================================
  Files              132      132           
  Lines             4796     4797    +1     
  Branches           666      666           
============================================
+ Hits              3850     3851    +1     
  Misses             681      681           
  Partials           265      265           
Impacted Files Coverage Δ
...in/java/com/revenuecat/purchases/common/Backend.kt 84.35% <75.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

val extraHeaders = mapOf(
"price_string" to receiptInfo.storeProduct?.price?.formatted,
"marketplace" to marketplace
).filterNotNullValues()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@beylmk beylmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💨

@joshdholtz joshdholtz merged commit 3fdf928 into bc5-support Mar 16, 2023
@joshdholtz joshdholtz deleted the bc5-support-postReceipt-price_string-header branch March 16, 2023 18:13
@joshdholtz joshdholtz mentioned this pull request Mar 23, 2023
joshdholtz added a commit that referenced this pull request Mar 23, 2023
### Breaking Changes
* Rename `introTrial` to `introOffer` on `SubscriptionOptions` (#890)
via Josh Holtz (@joshdholtz)
* Use `rc-ignore-offer` instead of `rc-ignore-befault-offer` (#889) via
Josh Holtz (@joshdholtz)
* AmazonStoreProduct updates (#881) via beylmk (@beylmk)
* Remove Parcelable implementation for classes with ProductDetails as a
member (#866) via beylmk (@beylmk)
* Make Activity first param in PurchaseParams (#882) via Josh Holtz
(@joshdholtz)
### New Features
* Re-enable `observerMode` and `syncPurchases()` (#878) via Josh Holtz
(@joshdholtz)
### Bugfixes
* Re-add `price_string` header on postReceipt (#879) via Josh Holtz
(@joshdholtz)
### Other Changes
* Cleaning up some TODOs in the code (#883) via Josh Holtz (@joshdholtz)
* Amazon Offering Parsing (#824) via beylmk (@beylmk)
* Merge main ->  bc5-support 2023-03-15 (#875) via Toni Rico (@tonidero)
* Fix purchase tester navigation (#871) via beylmk (@beylmk)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants