Skip to content

[BC5] Re-enable observerMode and syncPurchases()#878

Merged
joshdholtz merged 1 commit into
bc5-supportfrom
bc5-support-re-enable-observerMode
Mar 22, 2023
Merged

[BC5] Re-enable observerMode and syncPurchases()#878
joshdholtz merged 1 commit into
bc5-supportfrom
bc5-support-re-enable-observerMode

Conversation

@joshdholtz

@joshdholtz joshdholtz commented Mar 16, 2023

Copy link
Copy Markdown
Member

Motivation

CF-817

Remove feature locks to re-enable observerMode and syncPurchases()

Description

  • Removes LockedFeature.ObserverMode
  • Removes LockedFeature.SyncPurchases

@joshdholtz joshdholtz requested a review from a team March 16, 2023 10:44
@codecov

codecov Bot commented Mar 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #878 (caaec34) into bc5-support (3977201) will decrease coverage by 3.86%.
The diff coverage is n/a.

❗ Current head caaec34 differs from pull request most recent head c7795be. Consider uploading reports for the commit c7795be to get more accurate results

@@               Coverage Diff               @@
##           bc5-support     #878      +/-   ##
===============================================
- Coverage        84.09%   80.24%   -3.86%     
===============================================
  Files              155      132      -23     
  Lines             5383     4788     -595     
  Branches           763      663     -100     
===============================================
- Hits              4527     3842     -685     
- Misses             565      681     +116     
+ Partials           291      265      -26     
Impacted Files Coverage Δ
...otlin/com/revenuecat/purchases/FeatureLockUtils.kt 100.00% <ø> (ø)
.../main/kotlin/com/revenuecat/purchases/Purchases.kt 84.98% <ø> (-0.23%) ⬇️

... and 58 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshdholtz joshdholtz force-pushed the bc5-support-re-enable-observerMode branch from caaec34 to c7795be Compare March 22, 2023 19:20
@joshdholtz joshdholtz removed the HOLD label Mar 22, 2023
@joshdholtz joshdholtz marked this pull request as ready for review March 22, 2023 19:21
@joshdholtz joshdholtz changed the title [DO NOT MERGE][BC5] Re-enable observerMode and syncPurchases() Re-enable observerMode and syncPurchases() Mar 22, 2023
@joshdholtz joshdholtz changed the title Re-enable observerMode and syncPurchases() [BC5] Re-enable observerMode and syncPurchases() Mar 22, 2023

@mcastany mcastany left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those removes make sense to me :D - Approved

@joshdholtz joshdholtz merged commit ef5e9ad into bc5-support Mar 22, 2023
@joshdholtz joshdholtz deleted the bc5-support-re-enable-observerMode branch March 22, 2023 19:35
@joshdholtz joshdholtz mentioned this pull request Mar 23, 2023
joshdholtz added a commit that referenced this pull request Mar 23, 2023
### Breaking Changes
* Rename `introTrial` to `introOffer` on `SubscriptionOptions` (#890)
via Josh Holtz (@joshdholtz)
* Use `rc-ignore-offer` instead of `rc-ignore-befault-offer` (#889) via
Josh Holtz (@joshdholtz)
* AmazonStoreProduct updates (#881) via beylmk (@beylmk)
* Remove Parcelable implementation for classes with ProductDetails as a
member (#866) via beylmk (@beylmk)
* Make Activity first param in PurchaseParams (#882) via Josh Holtz
(@joshdholtz)
### New Features
* Re-enable `observerMode` and `syncPurchases()` (#878) via Josh Holtz
(@joshdholtz)
### Bugfixes
* Re-add `price_string` header on postReceipt (#879) via Josh Holtz
(@joshdholtz)
### Other Changes
* Cleaning up some TODOs in the code (#883) via Josh Holtz (@joshdholtz)
* Amazon Offering Parsing (#824) via beylmk (@beylmk)
* Merge main ->  bc5-support 2023-03-15 (#875) via Toni Rico (@tonidero)
* Fix purchase tester navigation (#871) via beylmk (@beylmk)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:feat A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants