Remove Parcelable implementation for classes with ProductDetails as a member#866
Merged
Conversation
1916f40 to
c498c21
Compare
Codecov Report
@@ Coverage Diff @@
## bc5-support #866 +/- ##
===============================================
+ Coverage 80.04% 80.27% +0.22%
===============================================
Files 132 132
Lines 4771 4796 +25
Branches 664 666 +2
===============================================
+ Hits 3819 3850 +31
+ Misses 687 681 -6
Partials 265 265
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshdholtz
approved these changes
Mar 14, 2023
joshdholtz
left a comment
Member
There was a problem hiding this comment.
This looks good to me! 💪 LGTM
tonidero
approved these changes
Mar 14, 2023
| | `UpgradeInfo` | `PurchaseParams.Builder.oldProductId` and `PurchaseParams.Builder.googleProrationMode` | | ||
| | `ProductChangeCallback` | `PurchaseCallback` | | ||
|
|
||
| `Offering`, `Offerings`, `Package`, and `StoreProduct` are no longer Parcelable. |
Contributor
There was a problem hiding this comment.
👍 I do wonder if this should go to a different section in this doc... Maybe Breaking changes? I think this is ok thoug
Contributor
Author
There was a problem hiding this comment.
josh and i are planning a whole revamp of this doc! stay tuned :)
| }) | ||
|
|
||
| assertThat(numCallbacks == 1) | ||
| assert(numCallbacks == 1) |
Contributor
There was a problem hiding this comment.
Hmm I think the pattern we've been following is
Suggested change
| assert(numCallbacks == 1) | |
| assertThat(numCallbacks).isEqualTo(1) |
Merged
joshdholtz
added a commit
that referenced
this pull request
Mar 23, 2023
### Breaking Changes * Rename `introTrial` to `introOffer` on `SubscriptionOptions` (#890) via Josh Holtz (@joshdholtz) * Use `rc-ignore-offer` instead of `rc-ignore-befault-offer` (#889) via Josh Holtz (@joshdholtz) * AmazonStoreProduct updates (#881) via beylmk (@beylmk) * Remove Parcelable implementation for classes with ProductDetails as a member (#866) via beylmk (@beylmk) * Make Activity first param in PurchaseParams (#882) via Josh Holtz (@joshdholtz) ### New Features * Re-enable `observerMode` and `syncPurchases()` (#878) via Josh Holtz (@joshdholtz) ### Bugfixes * Re-add `price_string` header on postReceipt (#879) via Josh Holtz (@joshdholtz) ### Other Changes * Cleaning up some TODOs in the code (#883) via Josh Holtz (@joshdholtz) * Amazon Offering Parsing (#824) via beylmk (@beylmk) * Merge main -> bc5-support 2023-03-15 (#875) via Toni Rico (@tonidero) * Fix purchase tester navigation (#871) via beylmk (@beylmk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because ProductDetails does not have a public constructor,
StoreProduct,Package,Offering,PurchasingDataandOfferingsare no longer Parcelable.This PR takes away the implementation/annotation for those classes and updates unit tests accordingly. It also adds a missing test for
StoreProduct, which caught a failure in parcelization. This is now fixed with the innerComparableDataclass, copying the pattern we use inCustomerInfoto exclude the JSONObject.