Skip to content

Fix slow walking guests don't get across level crossings in time#18453

Merged
rik-smeets merged 1 commit into
OpenRCT2:developfrom
rik-smeets:fix-slow-guests-crossings
Oct 31, 2022
Merged

Fix slow walking guests don't get across level crossings in time#18453
rik-smeets merged 1 commit into
OpenRCT2:developfrom
rik-smeets:fix-slow-guests-crossings

Conversation

@rik-smeets

@rik-smeets rik-smeets commented Oct 27, 2022

Copy link
Copy Markdown
Contributor

Imagine you're very tired and nauseated, so you walk very slow. You're just trying to get across a railway crossing but are too tired to make it in time. This is what happens in the world of OpenRCT2 as of now (viewer discretion is advised):

Before:
Before

This isn't realistic of course. You'll be able to whip up a bit of extra energy to get out of the way in time. This PR ensures all guests, even those walking extremely slow, will make it across in time.

After:
After

@rik-smeets rik-smeets force-pushed the fix-slow-guests-crossings branch from f47f247 to 1a26e77 Compare October 27, 2022 18:31
@J-PIE-314

Copy link
Copy Markdown

The After GIF looks great. Could it also be possible to have sick peeps tend to wait longer for a train to arrive—figuring that to avoid the train they would have to run while sick? I think this would add more realism, but it may cause issues with nauseated peeps getting trapped in the midst of busy tracks.

@ocalhoun6

Copy link
Copy Markdown
Contributor

Won't this still be a problem for sufficiently fast-moving trains, though? Such as if the train is heading into the level crossing right after going down a major downhill slope...

(Though I guess fixing it in most cases is still much better than it was originally.)

@rik-smeets

Copy link
Copy Markdown
Contributor Author

The After GIF looks great. Could it also be possible to have sick peeps tend to wait longer for a train to arrive—figuring that to avoid the train they would have to run while sick? I think this would add more realism, but it may cause issues with nauseated peeps getting trapped in the midst of busy tracks.

This would require marking crossings earlier specifically for sick peeps. That is possible, but would require larger changes. For the time being, I think this change will suffice.

Won't this still be a problem for sufficiently fast-moving trains, though? Such as if the train is heading into the level crossing right after going down a major downhill slope...

(Though I guess fixing it in most cases is still much better than it was originally.)

Crossings are marked as blocked dynamically based on the train's speed. So this actually isn't an issue (I also tested this just to be sure)!

@J-PIE-314

Copy link
Copy Markdown

This would require marking crossings earlier specifically for sick peeps. That is possible, but would require larger changes. For the time being, I think this change will suffice.

I understand and definitely agree.

Thanks for all the work that you have done on the train crossings so far. Train crossings keep getting better. 🙂

Comment thread src/openrct2/entity/Peep.cpp Outdated
@rik-smeets rik-smeets force-pushed the fix-slow-guests-crossings branch from 1a26e77 to 2d1f3ca Compare October 31, 2022 18:22
@rik-smeets rik-smeets force-pushed the fix-slow-guests-crossings branch from 2d1f3ca to 44d6471 Compare October 31, 2022 18:23
@rik-smeets rik-smeets merged commit 6faddd9 into OpenRCT2:develop Oct 31, 2022
@rik-smeets rik-smeets deleted the fix-slow-guests-crossings branch October 31, 2022 18:57
@tupaschoal tupaschoal added this to the v0.4.3 milestone Oct 31, 2022
Gymnasiast added a commit that referenced this pull request Dec 14, 2022
- Feature: [#17782] The Flying Coaster now has access to boosters and can draw outside loops.
- Feature: [#17997] The Log Flume can now draw steep pieces down (if vehicle allows it).
- Feature: [#18312, objects#220, OpenSFX#13] New sound effects for the Hybrid and Single Rail roller coasters.
- Feature: [#18675] [Plugin] Plugins can refer to g2 image icons by name.
- Feature: [objects#173] Add alpine coaster vehicle.
- Feature: [objects#221] Add two extra jungle walls.
- Feature: [objects#225] Add log cabin roofs.
- Feature: [OpenMusic#14, OpenMusic#15, OpenMusic#18] Added Galaxy, Acid and Dodgems ride music styles.
- Improved: [#18013, #18016, #18018, #18019, #18514, objects#224] Added colour presets to Spiral Slide, Dodgems, Boat Hire, Flying Saucers, and Car Ride.
- Improved: [#18024] Clearer error messages when loading incompatible .park files.
- Improved: [#18192] Tycoon Park has been added to the Extras tab.
- Improved: [#18214] Competition scenarios have received their own section.
- Improved: [#18250] Added modern style file and folder pickers on Windows.
- Improved: [#18332] Allow Inverted Roller Coaster to draw boosters.
- Improved: [#18350] Changed ride vehicle list to have less padding.
- Improved: [#18422] Allow adding images to music objects.
- Improved: [#18428] [Plugin] Add widget description interfaces to documentation.
- Improved: [#18487] Mini Helicopters track can now draw spinning tunnels.
- Improved: [#18591] Order RollerCoaster Tycoon 2 scenarios by difficulty.
- Improved: [#18607] A new tab for all UCES Scenarios, if it’s installed.
- Improved: [#18621] OpenGL performance.
- Change: [#17677] Open campaign window from finished campaign news.
- Change: [#17998] Show cursor when using inverted mouse dragging.
- Change: [#18230] Make the large flat to steep pieces available on the corkscrew roller coaster without cheats.
- Change: [#18381] Convert custom invisible paths to the built-in ones.
- Change: [OpenSFX#11, OpenMusic#19] First implementation of official replacement asset packs for sound effects & music.
- Fix: [#1491] Clearance of the Cash Machine is too low (original bug).
- Fix: [#1519] “See-through rides” doesn't affect all rides (original bug).
- Fix: [#6341] “Unlock vehicle limits” does not allow setting fewer vehicles than the vehicle type requires.
- Fix: [#14312] Research ride type message incorrect.
- Fix: [#14425] Ride ratings do not skip unallocated ride ids.
- Fix: [#15969] Guests heading for ride use vanilla behaviour
- Fix: [#17067] Random Staff Patrol Area clicks.
- Fix: [#17316] Sides of River Rapids’ corners overlay other parts of the track.
- Fix: [#17657] When switching from buying land rights to buying construction rights, grid disables and won't re-enable afterwards.
- Fix: [#17763] Missing validation on invalid characters in file name.
- Fix: [#17853] Invention name tears while being dragged.
- Fix: [#18064] Unable to dismiss notification messages.
- Fix: [#18070] Underground entrance/exit shows through terrain walls (original bug).
- Fix: [#18094] Underground shops & facilities don't show when adjacent to non-underground path (original bug).
- Fix: [#18122] Ghosts count towards “Great scenery!” guest thought.
- Fix: [#18134] Underground on-ride photo section partially clips through adjacent terrain edge.
- Fix: [#18244] Invention DragWindow's starting position is inconsistent.
- Fix: [#18245] Guests stopping dead in their tracks at railway crossings.
- Fix: [#18257] Guests ‘waiting’ on extended railway crossings.
- Fix: [#18354] Overwrite alert does not show when save name has different casing on Windows.
- Fix: [#18379] Tunnel entrances for underground Mini Golf Hole E are not rendered correctly.
- Fix: [#18442] About window background is clickable.
- Fix: [#18449] [Plugin] Change type of listview widgets from 'scroll_view' to 'listview'.
- Fix: [#18453] Slow walking guests don't get across level crossings in time.
- Fix: [#18469] Land rights window buttons incorrectly disabled and markers remain visible indefinitely.
- Fix: [#18459] ‘Highlight path issues’ hides fences for paths with additions.
- Fix: [#18552] Trains clipping through helixes.
- Fix: [#18576] Cannot open parks with certain types of corrupt tile elements.
- Fix: [#18606] JSON objects do not take priority over the DAT files they supersede.
- Fix: [#18620] [Plugin] Crash when reading widget properties from windows that have both static and tab widgets.
- Fix: [#18653] Negative ratings multipliers do not appear in Vehicle tab.
- Fix: [#18696] Construction rights cannot be viewed after all are purchased.
- Fix: [#18720] Upwards helix is enabled for the Alpine Coaster, even when cheats are off.
- Fix: [#18755] Ferris Wheel and Circus ghosts not coloured correctly.
- Fix: [#18802] Game could crash when determining if a mechanic is heading to fix the ride blocking the path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants