Flying Coaster track additions | Part 2#17782
Conversation
|
Oh you added more track color presets? That's actually amazing. It would be nice if other ride types like the Inverted Impulse Coaster and Vertical Drop Roller Coaster got more track color presets. Will you be planning to add new track color presets to other ride types? |
|
On the bottom of the PR i stated i still have to do the large loop supports haha. I will get to it, it's why I currently have it as a draft. |
|
I am wondering if it'd be nice to add strings for the new loops that would say inside or outside? If not this PR is ready to be reviewed. |
|
If you want, then add the new text strings for those new inverted/uninverted loops. If not, that's fine. |
|
I think the strings might get too long It'd be something like |
This is a Hotfix for something I overlooked while making OpenRCT2#17312. I have fixed the same issue for the flying inline in OpenRCT2#17782. Please let me know if I need to bring that over to this PR.
Split of OpenRCT2#17782 as requested. I don't know how much ask there is to add more presets but I thought it was a nice addition to have these to give new inspiration to people while building the Flying RC.
|
Rebase fail? |
|
Not on my end. |
Gymnasiast
left a comment
There was a problem hiding this comment.
You probably rebased it against your outdated develop branch. Please rebase it against the upstream develop.
Also, the supports of the large half loops don’t reach the track properly. This needs to be fixed.
|
Haha yea i rebased it and a day after another g2 merge came across. I'll fix it tonight |
2d71368 to
dcd597e
Compare
|
What still needs to happen with the large half loops? Is there something I am not seeing? |
|
|
|
Your wish is my command 🙏 |
|
If you are talking about the glitch where the cars are almost like bouncing below and above the track, this already happened before this PR (if you would let the trains run without a texture). I believe it only occurs on the top part of the large outside loop to the left. I have no clue how the vehicle sub positions work so @spacek531 would have to take a look a that in either a separate PR or I'll have to cherry pick it into here. You can see this in action if you use this map in the latest develop version vs this pr. |
|
I’d like that to be fixed before this PR goes in (either here or in a PR of its own) - this PR is going to make that visible, after all. Btw, it also happens on the top of the half loop that was added in @spacek531 ’s PR. I overlooked it, apparently.
|
|
What I could do is make these track pieces still unavailable to be placed down (only renderable), then someone else can fix that issue before adding that back? |
|
I’m reluctant to do so, as it makes it a bit too easy not to fix the actual issue. |
|
These refactors will be the bane of my existance😂 |
Send help I am not okay, probably... The real question is, was I ever okay to begin with. 😂
I should take this to twitter
|
Issues related to glitching when transitioning between inverted and uninverted track elements are caused by the uncap FPS option. Seems like outside the scope of this PR. |
|
I have made a bug report #18309 for it. I think the main reason why this came up now is because this element is one of the most obvious ones for it to occur on. |
|
Tested it. Alignment seems a bit off here:
Could you look into that? It seem you could probably lower the whole thing by a pixel or two and still have it connect properly on top. |
|
It also seems like the boosters are partly recoloured in the track’s second colour, rather than being white. Is that intentional?
|
This is indeed intentional, the LSMs of FLY (which I based the sprite of) are hidden on the inside of metal sleeves (basically). |
I will take a look at it, I believe I have tried it before but the entirety of the bounding boxes were messed up. If that's the case I will have to redo those, but I'll check. |
|
The top will end up looking like this, which is probably a tad cleaner, but still messy. It's why I originally decided on having the pixel be shifted off this tiny bit. I should be able to tackle it if I'd have a tool like described in #18330, but until that exists it will be guess work and trial and error and ill can break my neck over that for days on end. I will gladly take care of thisone and many more of those pixel offset issues (there's a bunch) when something like that becomes available. Until then I don't think it's worth the effort for me. |
|
I was the one that made the decision to have it be a little janky at the bottom. If you move it one pixel down and connect the end to regular track (not a large half loop) it looks worse than the one pixel being off at the bottom. |
|
I guess we have no choice then. Ah well. |
- Feature: [#17782] The Flying Coaster now has access to boosters and can draw outside loops. - Feature: [#17997] The Log Flume can now draw steep pieces down (if vehicle allows it). - Feature: [#18312, objects#220, OpenSFX#13] New sound effects for the Hybrid and Single Rail roller coasters. - Feature: [#18675] [Plugin] Plugins can refer to g2 image icons by name. - Feature: [objects#173] Add alpine coaster vehicle. - Feature: [objects#221] Add two extra jungle walls. - Feature: [objects#225] Add log cabin roofs. - Feature: [OpenMusic#14, OpenMusic#15, OpenMusic#18] Added Galaxy, Acid and Dodgems ride music styles. - Improved: [#18013, #18016, #18018, #18019, #18514, objects#224] Added colour presets to Spiral Slide, Dodgems, Boat Hire, Flying Saucers, and Car Ride. - Improved: [#18024] Clearer error messages when loading incompatible .park files. - Improved: [#18192] Tycoon Park has been added to the Extras tab. - Improved: [#18214] Competition scenarios have received their own section. - Improved: [#18250] Added modern style file and folder pickers on Windows. - Improved: [#18332] Allow Inverted Roller Coaster to draw boosters. - Improved: [#18350] Changed ride vehicle list to have less padding. - Improved: [#18422] Allow adding images to music objects. - Improved: [#18428] [Plugin] Add widget description interfaces to documentation. - Improved: [#18487] Mini Helicopters track can now draw spinning tunnels. - Improved: [#18591] Order RollerCoaster Tycoon 2 scenarios by difficulty. - Improved: [#18607] A new tab for all UCES Scenarios, if it’s installed. - Improved: [#18621] OpenGL performance. - Change: [#17677] Open campaign window from finished campaign news. - Change: [#17998] Show cursor when using inverted mouse dragging. - Change: [#18230] Make the large flat to steep pieces available on the corkscrew roller coaster without cheats. - Change: [#18381] Convert custom invisible paths to the built-in ones. - Change: [OpenSFX#11, OpenMusic#19] First implementation of official replacement asset packs for sound effects & music. - Fix: [#1491] Clearance of the Cash Machine is too low (original bug). - Fix: [#1519] “See-through rides” doesn't affect all rides (original bug). - Fix: [#6341] “Unlock vehicle limits” does not allow setting fewer vehicles than the vehicle type requires. - Fix: [#14312] Research ride type message incorrect. - Fix: [#14425] Ride ratings do not skip unallocated ride ids. - Fix: [#15969] Guests heading for ride use vanilla behaviour - Fix: [#17067] Random Staff Patrol Area clicks. - Fix: [#17316] Sides of River Rapids’ corners overlay other parts of the track. - Fix: [#17657] When switching from buying land rights to buying construction rights, grid disables and won't re-enable afterwards. - Fix: [#17763] Missing validation on invalid characters in file name. - Fix: [#17853] Invention name tears while being dragged. - Fix: [#18064] Unable to dismiss notification messages. - Fix: [#18070] Underground entrance/exit shows through terrain walls (original bug). - Fix: [#18094] Underground shops & facilities don't show when adjacent to non-underground path (original bug). - Fix: [#18122] Ghosts count towards “Great scenery!” guest thought. - Fix: [#18134] Underground on-ride photo section partially clips through adjacent terrain edge. - Fix: [#18244] Invention DragWindow's starting position is inconsistent. - Fix: [#18245] Guests stopping dead in their tracks at railway crossings. - Fix: [#18257] Guests ‘waiting’ on extended railway crossings. - Fix: [#18354] Overwrite alert does not show when save name has different casing on Windows. - Fix: [#18379] Tunnel entrances for underground Mini Golf Hole E are not rendered correctly. - Fix: [#18442] About window background is clickable. - Fix: [#18449] [Plugin] Change type of listview widgets from 'scroll_view' to 'listview'. - Fix: [#18453] Slow walking guests don't get across level crossings in time. - Fix: [#18469] Land rights window buttons incorrectly disabled and markers remain visible indefinitely. - Fix: [#18459] ‘Highlight path issues’ hides fences for paths with additions. - Fix: [#18552] Trains clipping through helixes. - Fix: [#18576] Cannot open parks with certain types of corrupt tile elements. - Fix: [#18606] JSON objects do not take priority over the DAT files they supersede. - Fix: [#18620] [Plugin] Crash when reading widget properties from windows that have both static and tab widgets. - Fix: [#18653] Negative ratings multipliers do not appear in Vehicle tab. - Fix: [#18696] Construction rights cannot be viewed after all are purchased. - Fix: [#18720] Upwards helix is enabled for the Alpine Coaster, even when cheats are off. - Fix: [#18755] Ferris Wheel and Circus ghosts not coloured correctly. - Fix: [#18802] Game could crash when determining if a mechanic is heading to fix the ride blocking the path.
Continuation of #16164
The following PR will add new pieces to the B&M Flying Coaster.
As a bonus this PR fixes a regression I found in my previous PR which also has to do with the flying coaster.