Ssc 195 day of week improvements#1352
Merged
Merged
Conversation
added 7 commits
June 16, 2025 10:54
…y_of_week_improvements
sjanzou
approved these changes
Sep 10, 2025
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Wow! Lots of changes througout. All tests passing on MacOS 15.6 arm64 build using Clang 16.0.0.16000026 with XCode 16.2 (different from GitHub Actions Mac runners)
5 tasks
cpaulgilman
approved these changes
Sep 10, 2025
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Implementation looks good, I can see effect of January 1 day of week on outputs for load, energy charge, and demand charge for BTM configs, and in revenue TOD factors for FOM configs.
Pull Request Test Coverage Report for Build 18352938785Details
💛 - Coveralls |
added 2 commits
September 11, 2025 08:46
janinefreeman
approved these changes
Oct 8, 2025
cpaulgilman
added a commit
to NatLabRockies/SAM
that referenced
this pull request
Jun 8, 2026
cpaulgilman
added a commit
to NatLabRockies/SAM
that referenced
this pull request
Jun 9, 2026
… 2026 release (#2207) * Remove wind cost model descriptions for #2154 * Fix help build issues * Revise PV sizing topics for new PV UI design for #2135 * Clean up battery dispatch Help topics for #2115 * Revise Help for PVWatts detailed battery for #2113 * Update Help build instructions * Consolidate battery Help topics * Add description of load day of week input for #2109 Also fix Belpe annual growth rate widget overlap * Revise degradation save lifetime outputs in Help for #2087 Also fix broken references in Electricity Load topic. * Emphasis SRW is obsolete and fix format of weather file Help topics * Add description of calculation to capacity payment Help topic. * Revise Help for solar resource UI updates in #2120 * Clean up misc headings and broken links in Help * Revise Help build instructions * Fix broken welcome page Help link * Revise Help for IPH system control copy TOD factors for #2024 Also fix TOU output fractions widget label for IPH "turbine output" to "heat sink output". * Custom generation Help revisions for NatLabRockies/ssc#1384 * Clean up Help rates and load topics for NatLabRockies/ssc#1352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add input start_day_of_year to relevant compute modules, and propagate effects to weekday/weekend schedules including:
Fixes #195
Corresponding branches and PRs:
Pairs with SAM PR TBD
Unit Test Impact:
Added tests to lib_util_test to verify new behavior
Other tests updates should just change function signature, not affect results.
Known compiler issue potentially affecting CMPvsamv1PowerIntegration_cmod_pvsamv1.NoFinancialModelSkyDiffuseAndIrradModels
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)