SAM Landbosse and Python Handler Removals#2154
Merged
Merged
Conversation
…anges from develop as well
5 tasks
dguittet
reviewed
Mar 20, 2026
dguittet
left a comment
Collaborator
There was a problem hiding this comment.
This whole directory should be deleted also: https://github.com/NatLabRockies/SAM/tree/develop/deploy/runtime/python
| if (primary_cmod == "wind_landbosse") | ||
| continue; | ||
| // Reviewer - can we delete this? | ||
| //if (primary_cmod == "wind_landbosse") |
dguittet
approved these changes
Mar 20, 2026
This was referenced Mar 24, 2026
cpaulgilman
added a commit
that referenced
this pull request
Jun 9, 2026
… 2026 release (#2207) * Remove wind cost model descriptions for #2154 * Fix help build issues * Revise PV sizing topics for new PV UI design for #2135 * Clean up battery dispatch Help topics for #2115 * Revise Help for PVWatts detailed battery for #2113 * Update Help build instructions * Consolidate battery Help topics * Add description of load day of week input for #2109 Also fix Belpe annual growth rate widget overlap * Revise degradation save lifetime outputs in Help for #2087 Also fix broken references in Electricity Load topic. * Emphasis SRW is obsolete and fix format of weather file Help topics * Add description of calculation to capacity payment Help topic. * Revise Help for solar resource UI updates in #2120 * Clean up misc headings and broken links in Help * Revise Help build instructions * Fix broken welcome page Help link * Revise Help for IPH system control copy TOD factors for #2024 Also fix TOU output fractions widget label for IPH "turbine output" to "heat sink output". * Custom generation Help revisions for NatLabRockies/ssc#1384 * Clean up Help rates and load topics for NatLabRockies/ssc#1352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Remove deprecated Python handler and associated compute modules
Corresponding branches and PRs:
SSC PR NatLabRockies/ssc#1375
SAM-private https://github.com/NatLabRockies/SAM-private/pull/143
Unit Test Impact:
Expect SAM tests to pass (may have some excitement due to defaults updates)
Checklist