Conversation
… and disabling it with battery
…x always and disabling it with battery" This reverts commit 0cdfa75.
brtietz
approved these changes
Jul 1, 2025
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
This works, thanks for fixing! I expected an issue with Detailed-PV Battery Wind in the hybrid models, but because that's AC connected it doesn't trip the code of concern here.
5 tasks
Also align and resize degradation widgets.
cpaulgilman
approved these changes
Jul 1, 2025
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I made some changes to the widgets for consistency. Thanks!
cpaulgilman
added a commit
that referenced
this pull request
Jun 3, 2026
Also fix broken references in Electricity Load topic.
cpaulgilman
added a commit
that referenced
this pull request
Jun 9, 2026
… 2026 release (#2207) * Remove wind cost model descriptions for #2154 * Fix help build issues * Revise PV sizing topics for new PV UI design for #2135 * Clean up battery dispatch Help topics for #2115 * Revise Help for PVWatts detailed battery for #2113 * Update Help build instructions * Consolidate battery Help topics * Add description of load day of week input for #2109 Also fix Belpe annual growth rate widget overlap * Revise degradation save lifetime outputs in Help for #2087 Also fix broken references in Electricity Load topic. * Emphasis SRW is obsolete and fix format of weather file Help topics * Add description of calculation to capacity payment Help topic. * Revise Help for solar resource UI updates in #2120 * Clean up misc headings and broken links in Help * Revise Help build instructions * Fix broken welcome page Help link * Revise Help for IPH system control copy TOD factors for #2024 Also fix TOU output fractions widget label for IPH "turbine output" to "heat sink output". * Custom generation Help revisions for NatLabRockies/ssc#1384 * Clean up Help rates and load topics for NatLabRockies/ssc#1352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SAM#2008 describes a bug in which deselecting the option to save lifetime variables in a PV-Battery simulation leads SAM to crash. The underlying cause of the crash is described more thoroughly in the SAM issue, but briefly, it is a heap corruption bug caused by the smaller, non-lifetime allocations being too small to compute figures for the battery in cmod_pvsamv1.cpp.
This fixes this issue on the UI side by preventing users from deselecting the option to save lifetime variables for PV-Battery systems. It also provides a brief warning why this option is disabled.
Fixes # (issue(s))
#2008
Corresponding branches and PRs:
ssc/SAM_2008
Unit Test Impact:
Tests shouldn't be impacted.
Checklist