Ssc 195 day of week improvements#2109
Conversation
…pdate defaults accordingly
sjanzou
left a comment
There was a problem hiding this comment.
Lots of UI and default changes here... there are also 338 api changes - do you want those to go with this pull request?
sjanzou
left a comment
There was a problem hiding this comment.
All 174 default configuraitons run on MacOS 15.6 (arm64 build) with Clang 16.0.0.16000026 and XCode 16.2 without issue using wxWidgets 3.2.6
Ah, thanks for the reminder! Just pushed them. |
* Change label from "Jan 1st Day of Week" to "January 1 day of week". * Add tooltip on Electric Load page for consistency with other inputs. * Add UI message for TPO Host / Developer so users know Electric Load page and TOD Factors page inputs are linked.
cpaulgilman
left a comment
There was a problem hiding this comment.
Need to add January 1 day of week input to Electric Building Load Calculator form.
…y_of_week_improvements
…/NREL/SAM into ssc_195_day_of_week_improvements
cpaulgilman
left a comment
There was a problem hiding this comment.
@brtietz Thank you for adding start day of year to BELPE UI form.
Note for documentation that BELPE does not calculate different loads for weekdays and weekends, so this input has no impact on the load data itself.
I tested this a bit and for the default residential case there are slight differences: 
Start on Monday: Start on Saturday: Note where the 1.8 kW peaks land (weekdays appear to peak at 1.7). So not a huge difference (I have to lean in and squint), but this input does affect the BELPE results. |
…/NREL/SAM into ssc_195_day_of_week_improvements
|
@cpaulgilman Just flagging that I forgot to push the ssc changes until just now, so you wouldn't have seen any changes when you tested this morning. Doh! |
Good to know that BELPE bumps up the load slightly on weekend days. |
…y_of_week_improvements
|
Fixing an extra space between "January" and "1" on the input page label for the Electric load page, otherwise looks good with my testing! |
…y_of_week_improvements
… pvwatts changes from a previous PR as well
Also fix Belpe annual growth rate widget overlap
… 2026 release (#2207) * Remove wind cost model descriptions for #2154 * Fix help build issues * Revise PV sizing topics for new PV UI design for #2135 * Clean up battery dispatch Help topics for #2115 * Revise Help for PVWatts detailed battery for #2113 * Update Help build instructions * Consolidate battery Help topics * Add description of load day of week input for #2109 Also fix Belpe annual growth rate widget overlap * Revise degradation save lifetime outputs in Help for #2087 Also fix broken references in Electricity Load topic. * Emphasis SRW is obsolete and fix format of weather file Help topics * Add description of calculation to capacity payment Help topic. * Revise Help for solar resource UI updates in #2120 * Clean up misc headings and broken links in Help * Revise Help build instructions * Fix broken welcome page Help link * Revise Help for IPH system control copy TOD factors for #2024 Also fix TOU output fractions widget label for IPH "turbine output" to "heat sink output". * Custom generation Help revisions for NatLabRockies/ssc#1384 * Clean up Help rates and load topics for NatLabRockies/ssc#1352
Pull Request Template
Description
Add UI functionality for day of week behavior. This was implemented one of three places:
The host developer model has the pages for both (1) and (2) so that required the implementation of UI variables. The core SSC variable is on the financial analysis page so that the compute modules have access to it. Open to ideas on a cleaner approach here.
The LCOE models and No financial configurations use the ?=0 in the vartable and continue to default to Monday (maintaning the previous behavior). We can open this up if users ask.
Fixes NatLabRockies/ssc#195
Corresponding branches and PRs:
Develop for lk and wex
Corresponding ssc PR NatLabRockies/ssc#1352
Unit Test Impact:
No expected changes to SAM tests.
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)