Update Solar Resource UI forms for solar techs#2120
Conversation
Break Solar Resource Download form into three separate forms to simplify troubleshooting of UI callbacks: * Solar Resource Download * Solar Resource Information * Solar Resource Library Initial testing for PVWatts only.
* Add show log button (instead of automatically showing it after file downloads) * Realign widgets and edit labels
… in decimal degrees" default
* Improve identification of lat/lon pair as input * Remove location string from file name to avoid wfcheck failure when string contains some unicode characters, e.g., cyrillic.
Solar Resource Data broken down into three forms: * Solar Resource Download * Solar Resource Library * Solar Resource Information
No longer needed now that `use_specific_weather_file` is available to user on Solar Resource Library form.
Note `solar_data_file_name_load` variable removed from defaults in commit bd9fda4.
Remove commented-out code.
sjanzou
left a comment
There was a problem hiding this comment.
All my tests worked with a couple of comments:
- Maybe a little "Download Progress" dialog resizing to show entire "Close" button (Windows 11)
- Should the "Download" button be moved down to visually include the "Options" section?
There was a problem hiding this comment.
This is very nitpicky but with the new wxWidgets version it seems like the text on some UI objects is not vertically centered. See 'Default TMY file':
This is not something that can be changed at the IDE level.
Nothing else to add beyond comments in previous email discussion.
@sjanzou I put the Download button at the top to emphasize the most common workflow, which is to type an address and click Download. The stuff under the Options line is optional. I don't think there is an ideal layout that is best for all users, so this is a compromise. We have three workflows, and don't know of a great way to communicate that clearly: 1) Type an address and click Download, 2) Type and address, choose options, and click Download, and 3) Choose the Advanced option, click Download, and choose options in the Advanced NSRDB window. |
I created an issue for this: #2122 |
… 2026 release (#2207) * Remove wind cost model descriptions for #2154 * Fix help build issues * Revise PV sizing topics for new PV UI design for #2135 * Clean up battery dispatch Help topics for #2115 * Revise Help for PVWatts detailed battery for #2113 * Update Help build instructions * Consolidate battery Help topics * Add description of load day of week input for #2109 Also fix Belpe annual growth rate widget overlap * Revise degradation save lifetime outputs in Help for #2087 Also fix broken references in Electricity Load topic. * Emphasis SRW is obsolete and fix format of weather file Help topics * Add description of calculation to capacity payment Help topic. * Revise Help for solar resource UI updates in #2120 * Clean up misc headings and broken links in Help * Revise Help build instructions * Fix broken welcome page Help link * Revise Help for IPH system control copy TOD factors for #2024 Also fix TOU output fractions widget label for IPH "turbine output" to "heat sink output". * Custom generation Help revisions for NatLabRockies/ssc#1384 * Clean up Help rates and load topics for NatLabRockies/ssc#1352
Description
Redesign Solar Resource UI form to simplify debugging:
solar_data_file_name_loadvariable.Update geocode function in geotools.cpp
Fixes #1426
Corresponding branches and PRs:
Goes with Develop branches of SAM-private, SSC, WEX, and LK.
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)