fix: resolve tx custodian promise when set transaction to submitted or failed#3845
Merged
vinistevam merged 6 commits intomainfrom Jan 26, 2024
Merged
fix: resolve tx custodian promise when set transaction to submitted or failed#3845vinistevam merged 6 commits intomainfrom
vinistevam merged 6 commits intomainfrom
Conversation
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
2431602 to
8cdddaf
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
previously approved these changes
Jan 25, 2024
matthewwalsh0
approved these changes
Jan 26, 2024
13 tasks
vinistevam
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 30, 2024
## **Description** The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
shane-t
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 30, 2024
The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
13 tasks
shane-t
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 30, 2024
The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
13 tasks
13 tasks
zone-live
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Feb 7, 2024
…n (no cherry-pick) (#22730) ## **Description** Patches `@metamask/transaction-controller` to fix a critical issue with MMI Since `v11.9.0` is two major versions of `@metamask/transaction-controller`, it is safer to include this fix as a patch instead of including other multiple breaking changes. PR that addresses the change in the package: MetaMask/core#3845 PR that merges that change in develop: #22674 ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/jira/software/projects/MMI/boards/315?assignee=5e664f7f9abcc30ce60c3734&selectedIssue=MMI-4508 ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained what problem this PR is solving and how it is solved. - [X] I've linked related issues - [ ] I've included manual testing steps - [X] I've included screenshots/recordings if applicable - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [X] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to fix an issue with the custodian transaction where the promise is not resolved.
References
Changelog
@metamask/transaction-controllertxId:finishedwhen custodian transaction status is updated tosubmittedorfailedChecklist