Skip to content

[MMI] patch to 11.9 fixing issues with transacction promise resolution (no cherry-pick)#22730

Merged
zone-live merged 1 commit intoVersion-v11.9.1from
Version-v11.9.0-mmi-tx-controller-patch
Feb 7, 2024
Merged

[MMI] patch to 11.9 fixing issues with transacction promise resolution (no cherry-pick)#22730
zone-live merged 1 commit intoVersion-v11.9.1from
Version-v11.9.0-mmi-tx-controller-patch

Conversation

@bergarces
Copy link
Copy Markdown
Contributor

@bergarces bergarces commented Jan 30, 2024

Description

Patches @metamask/transaction-controller to fix a critical issue with MMI

Since v11.9.0 is two major versions of @metamask/transaction-controller, it is safer to include this fix as a patch instead of including other multiple breaking changes.

PR that addresses the change in the package: MetaMask/core#3845
PR that merges that change in develop: #22674

Related issues

Fixes:

https://consensyssoftware.atlassian.net/jira/software/projects/MMI/boards/315?assignee=5e664f7f9abcc30ce60c3734&selectedIssue=MMI-4508

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 30, 2024
@socket-security
Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@19.0.0 Transitive: environment, eval, filesystem, network +132 30 MB metamaskbot

🚮 Removed packages: npm/@metamask/transaction-controller@19.0.1, npm/xhr2@0.2.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/@metamask/swappable-obj-proxy@2.1.0
No contributors or author data npm/@metamask/eth-json-rpc-middleware@12.0.1
Network access npm/@metamask/eth-json-rpc-middleware@12.0.1
No contributors or author data npm/@metamask/json-rpc-engine@7.3.1
No contributors or author data npm/@metamask/eth-json-rpc-provider@2.3.1

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Why is contributor and author data important?

Package does not specify a list of contributors or an author in package.json.

Add a author field or contributors array to package.json.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/swappable-obj-proxy@2.1.0
  • @SocketSecurity ignore npm/@metamask/eth-json-rpc-middleware@12.0.1
  • @SocketSecurity ignore npm/@metamask/json-rpc-engine@7.3.1
  • @SocketSecurity ignore npm/@metamask/eth-json-rpc-provider@2.3.1

@bergarces bergarces changed the title fix: fix from package (no cherrypick) [MMI] patch to 11.9 fixing issues with transacction promise resolution (no cherry-pick) Jan 30, 2024
Base automatically changed from Version-v11.9.0 to master February 6, 2024 19:53
@zone-live zone-live changed the base branch from master to Version-v11.9.1 February 7, 2024 09:35
@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Feb 7, 2024
@zone-live zone-live marked this pull request as ready for review February 7, 2024 09:36
@zone-live zone-live requested a review from a team as a code owner February 7, 2024 09:36
@zone-live zone-live merged commit 0f63f77 into Version-v11.9.1 Feb 7, 2024
@zone-live zone-live deleted the Version-v11.9.0-mmi-tx-controller-patch branch February 7, 2024 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template mmi DEPRECATED: The product got sunset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants