Skip to content

chore: Upgrade @metamask/transaction-controller to v21.0.1#22674

Merged
vinistevam merged 9 commits intodevelopfrom
fix/mmi-resolve-promise
Jan 30, 2024
Merged

chore: Upgrade @metamask/transaction-controller to v21.0.1#22674
vinistevam merged 9 commits intodevelopfrom
fix/mmi-resolve-promise

Conversation

@vinistevam
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam commented Jan 26, 2024 •
edited
Loading

Description

The package @metamask/transaction-controller has been upgraded to v21.0.1.

This version has the following fixes:

  • Resolves transaction custodian promise when setting transaction status to submitted or failed (#3845)
  • Fix normalizer ensuring property type is always present in TransactionParams (#3817)

See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101

Related issues

Fixes:

Manual testing steps

Manual testing steps

  1. Transaction regression

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam
Copy link
Copy Markdown
Contributor Author

vinistevam commented Jan 26, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 26, 2024

No policy changes

@vinistevam vinistevam changed the title (WIP )fix: mmi tx promise when set status to submitted or failed (WIP ) Bum Update Transaction Controller Jan 29, 2024
@vinistevam vinistevam changed the title (WIP ) Bum Update Transaction Controller (WIP ) Update Transaction Controller Jan 29, 2024
@vinistevam
Copy link
Copy Markdown
Contributor Author

vinistevam commented Jan 29, 2024

@metamaskbot update-policies

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 29, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@21.0.1 Transitive: environment, eval, filesystem, network +128 29.9 MB brad.decker, danfinlay, gudahtt, ...9 more

View full report↗︎

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 29, 2024

Policies updated

@vinistevam vinistevam changed the title (WIP ) Update Transaction Controller chore: Upgrade @metamask/transaction-controller to v21.0.1 Jan 29, 2024
@vinistevam vinistevam added the team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead label Jan 29, 2024
@vinistevam vinistevam force-pushed the fix/mmi-resolve-promise branch from 718911e to f305139 Compare January 29, 2024 21:00
@vinistevam
Copy link
Copy Markdown
Contributor Author

vinistevam commented Jan 30, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 30, 2024

Policies updated

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd38cdb) 68.08% compared to head (ba7c06d) 68.08%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22674   +/-   ##
========================================
  Coverage    68.08%   68.08%           
========================================
  Files         1091     1091           
  Lines        42923    42923           
  Branches     11415    11415           
========================================
  Hits         29223    29223           
  Misses       13700    13700

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinistevam vinistevam marked this pull request as ready for review January 30, 2024 08:58
@vinistevam vinistevam requested a review from a team as a code owner January 30, 2024 08:58
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 30, 2024

Builds ready [ba7c06d]
Page Load Metrics (881 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1041831322311
domContentLoaded126126147
load79110628816631
domInteractive126126147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 88 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 104 Bytes (0.00%)

@bergarces
Copy link
Copy Markdown
Contributor

bergarces commented Jan 30, 2024

Tested the issue with the custodian transaction using this branch. It works as expected now.

@vinistevam vinistevam merged commit 8317671 into develop Jan 30, 2024
@vinistevam vinistevam deleted the fix/mmi-resolve-promise branch January 30, 2024 10:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bergarces bergarces bergarces approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

Assignees

No one assigned

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vinistevam @metamaskbot @bergarces @OGPoyraz @DDDDDanica