Fix: normalizer ensuring type is always present in TransactionParams#3817
Merged
vinistevam merged 2 commits intomainfrom Jan 24, 2024
Merged
Fix: normalizer ensuring type is always present in TransactionParams#3817vinistevam merged 2 commits intomainfrom
vinistevam merged 2 commits intomainfrom
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
13 tasks
| gasPrice: '0x1', | ||
| to: ACCOUNT_MOCK, | ||
| value: '0x0', | ||
| type: TransactionType.simpleSend, |
Member
There was a problem hiding this comment.
Good spot 😄 It's a fun one having a type property in both the parameters and the options.
| estimatedBaseFee: (maxPriorityFeePerGas: string) => | ||
| addHexPrefix(maxPriorityFeePerGas), | ||
| type: (type: string) => (type === '0x0' ? '0x0' : undefined), | ||
| type: (type: string) => addHexPrefix(type), |
Member
There was a problem hiding this comment.
In a future PR, we could go one step further and always derive a type even if one wasn't provided by looking at whether there is gasPrice or maxFeePerGas etc.
That's what we already do on submission using isEIP1559Transaction.
Perhaps worth confirming by testing an older commit with the extension controller, but my understanding is if a dapp transaction doesn't specify type, it won't be in the parameters either since the extension sources the parameters from here.
Member
There was a problem hiding this comment.
I think this would be a good addition yeah! 👍
matthewwalsh0
approved these changes
Jan 23, 2024
OGPoyraz
approved these changes
Jan 24, 2024
FrederikBolding
approved these changes
Jan 24, 2024
Member
FrederikBolding
left a comment
There was a problem hiding this comment.
Can confirm this fixed in the snaps issue!
13 tasks
vinistevam
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 30, 2024
## **Description** The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
shane-t
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 30, 2024
The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
shane-t
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 30, 2024
The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to ensure
typeis always present in theTransactionParamsby matching the old Extension Normalizer.References
Changelog
@metamask/transaction-controllertypenormalizer to use theaddHexPrefixand do not set thetypeasundefined.Checklist