build - correctly set METAMASK_ENV via envify#3845
Merged
Conversation
Collaborator
tmashuang
approved these changes
Apr 3, 2018
vinistevam
added a commit
that referenced
this pull request
Jan 30, 2024
## **Description** The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
shane-t
pushed a commit
that referenced
this pull request
Jan 30, 2024
The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
shane-t
pushed a commit
that referenced
this pull request
Jan 30, 2024
The package `@metamask/transaction-controller` has been upgraded to `v21.0.1`. This version has the following fixes: - Resolves transaction custodian promise when setting transaction status to submitted or failed ([#3845](MetaMask/core#3845)) - Fix normalizer ensuring property type is always present in TransactionParams ([#3817](MetaMask/core#3817)) See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/transaction-controller/CHANGELOG.md#2101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i refactored + optimized the build system, I accidently moved minification before our environment var injection, and this broke setting METAMASK_ENV to prod.
Seems to only have a couple small side effects: