Add focus to field Link in the "Add file link" dialog. by ankamde · Pull Request #13520 · JabRef/jabref

ankamde · 2025-07-09T18:16:10Z

Closes #13486

This is the PR request for issue no #13486

Steps to test

Open JabRef
Create a new library: File → New library
Click the + button in the toolbar to add a new entry
In the entry editor, select the General tab
In the File section, click the + button
The "Add file link" dialog appears and the "Link" is focused

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[/] Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor · 2025-07-09T18:27:16Z

Please follow the review given at #13500 (comment)

ankamde · 2025-07-09T18:35:03Z

@koppor My PR is obsolete - there's existing PR for this issue (#13500). Can I just close this one? I haven't seen anyone being assinged so I grabbed it.
[UPDATE] I've made required change, please have a look.

…utton clicked.

ankamde · 2025-07-09T19:07:48Z

Do I also have to remove link.requestFocus() from this method:

@FXML
private void openBrowseDialog(ActionEvent event) {
    viewModel.openBrowseDialog();
    link.requestFocus();
}

koppor · 2025-07-10T04:31:32Z

Do I also have to remove link.requestFocus() from this method:
@FXML
private void openBrowseDialog(ActionEvent event) {
    viewModel.openBrowseDialog();
    link.requestFocus();
}

Why should it be removed? Because your functionality also covers this case?

koppor · 2025-07-10T04:32:09Z


 ### Changed
-
+- We added focus 


Please complete this. Also add a link

Why should it be removed? Because your functionality also covers this case? -> Hmmm...Let me have alook later on this code. Perhaps my commen is obsolete.
Please complete this... -> goot catch!

Did you think aloud? Not sure if this an AI-generated comment?

:) Yes - I was thinkig aloud. No AI involvement.

@koppor Hi, CHANGELOG.MD has been updated. Please have a look.

koppor · 2025-07-11T02:43:04Z

Do I also have to remove link.requestFocus() from this method:
@FXML
private void openBrowseDialog(ActionEvent event) {
    viewModel.openBrowseDialog();
    link.requestFocus();
}
Why should it be removed? Because your functionality also covers this case?

I think, the answer is yes - remove it.

Please look at https://github.com/JabRef/jabref/pull/13520/files for another view on the comments by format checkers. Should be easy to fix.

…owserDialog() method.

ankamde · 2025-07-11T15:25:44Z

@koppor I've addressed all of the comments. Please have a look.

calixtus · 2025-07-10T21:57:30Z

    }
+
+    private void onDialogShow(DialogEvent event) {
+        Platform.runLater(() -> link.requestFocus());


Please use UiTaskExecutor::runInJavaFxThread . Though it is only a wrapper for Platform::runLater , idea is to have an abstraction on javafx und keep some flexibility in the codebase.

@calixtus Done, please have a look.

koppor · 2025-07-12T14:56:11Z


 ### Changed

+- We added focus on the field Link in the "Add file link" dialog. [#13486](https://github.com/JabRef/jabref/issues/13486)


The second word is "added". Thus, please, add this to section "Added". Or rephrase. As is, it is confusing

@koppor Moved to appropiate section, please have a look.

trag-bot · 2025-07-13T07:58:15Z

@trag-bot didn't find any issues in the code! ✅✨

* upstream/main: Bump com.squareup.okhttp3:okhttp from 5.0.0 to 5.1.0 in /versions (#13541) Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion (#13532) New Crowdin updates (#13548) Add focus to field Link in the "Add file link" dialog. (#13520) Bump org.ow2.asm:asm from 9.6 to 9.8 in /versions (#13547) Make validation optional for saving library properties preferences (#13488) Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /versions (#13546) --porcelain does not output any info or warn errors on the console (#13469) Bump jablib/src/main/resources/csl-locales from `7e137db` to `3bad433` (#13545) Refine "File exists" warning (#13491) Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.8.0 to 3.11.1 (#13544) Bump org.openrewrite.rewrite from 7.8.0 to 7.11.0 (#13542) Bump jablib/src/main/resources/csl-styles from `704ff9f` to `59f124d` (#13540) Add architecture test for logging infrastructure (#13534) More harsh test on title of PR New Crowdin updates (#13533) Update extra-java-module-info plugin (#13527) [Junie]: fix: display help output for --help argument (#13446) Refactor OpenExternalFileAction (#13508)

Add focus to field Link in the "Add file link" dialog.

395d303

andrzej-kaminski added 2 commits July 9, 2025 20:43

Addressing PR comments + modify CHANGELOG.md

f856de9

Reimplementing slightly due to an exception being thronw when close b…

240face

…utton clicked.

andrzej-kaminski added 2 commits July 9, 2025 21:24

Use method reference

7c6c0d4

Rename onDialogShow method argument.

229d236

koppor reviewed Jul 10, 2025

View reviewed changes

ankamde added 2 commits July 10, 2025 17:50

Finish updating CHANGELOG.md

eb31a5a

Finish updating CHANGELOG.md

739d4ac

ankamde added 2 commits July 11, 2025 17:16

Add missing blank line after paragraph.

ca62d86

Remove unnecessary call to requestFocus() on link TextField in openBr…

dcb910d

…owserDialog() method.

calixtus reviewed Jul 11, 2025

View reviewed changes

Use UiTaskExecutor wrapper to request focus on link TextField.

46fa621

koppor requested changes Jul 12, 2025

View reviewed changes

Move entry in CHANGELOG.md to appropriate section.

543e8e5

calixtus approved these changes Jul 13, 2025

View reviewed changes

koppor enabled auto-merge July 13, 2025 22:48

koppor added this pull request to the merge queue Jul 15, 2025

koppor approved these changes Jul 15, 2025

View reviewed changes

Merged via the queue into JabRef:main with commit 281ffac Jul 15, 2025
1 check passed

github-actions Bot mentioned this pull request Jul 15, 2025

Dialog "Add file link" should focus field "Link" when opening #13486

Closed


		### Changed

		- We added focus on the field Link in the "Add file link" dialog. [#13486](https://github.com/JabRef/jabref/issues/13486)

Uh oh!

Conversation

ankamde commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

koppor commented Jul 9, 2025

Uh oh!

ankamde commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ankamde commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koppor commented Jul 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankamde Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor commented Jul 11, 2025

Uh oh!

ankamde commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trag-bot Bot commented Jul 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ankamde commented Jul 9, 2025 •

edited

Loading

ankamde commented Jul 9, 2025 •

edited

Loading

ankamde commented Jul 9, 2025 •

edited

Loading

ankamde Jul 10, 2025 •

edited

Loading

ankamde commented Jul 11, 2025 •

edited

Loading