fix(jabgui): focus to link field whe open dialog#13500
Conversation
|
@trag-bot didn't find any issues in the code! ✅✨ |
| fileType.valueProperty().bindBidirectional(viewModel.selectedExternalFileTypeProperty()); | ||
| sourceUrl.textProperty().bindBidirectional(viewModel.sourceUrlProperty()); | ||
|
|
||
| Platform.runLater(() -> link.requestFocus()); |
There was a problem hiding this comment.
@calixtus This is differrent than the stack overflow solution from https://stackoverflow.com/a/70021819/873282 - is it also OK?
There was a problem hiding this comment.
DevCall: @nothiaki Please follow https://stackoverflow.com/a/70021819/873282 if you can.
There was a problem hiding this comment.
Reason: lifecycle could be "problematic" - there is no guarantee that intializate is called right before showing the dialog.
|
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it. In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push. |
|
Other contributor works in this now. |
|
The reason for the double work is that @nothiaki did not follow our contributing guide to get a task assigned: https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md#getting-a-task-assigned |
Closes #13486
focus to link field when open LinkedFileEditDialog
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)