Skip to content

Add focus to field Link in the "Add file link" dialog. #13520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koppor merged 11 commits into from
Jul 15, 2025
Merged

Add focus to field Link in the "Add file link" dialog. #13520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
395d303
Add focus to field Link in the "Add file link" dialog.
andrzej-kaminski Jul 9, 2025
f856de9
Addressing PR comments + modify CHANGELOG.md
andrzej-kaminski Jul 9, 2025
240face
Reimplementing slightly due to an exception being thronw when close b…
andrzej-kaminski Jul 9, 2025
7c6c0d4
Use method reference
andrzej-kaminski Jul 9, 2025
229d236
Rename onDialogShow method argument.
andrzej-kaminski Jul 9, 2025
eb31a5a
Finish updating CHANGELOG.md
ankamde Jul 10, 2025
739d4ac
Finish updating CHANGELOG.md
ankamde Jul 10, 2025
ca62d86
Add missing blank line after paragraph.
ankamde Jul 11, 2025
dcb910d
Remove unnecessary call to requestFocus() on link TextField in openBr…
ankamde Jul 11, 2025
46fa621
Use UiTaskExecutor wrapper to request focus on link TextField.
ankamde Jul 12, 2025
543e8e5
Move entry in CHANGELOG.md to appropriate section.
ankamde Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Added

- We added focus on the field Link in the "Add file link" dialog. [#13486](https://github.com/JabRef/jabref/issues/13486)
- We introduced a settings parameter to manage citations' relations local storage time-to-live with a default value set to 30 days. [#11189](https://github.com/JabRef/jabref/issues/11189)
- We distribute arm64 images for Linux. [#10842](https://github.com/JabRef/jabref/issues/10842)
- When adding an entry to a library, a warning is displayed if said entry already exists in an active library. [#13261](https://github.com/JabRef/jabref/issues/13261)
Expand Down
9 changes: 8 additions & 1 deletion jabgui/src/main/java/org/jabref/gui/linkedfile/LinkedFileEditDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
import javafx.fxml.FXML;
import javafx.scene.control.ButtonType;
import javafx.scene.control.ComboBox;
import javafx.scene.control.DialogEvent;
import javafx.scene.control.TextField;

import org.jabref.gui.DialogService;
import org.jabref.gui.StateManager;
import org.jabref.gui.externalfiletype.ExternalFileType;
import org.jabref.gui.preferences.GuiPreferences;
import org.jabref.gui.util.BaseDialog;
import org.jabref.gui.util.UiTaskExecutor;
import org.jabref.gui.util.ViewModelListCellFactory;
import org.jabref.logic.l10n.Localization;
import org.jabref.logic.util.StandardFileType;
Expand Down Expand Up @@ -86,11 +88,16 @@ private void initialize() {
link.textProperty().bindBidirectional(viewModel.linkProperty());
fileType.valueProperty().bindBidirectional(viewModel.selectedExternalFileTypeProperty());
sourceUrl.textProperty().bindBidirectional(viewModel.sourceUrlProperty());

this.setOnShown(this::onDialogShow);
}

@FXML
private void openBrowseDialog(ActionEvent event) {
viewModel.openBrowseDialog();
link.requestFocus();
}

private void onDialogShow(DialogEvent event) {
UiTaskExecutor.runInJavaFXThread(link::requestFocus);
}
}