Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion#13532
Conversation
|
Codewise goes in the right direction.
Pleases add a test case and follow the formal instructions
|
|
@Siedlerchr thank you for the confirmation that my code is in the right direction. But yeah, i still need to add the test case, which is why i just created a draft PR which only has the fix in it. I will have the PR in "Ready for review" once I am done with the test case and the required format for submitting the PR! |
| private final StateManager stateManager; | ||
| private final GuiPreferences preferences; | ||
|
|
||
|
|
There was a problem hiding this comment.
Please do not add additoinal empty lines.
Maybe, the changes of this class can be reverted as only empty lines were added?
There was a problem hiding this comment.
oh yeah for sure ill remove them, its just i added a statement there and then deleted it, hence the empty line.
|
Please create a proper title for your pr. We don't have a magic fortune teller ball. |
|
@calixtus yes you are right. but as I said in the earlier comments its a draft PR because its still a work in progress. I will have everything pitch perfect when i change it to "Ready for review". but i will keep in mind for future pull requests even if they are draft to name them better. |
It is passing.
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
Hey @koppor ! just wondering if you can review my PR and lmk if i need to make any changes or am i good to merge. Thanks ! |
* upstream/main: Bump com.squareup.okhttp3:okhttp from 5.0.0 to 5.1.0 in /versions (#13541) Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion (#13532) New Crowdin updates (#13548) Add focus to field Link in the "Add file link" dialog. (#13520) Bump org.ow2.asm:asm from 9.6 to 9.8 in /versions (#13547) Make validation optional for saving library properties preferences (#13488) Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /versions (#13546) --porcelain does not output any info or warn errors on the console (#13469) Bump jablib/src/main/resources/csl-locales from `7e137db` to `3bad433` (#13545) Refine "File exists" warning (#13491) Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.8.0 to 3.11.1 (#13544) Bump org.openrewrite.rewrite from 7.8.0 to 7.11.0 (#13542) Bump jablib/src/main/resources/csl-styles from `704ff9f` to `59f124d` (#13540) Add architecture test for logging infrastructure (#13534) More harsh test on title of PR New Crowdin updates (#13533) Update extra-java-module-info plugin (#13527) [Junie]: fix: display help output for --help argument (#13446) Refactor OpenExternalFileAction (#13508)
Closes #13418
Fix Description
Basically the title was not being filtered before the URL for "Search ShortSience" was built. so I updated it to passing the filtered title. I am filtering the title using org.jabref.model.strings.LatexToUnicodeAdapter.
Specifically i am using the format method as it has a fallback in it to return the original text if no latex is found, so I did not have to use any if statements or the .orElse()
Steps to test
I have created the test getShortScienceSearchURLWithoutLaTeX() in ExternalLinkCreator.java
The test is basically doing the following:
Manual Testing (if anyone wants to)
@Article{Kopp2009,
author = {Oliver Kopp and Daniel Martin and Daniel Wutke and Frank Leymann},
journal = {Enterprise Modelling and Information Systems},
title = {{The Difference Between Graph-Based and Block-Structured Business Process Modelling Languages}},
year = {2009},
month = jun,
number = {1},
pages = {3--13},
volume = {4},
}
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)