Skip to content

Update extra-java-module-info plugin#13527

Merged
koppor merged 5 commits into
mainfrom
uddate-extra-module-info
Jul 13, 2025
Merged

Update extra-java-module-info plugin#13527
koppor merged 5 commits into
mainfrom
uddate-extra-module-info

Conversation

@koppor

@koppor koppor commented Jul 11, 2025

Copy link
Copy Markdown
Member

Refs gradlex-org/extra-java-module-info#189 (comment) and APIdia-net/apidia.net#2 (comment)

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label Jul 11, 2025
@koppor koppor enabled auto-merge July 11, 2025 10:13
jabref-machine
jabref-machine previously approved these changes Jul 11, 2025
View reviewed changes
@koppor

koppor commented Jul 11, 2025

Copy link
Copy Markdown
Member Author

We need to fix that

 > Could not resolve all files for configuration ':jabsrv:testCompileClasspath'.
   > Failed to transform jersey-test-framework-provider-grizzly2-3.1.10.jar (org.glassfish.jersey.test-framework.providers:jersey-test-framework-provider-grizzly2:3.1.10) to match attributes {artifactType=jar, javaModule=true, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-api}.
      > Execution failed for ExtraJavaModuleInfoTransform: /home/runner/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.test-framework.providers/jersey-test-framework-provider-grizzly2/3.1.10/857ff6c34234ae327093a6f15406096a1a4c56b2/jersey-test-framework-provider-grizzly2-3.1.10.jar.
         > The name 'jersey.test.provider.grizzly2' is different than the name derived from the Jar file name 'jersey.test.framework.provider.grizzly2'; turn off 'failOnModifiedDerivedModuleNames' or explicitly allow override via 'overrideModuleName()'

@Siedlerchr

Siedlerchr commented Jul 11, 2025

Copy link
Copy Markdown
Member

Seems like c you just need to adapt the module name

@Siedlerchr
Merge remote-tracking branch 'upstream/main' into uddate-extra-module…
d6be590 
…-info

* upstream/main:
  Also label PR if good first issue is made (#13526)
  New Crowdin updates (#13529)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.1 (#13528)
  chore: bump-okhttp-4.12.0-to-5.0.0 (#13521)
@Siedlerchr
fix module name
7d648ba
jabref-machine
jabref-machine previously approved these changes Jul 12, 2025
View reviewed changes
@Siedlerchr

Siedlerchr commented Jul 12, 2025

Copy link
Copy Markdown
Member

Interestingly, checkstyle fails because of a module resolution error, but the rest works?

jabref-machine
jabref-machine previously approved these changes Jul 13, 2025
View reviewed changes
@koppor

koppor commented Jul 13, 2025

Copy link
Copy Markdown
Member Author

Checkstyle output:

 > Could not resolve all files for configuration ':jablib:jmhCompileClasspath'.
   > Failed to transform jopt-simple-5.0.4.jar (net.sf.jopt-simple:jopt-simple:5.0.4) to match attributes {artifactType=jar, javaModule=true, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-api}.
      > Execution failed for ExtraJavaModuleInfoTransform: /home/runner/.gradle/caches/modules-2/files-2.1/net.sf.jopt-simple/jopt-simple/5.0.4/4fdac2fbe92dfad86aa6e9301736f6b4342a3f5c/jopt-simple-5.0.4.jar.
         > The name 'net.sf.jopt.simple' is different than the name derived from the Jar file name 'jopt.simple'; turn off 'failOnModifiedDerivedModuleNames' or explicitly allow override via 'overrideModuleName()'

@trag-bot

trag-bot Bot commented Jul 13, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue Jul 13, 2025
Merged via the queue into main with commit fd8df14 Jul 13, 2025
2 checks passed
@koppor koppor deleted the uddate-extra-module-info branch July 13, 2025 00:29
Siedlerchr added a commit that referenced this pull request Aug 2, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
cb77f24 
* upstream/main:
  Bump com.squareup.okhttp3:okhttp from 5.0.0 to 5.1.0 in /versions (#13541)
  Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion (#13532)
  New Crowdin updates (#13548)
  Add focus to field Link in the "Add file link" dialog. (#13520)
  Bump org.ow2.asm:asm from 9.6 to 9.8 in /versions (#13547)
  Make validation optional for saving library properties preferences (#13488)
  Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /versions (#13546)
  --porcelain does not output any info or warn errors on the console (#13469)
  Bump jablib/src/main/resources/csl-locales from `7e137db` to `3bad433` (#13545)
  Refine "File exists" warning (#13491)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.8.0 to 3.11.1 (#13544)
  Bump org.openrewrite.rewrite from 7.8.0 to 7.11.0 (#13542)
  Bump jablib/src/main/resources/csl-styles from `704ff9f` to `59f124d` (#13540)
  Add architecture test for logging infrastructure (#13534)
  More harsh test on title of PR
  New Crowdin updates (#13533)
  Update extra-java-module-info plugin (#13527)
  [Junie]: fix: display help output for --help argument (#13446)
  Refactor OpenExternalFileAction  (#13508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jabref-machine jabref-machine jabref-machine approved these changes

Assignees

No one assigned

Labels

automerge PR is tagged with that label will be merged if workflows are green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koppor @Siedlerchr @jabref-machine