Conversation
Fix regex to parse passphrase from .env file if newline char or space is added
* Running WASM tests with Cargo
#1963) Infrastructure for ARRR lightwallet servers uses a fork of lightwalletd, this commit renames the grpc service from cash.z.wallet.sdk.rpc; to pirate.wallet.sdk.rpc; to use the lightwalletd fork.
This PR fixes failing wasm tests and test_utxo_lock by making these tests use the DOC/MARTY electrums
…ne (#1958) This commit: - Adds Storable State Machine abstraction with a goal to have as fewer changes to existing state machines as possible. - Implements successful swap v2 of UTXO to UTXO coin. Adds tests for such swap using dockerized komodod daemons. - Adds Swap V2 message exchange using Protobuf.
|
https://1209k.com/bitcoin-eye/ele.php?chain=tbch has some working tBCH electrums |
…#1945) This implements streaming channels using mpsc(underlying part of SSE) and SSE for sending data to clients continuously, NETWORK event is implemented to show the new functionality. All platforms other than WASM are supported. --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
This commit brings new p2p layer that uses the latest stable libp2p version and deprecates the old p2p layer. --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
previously approved these changes
Oct 2, 2023
This commit also changes the minimum trading volume for evm and tendermint to be the smallest possible amount of the coin and reduce minimum trading price to be any value above 0
For some reason, mocktopus dependency can not mock the p2p context after the p2p stack upgrade. This commit fixes this by avoiding mocking p2p context for tests. --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
HashSet is used instead of Vec in some places to remove use of dedup
* This commit does the following:
* Adds `p2p` and `event-stream` features to `mm2_net` crate to avoid adex-cli depending on `mm2-libp2p` and rust-libp2p in turn.
* Moves all RICK/MORTY electrums in tests to DOC/MARTY except 4 tests
* Fixes WASM `test_send` test by using `ALICE_PASSPHRASE` for the keypair (makes WASM tests green again).
*Todo in another commit
* Move these tests to DOC/MARTY electrums
* `test_hd_utxo_tx_history`
* `test_search_for_swap_tx_spend_electrum_was_refunded `
* `test_search_for_swap_tx_spend_electrum_was_spent `
* `test_send_maker_spends_taker_payment_recoverable_tx `
* Rename all instances of RICK/MORTY to DOC/MARTY
For KMD, taker fee payment algorithm is updated by burning up to 25% of the dex fee amount. This is achieved by adding a new output to the DEX fee transaction that is an OP_RETURN with up to 25% of the fee burned in KMD. We also Validate the new output by the maker as part of the taker fee validation step. --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
`168.119.236.249` will be used to cut the communication on the old main network by giving information about the new main network, it will be run using this branch https://github.com/KomodoPlatform/komodo-defi-framework/tree/patch-for-deprecation Signed-off-by: onur-ozkan <work@onurozkan.dev>
Note added about adding peer scorer Signed-off-by: onur-ozkan <work@onurozkan.dev>
* `nft_cache_db` was added in `NftCtx` for non wasm targets. * `AsyncConnection` structure was created in `mm2src/db_common/src/async_sql_conn.rs`. It can be used as async wrapper for sqlite connection. * `async_sqlite_connection` field was added in `MmCtx`. * Spam transfers with empty meta no longer update.
ca333
previously approved these changes
Dec 13, 2023
ca333
left a comment
There was a problem hiding this comment.
secure code reviewed
jfyi - RustSEC advisory DB threw: 6 vulnerabilities found!
however nothing critical found, mostly (general/known & local) DoS attack surface.
* libp2p-yamux now uses yamux v0.13 (new version) by default and fall back to yamux v0.12 (old version) when setting any configuration options. * Additionally, this commit increases the backpressure buffer cap from 25 to 256. * Use new protocol version (Version2) for peer exchange and request-response behaviours.
An additional PRICE_ENDPOINTS url which is a cached copy of https://prices.komodian.info/api/v2/tickers and is updated every minute was added by this commit. This should serve as a reliable fallback when rate limiting becomes an issue.
This allows finding mm2 ports in stdout
Alrighttt
reviewed
Dec 15, 2023
Alrighttt
approved these changes
Dec 17, 2023
Alrighttt
left a comment
There was a problem hiding this comment.
Secure code reviewed. Good work, everyone!
|
Reviewed. Approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
COIN_BALANCEevents for Tendermint Protocol were added in #1978.Enhancements/Fixes:
7777network was deprecated in #2020.netid8762were updated in #2024.libp2p-yamuxnow uses yamuxv0.13(new version) by default and fall back to yamuxv0.12(old version) when setting any configuration options in #2030.25to256in #2030.exclude_spamandexclude_phishingparams were added forget_nft_listandget_nft_transfersRPCs in #1959.nft_cache_dbwas added inNftCtxfor non wasm targets in #1989.AsyncConnectionstructure that can be used as async wrapper for sqlite connection was added in #1989.async_sqlite_connectionfield was added toMmCtxin #1989.from cash.z.wallet.sdk.rpctopirate.wallet.sdk.rpcto use the lightwalletd fork in #1963.sync_paramsare not provided after restart in #1967.hyper-rustls,rustlsand other deps was set in #1956.PUBLIC_METHODSthat require no login in #2001.rpcportvalue can now accept a string after #2026.PRICE_ENDPOINTSurl which is a cached copy ofhttps://prices.komodian.info/api/v2/tickersand is updated every minute was added in #2032.NB - Backwards compatibility breaking changes:
7777Network deprecation and the upgrade to a new p2p layer breaks compatibility with previous versions of Komodo DeFi Framework. Connections between nodes/clients running an older version of Komodo DeFi Framework and nodes/clients running this latest version will not be possible. To avoid this, all nodes/clients must be upgraded to the latest version of Komodo DeFi Framework.coin/KMDswap are changed and makers running older versions will not be able to validate the taker fee, this will cause the swap to fail. This case will never happen anyway because older versions will not be able to connect to this latest version due to the network upgrade.