Skip to content

fix(cli): make mm2-libp2p optional in mm2_net for adex-cli#1997

Merged
shamardy merged 13 commits intodevfrom
fix-add-network-events-feat
Oct 25, 2023
Merged

fix(cli): make mm2-libp2p optional in mm2_net for adex-cli#1997
shamardy merged 13 commits intodevfrom
fix-add-network-events-feat

Conversation

@shamardy
Copy link
Copy Markdown
Collaborator

@shamardy shamardy commented Oct 20, 2023 •
edited
Loading

  • Added p2p and event-stream features to mm2_net crate to avoid adex-cli depending on mm2-libp2p and rust-libp2p in turn.
  • Moved all RICK/MORTY electrums in tests to DOC/MARTY except
    • test_hd_utxo_tx_history
    • test_search_for_swap_tx_spend_electrum_was_refunded
    • test_search_for_swap_tx_spend_electrum_was_spent
    • test_send_maker_spends_taker_payment_recoverable_tx
  • Show raw response body from EVM nodes in case deserializing fails (shows untagged enum real error message)
  • Fixed WASM test_send test by using ALICE_PASSPHRASE for the keypair (make WASM tests green again).

Todo in another PR

  • Move these tests to DOC/MARTY electrums
    • test_hd_utxo_tx_history
    • test_search_for_swap_tx_spend_electrum_was_refunded
    • test_search_for_swap_tx_spend_electrum_was_spent
    • test_send_maker_spends_taker_payment_recoverable_tx
  • Rename all instances of RICK/MORTY to DOC/MARTY

@shamardy shamardy requested a review from laruh October 20, 2023 19:36
laruh
laruh previously approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@shamardy shamardy requested a review from laruh October 24, 2023 15:09
laruh
laruh suggested changes Oct 25, 2023
View reviewed changes
Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot for the fixes!
Have some note.

laruh
laruh approved these changes Oct 25, 2023
View reviewed changes
Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shamardy shamardy merged commit 3e323df into dev Oct 25, 2023
@shamardy shamardy deleted the fix-add-network-events-feat branch October 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@laruh laruh laruh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shamardy @laruh