Skip to content

test(zhtlc): Use alternative grpc service name for pirate lightwalletd#1963

Merged
shamardy merged 5 commits intodevfrom
support-pirate-litewallets
Sep 11, 2023
Merged

test(zhtlc): Use alternative grpc service name for pirate lightwalletd#1963
shamardy merged 5 commits intodevfrom
support-pirate-litewallets

Conversation

@smk762
Copy link
Copy Markdown

@smk762 smk762 commented Sep 8, 2023 •
edited
Loading

ref: https://github.com/PirateNetwork/lightwalletd/blob/master/walletrpc/service.proto#L7

Infrastructure for ARRR lightwallet servers uses a fork of lightwalletd which has renamed the grpc service name from cash.z.wallet.sdk.rpc; to pirate.wallet.sdk.rpc;

To use these, the changes in this PR are needed. Once merged, existing lightwalletd servers from ZOMBIE will need to run on the pirate fork of lightwalletd.

Until these changes are merged, a single lightwalletd server configured with cash.z.wallet.sdk.rpc; is available. This server will remain online over the period between next api release and related app releases.

To test:

  1. Activate ARRR with one (or all) of the following servers:
"light_wallet_d_servers": [
    "https://lightd1.pirate.black:443",
    "https://piratelightd1.cryptoforge.cc:443",
    "https://piratelightd2.cryptoforge.cc:443",
    "https://piratelightd3.cryptoforge.cc:443",
    "https://piratelightd4.cryptoforge.cc:443"
]

and the electrum servers in https://github.com/KomodoPlatform/coins/pull/811/files

  • Confirm activation is successful, and you are able to swap and send/receive ARRR
  1. Activate ARRR with the following server:
"light_wallet_d_servers": ["https://pirate.spyglass.quest:9447"]

and the electrum servers in https://github.com/KomodoPlatform/coins/pull/811/files

  • Confirm activation fails with "error":"All the current light clients are unavailable."
  1. Repeat the second test using https://github.com/KomodoPlatform/komodo-defi-framework/releases/tag/v1.0.7-beta
  • Confirm activation is successful

@smk762 smk762 marked this pull request as draft September 8, 2023 10:55
@smk762 smk762 changed the title Add alternatve grpc service name for pirate lightwalletd test(zhtlc): Add alternative grpc service name for pirate lightwalletd Sep 8, 2023
@smk762 smk762 marked this pull request as ready for review September 8, 2023 12:38
@smk762 smk762 mentioned this pull request Sep 8, 2023
Merged
kivqa
kivqa approved these changes Sep 8, 2023
View reviewed changes
Copy link
Copy Markdown

@kivqa kivqa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
ARRR coin activation was completed as expected.

{"mmrpc":"2.0","result":{"status":"InProgress","details":{"BuildingWalletDb":{"first_sync_block":{"requested":2558042,"is_pre_sapling":false,"actual":2558042},"current_scanned_block":2558042,"latest_block":2559482}}},"id":null}

{"mmrpc":"2.0","result":{"status":"Ok","details":{"ticker":"ARRR","current_block":2559482,"wallet_balance":{"wallet_type":"Iguana","address":"zs1gn3mxk493yyvyu8ffsgj6kt3luajdezwr6t7lzzfjf34u4nzztze3r44wplm0ry95tp4uang9yg","balance":{"spendable":"0","unspendable":"0"}},"first_sync_block":{"requested":2558042,"is_pre_sapling":false,"actual":2558042}}},"id":null}

@smk762 smk762 added P1 labels Sep 8, 2023
shamardy
shamardy previously approved these changes Sep 8, 2023
View reviewed changes
@smk762 smk762 changed the title test(zhtlc): Add alternative grpc service name for pirate lightwalletd test(zhtlc): Use alternative grpc service name for pirate lightwalletd Sep 8, 2023
@smk762 smk762 mentioned this pull request Sep 8, 2023
Closed
artemii235
artemii235 previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown

@artemii235 artemii235 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note for the future: if we would like to support original Zcash/lightwalletd, we will need to add their proto definitions and use them, depending on the ticker of the coin (or make it configurable somehow).

@shamardy shamardy dismissed stale reviews from artemii235 and themself via a50a5e7 September 11, 2023 10:39
@shamardy shamardy merged commit d055cba into dev Sep 11, 2023
@shamardy shamardy deleted the support-pirate-litewallets branch September 11, 2023 16:22
@shamardy shamardy mentioned this pull request Dec 15, 2023
Merged
@smk762 smk762 mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shamardy shamardy shamardy left review comments

+2 more reviewers

@kivqa kivqa kivqa approved these changes

@artemii235 artemii235 artemii235 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smk762 @artemii235 @shamardy @kivqa