chore(docs): run WASM tests with Cargo#1965
Conversation
[release] v1.0.3
[release] v1.0.4-beta
chore(release): v1.0.5-beta
chore(release): v1.0.6-beta
chore(release): v1.0.7-beta
docs/DEV_ENVIRONMENT.md
Outdated
| CC=/opt/homebrew/opt/llvm/bin/clang AR=/opt/homebrew/opt/llvm/bin/llvm-ar wasm-pack test --firefox --headless mm2src/mm2_main | ||
| ``` | ||
| Please note `CC` and `AR` must be specified in the same line as `wasm-pack test mm2src/mm2_main`. | ||
| #### Running WASM tests with Cargo</br> |
There was a problem hiding this comment.
To me, the way this looks feels too much like "you can run tests with cargo without needing to setup things above".
There was a problem hiding this comment.
hmmm, I think this is mostly useful when you want to run a single or some specific wasm tests alone. While the other tries to run all tests
There was a problem hiding this comment.
My concern is this title can lead to confusions. Different title("example of running single test") would be more appropriate I guess.
There was a problem hiding this comment.
I understand, but keep in mind that the command can also be used to run the full test just like wasm-pack..hence why I used the title as it's not just limited to running single/some tests
There was a problem hiding this comment.
I know but I don't think anyone will think cargo can only do single test. Command explicitly contains flags that everyone can understand. I want to avoid the confusion of "there is an alternative way of running wasm tests that don't require prequests mentioned above".
There was a problem hiding this comment.
Can we run single test using wasm-pack? If we can, we should use wasm-pack for "example of running single test", and find better title for cargo one probably.
There was a problem hiding this comment.
yeah I understood that, thanks.
but personally, I'm not sure if wasm-pack can perform same action tho
add docs for running WASM tests with Cargo