fix(zcoin): resume previous sync if sync_params are not provided#1967
Merged
fix(zcoin): resume previous sync if sync_params are not provided#1967
Conversation
Signed-off-by: borngraced <samuelonoja970@gmail.com>
Signed-off-by: borngraced <samuelonoja970@gmail.com>
shamardy
reviewed
Sep 12, 2023
Collaborator
shamardy
left a comment
There was a problem hiding this comment.
First review iteration! I believe there are more room for improvements/refactors of the code to make it more readable, this will make it easy to review and detect any bugs similar to the one we faced here.
Signed-off-by: borngraced <samuelonoja970@gmail.com>
shamardy
approved these changes
Sep 13, 2023
Collaborator
|
@borngraced can you please provide the changes done in this PR so that it can be documented by @KomodoPlatform/qa? |
Author
|
@KomodoPlatform/qa , the only change in this PR is synchronization uses 2 days as sync starting point only when sync_params is not provided and no previously sync state. |
cipig
approved these changes
Sep 13, 2023
smk762
approved these changes
Sep 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.