Skip to content

fix(web3): try next web3 node on response error#1998

Merged
shamardy merged 2 commits intodevfrom
fix-evm-error-response
Oct 27, 2023
Merged

fix(web3): try next web3 node on response error#1998
shamardy merged 2 commits intodevfrom
fix-evm-error-response

Conversation

@shamardy
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!
I have one note and question.

Note:
Your changes are well structured and look good to me. I just noticed that we have redundant cloning in previously merged code part.
Unnecessary clones for serialized_request, we can remove it.

// here in non wasm target
let mut req = http::Request::new(serialized_request.clone().into_bytes());

// and here in `send_request` wasm impl
match send_request_once(serialized_request.clone(), &node.uri

Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shamardy shamardy merged commit 8276b7c into dev Oct 27, 2023
@shamardy shamardy deleted the fix-evm-error-response branch October 27, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants