Skip to content

FreshRSS 1.14.3#2451

Merged
Alkarex merged 60 commits intomasterfrom
dev
Jul 25, 2019
Merged

FreshRSS 1.14.3#2451
Alkarex merged 60 commits intomasterfrom
dev

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Jul 21, 2019

Hello,
Before some more substantial changes scheduled for 1.15.0, let's release a version 1.14.3 before the summer vacations 🏖️ with a number of small improvements and bug fixes. In particular, there is now a Docker image automatically built for ARM (e.g. Raspberry Pi) testable with freshrss/freshrss:dev-arm.

Thanks to the 12 contributors, especially newcomers @rosiel , @lx-s , @Sp3r4z , @Fake4d , @SuperSandro2000, and @rnc :-)

Full changelog:

  • Bug fixing
    • Fix wrong mark-as-read limit #2429
    • Fix API call for removing a category #2411
    • Fix user self-registration #2381
    • Make CGI Authorization configuration for API more compatible #2446
    • Fix refresh icon in Swage theme #2375
    • Fix message banner in Swage theme #2379
    • Docker: Add php-gmp for API support in Ubuntu 32-bit #2450
  • UI
    • New configuration page for each category #2369
    • Update shortcut configuration page #2405
    • CSS style for printing #2149
    • Do not hide multiple <br /> tags #2437
    • Updated to jQuery 3.4.1 (only for statistics page) #2424
  • Deployment
    • Docker: Add automatic health check #2438
    • Docker: Add a version for ARM architecture such as for Raspberry Pi #2436
    • Docker: Ubuntu image updated to 19.04 with PHP 7.2.19 and Apache 2.4.38 #2422
    • Docker: Alpine image updated to 3.10 with PHP 7.3.7 and Apache 2.4.39 #2238
  • Security
    • Allow @- as valid characters in usernames (i.e. allow most e-mails) #2391
  • I18n
  • Misc.
    • New parameter ?maxFeeds=10 to control the max number of feeds to refresh manually #2388
    • Default to SQLite during install #2443

Alkarex and others added 30 commits April 8, 2019 23:35
Before, the printed page didn't have any usable CSS.
Now, it uses the css files available in the application. It means that
custom CSS can be add to target printed page.

See #2149
Enhanced actualizeFeed with a maxFeeds-Parameter, so that a
user can control how many feeds he wants to refresh instead
of being force to choose between "10 or all".
Document all the parameters for "feed actualize".

the new parameter "maxfeeds" from Pull Request #2388 is already considered.
Typo in Param maxFeeds
Reeder-4 is new - Reeder-3 is the old version

BUT: 3 is free ;-)
And you have to pay for the new version.. So I dont know whether this should be linked here..
Before, there was extra white lines between search terms when displaying
the data. It was not an issue for the storage since they were discarded
during the save process. But it was confusing.
Now, extra white lines are stripped.
Configurable amount of feeds that gets refreshed.
Before, first and last entry shortcuts were located under the "no-modifier"
section. But they were actually working properly with the modifiers.
Now, they are located under the "modifier" section.

See #2405
* Add whole PHP modules Dockerfile link

* Add Dockerfile link to whole PHP modules list
* Allow email as username

Before, it was possible to register email as username on cli but not in the
interface. This was caused by a bug in the pattern which was not working as
expected. If your input was "user@example.com", the PHP verification was
catching only "user" and was acting like the whole thing was catched. But
on the interface, the catching was unsuccesful.
Now, the catching should be working properly.

I needed to add "$|^" in the pattern because without, I was catching either
the beginning of a string either the last char. This was introduced as a
workaround for IE/Edge pattern matching on April 27, 2017. See #1511 for
more information.

I tested it only on FF. Tests on other browsers wanted.

See #2391

* Relax and fix username check

Allow @ + -

* Remove + for now

#2407 (comment)
* Fix line return 

Better with HTML native `<br>` than with `\\`

* Fix line break

Replace `\\` by native HTML `<br>`
* Change category configuration

Before, we had a drop-down list to interract on categories. It was not
working the same way as feeds.
Now, categories and feeds behave in a similar manner. At the moment,
there is no change in features but it will allow to expand them.

See #2369

* Minor whitespace
Alkarex and others added 9 commits July 13, 2019 15:19
* Docker Hub readme

Try to use anothe readme.
And update info for
https://alpinelinux.org/posts/Alpine-3.10.1-released.html

* Test another variant

* /tmp/ did not work
* Change to fix issues 2251

This is a proposed change to fix issue #2251

* Remove comments
Move SQLite as first option in install instead of MySQL. Lower barrier
to entry.
* Add FreshRSS-Notify in Clients compatibles section

* Add FreshRSS-Notify in Compatible clients section

* Use language-neutral link

https://addons.mozilla.org/firefox/addon/freshrss-notify-webextension/
* Issue #2446 : Fix passing authentication headers. Use CGIPassAuth is version is high enough

* Issue #2446 : Remove CGIPassAuth due to potential issues with AllowOverride rights.

* Tabs
* Fix user self registration

Fix #2381

* CSRF for admin
And adjust slightly the HEALTHCHECK parameters for faster start in
Træfik
@Alkarex Alkarex added this to the 1.14.3 milestone Jul 21, 2019
@Alkarex
Copy link
Member Author

Alkarex commented Jul 22, 2019

By the way, if anybody has any idea about the following Docker Hub issues, please tell :-) :

  1. How to use this specific readme file https://github.com/FreshRSS/FreshRSS/blob/master/Docker/README.md on https://hub.docker.com/r/freshrss/freshrss . I have tried with a post_checkout hook but without success:

mv README.md ../

  1. When cross-compiling for ARM on Docker Hub, and while waiting for Docker Hub to support the --squash option, how to avoid having 2 copies of qemu-arm-static (we should have zero) in the final image layers?

RUN rm /usr/bin/qemu-* /var/www/FreshRSS/Docker/qemu-*

  1. When cross-compiling for ARM on Docker Hub, and while waiting for Docker Hub to support the --platform parameter, how to produce an ARM image with the proper metadata, i.e. arm and not amd64
sudo docker inspect --format='{{.Architecture}}' freshrss/freshrss:dev-arm
amd64

@SuperSandro2000
Copy link
Contributor

  1. Is the readme in the same dir as the dockerfile you build?

  2. I use balenas cross compile images but they have the qemu build in, too.
    And combining all RUNs would work but it would destroy caching.

  3. I don't know if docker cloud supports it but you can do it manually and puhs it to docker hub. I do this with my multi Arch manifest images. Let me know if you want to know the details.

@Alkarex
Copy link
Member Author

Alkarex commented Jul 22, 2019

@SuperSandro2000 Yes for 1, you can see https://github.com/FreshRSS/FreshRSS/tree/master/Docker/
Ok for the rest, and yes, I know how to manually push for multiple architectures, but it is nice to have everything automated.

@SuperSandro2000
Copy link
Contributor

  1. It might be that it needs to be lower cased after the first letter README not being parsed on build docker/hub-feedback#300 (comment)
  2. I do it like this: I create the manifest, tag them correctly and then push the manifest together with the other images into the repo. Then docker pull chooses the right image for your architecture. See https://github.com/SuperSandro2000/docker-images/blob/master/zeronet/push.sh#L29 and https://hub.docker.com/r/supersandro2000/zeronet/tags
  3. And this would be solved, too if you would switch to travis or circleci or some other CI that allows you to run commands outside the Dockerfile.

@Alkarex
Copy link
Member Author

Alkarex commented Jul 22, 2019

@SuperSandro2000 Yes, I also have some repositories where I push two versions and a manifest. On Docker Hub, it is also possible to run commands outside the Docker file https://docs.docker.com/docker-hub/builds/advanced/ (see the various hooks); I am just not sure which command :-)

* [CI] Run shellcheck and shfmt

Cf. #2436 (comment)

* rename

* no need for disable anymore

* also remove leftover indentation flags even if it makes no difference to syntax checking

* define colors and reset before exit for local use
@SuperSandro2000
Copy link
Contributor

I didn't know these hooks existed. Learning something new every day.

@SuperSandro2000
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.