Replace curl healthcheck with pure php, apply haodlint suggestions#2455
Replace curl healthcheck with pure php, apply haodlint suggestions#2455Alkarex merged 1 commit intoFreshRSS:devfrom SuperSandro2000:sandro-curl-hadolint
Conversation
|
Thanks 👍 |
|
It could be nice to add https://github.com/hadolint/hadolint as part of our automatic testing, e.g. in Travis or Docker builds. What do you think @Frenzie ? |
Sure, I wasn't aware of it. Seems generally useful. However, that |
|
I also noticed it :-) But it was just an example they used, I guess |
|
@SuperSandro2000 or @Frenzie , if one of you is motivated enough to add haodlint to our CI, that would be welcome :-) |
|
@SuperSandro2000 @Alkarex Maybe later today or tomorrow, not right now. |
|
@SuperSandro2000 wrote #2451 (comment)
That looks good at a first glance 👍 Would you mind sending a PR with that? |
|
Yeah, that looks basically perfect except we'll want something closer to |
|
Done in #2456 |
|
Cross-reference #2438 |
FreshRSS#2454 FreshRSS#2455 FreshRSS#2456 +hadolint remove PIP warning
Closes #2453
Adding
-o pipefailto the shell ensures that errors will fail pipechains and forward errors correctly.Apt is an end user tool and scripts are recommended to use
apt-get. See https://github.com/hadolint/hadolint/wiki/DL3027