Skip to content

Replace curl healthcheck with pure php, apply haodlint suggestions#2455

Merged
Alkarex merged 1 commit intoFreshRSS:devfrom
SuperSandro2000:sandro-curl-hadolint
Jul 22, 2019
Merged

Replace curl healthcheck with pure php, apply haodlint suggestions#2455
Alkarex merged 1 commit intoFreshRSS:devfrom
SuperSandro2000:sandro-curl-hadolint

Conversation

@SuperSandro2000
Copy link
Contributor

Closes #2453

Adding -o pipefail to the shell ensures that errors will fail pipechains and forward errors correctly.
Apt is an end user tool and scripts are recommended to use apt-get. See https://github.com/hadolint/hadolint/wiki/DL3027

@Alkarex Alkarex added this to the 1.14.3 milestone Jul 22, 2019
@Alkarex Alkarex merged commit 71270e4 into FreshRSS:dev Jul 22, 2019
@Alkarex
Copy link
Member

Alkarex commented Jul 22, 2019

Thanks 👍

@Alkarex
Copy link
Member

Alkarex commented Jul 22, 2019

It could be nice to add https://github.com/hadolint/hadolint as part of our automatic testing, e.g. in Travis or Docker builds. What do you think @Frenzie ?
P.S.: https://github.com/hadolint/hadolint/blob/master/docs/INTEGRATION.md

@Frenzie
Copy link
Member

Frenzie commented Jul 22, 2019

@Alkarex

It could be nice to add https://github.com/hadolint/hadolint as part of our automatic testing, e.g. in Travis or Docker builds.

Sure, I wasn't aware of it. Seems generally useful.

However, that curl=1.1.0 will break the script long before a change in the output from apt install would. :-)

@Alkarex
Copy link
Member

Alkarex commented Jul 22, 2019

I also noticed it :-) But it was just an example they used, I guess

@SuperSandro2000 SuperSandro2000 deleted the sandro-curl-hadolint branch July 22, 2019 14:13
@Alkarex
Copy link
Member

Alkarex commented Jul 22, 2019

@SuperSandro2000 or @Frenzie , if one of you is motivated enough to add haodlint to our CI, that would be welcome :-)

@Frenzie
Copy link
Member

Frenzie commented Jul 22, 2019

@SuperSandro2000 @Alkarex Maybe later today or tomorrow, not right now.

@Alkarex
Copy link
Member

Alkarex commented Jul 22, 2019

@SuperSandro2000 wrote #2451 (comment)

Btw I saw you wanted to add hadolint.
I would suggest this config https://github.com/SuperSandro2000/docker-images/blob/master/.hadolint.yaml of me and this install script of me https://github.com/SuperSandro2000/docker-images/blob/master/.travis.yml#L58 https://github.com/SuperSandro2000/docker-images/blob/master/.travis.yml#L61 .

That looks good at a first glance 👍 Would you mind sending a PR with that?

@Frenzie
Copy link
Member

Frenzie commented Jul 22, 2019

Yeah, that looks basically perfect except we'll want something closer to git ls-files --exclude='*Dockerfile*' --ignored or you'll exclude Docker/Dockerfile-Alpine and Docker/Dockerfile-QEMU-ARM.

@SuperSandro2000
Copy link
Contributor Author

Done in #2456

@Alkarex
Copy link
Member

Alkarex commented Jul 23, 2019

Cross-reference #2438

Alkarex added a commit that referenced this pull request Jul 23, 2019
#2454
#2455
#2456
+hadolint remove PIP warning
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants