Skip to content

Docker healthcheck+ labels#2438

Merged
Alkarex merged 4 commits intoFreshRSS:devfrom
Alkarex:Docker-labels
Jul 7, 2019
Merged

Docker healthcheck+ labels#2438
Alkarex merged 4 commits intoFreshRSS:devfrom
Alkarex:Docker-labels

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Jul 7, 2019 •
edited
Loading

And try to fix the platform metadata for ARM, and add health check.
Follow-up of #2436

Alkarex added 2 commits July 7, 2019 16:24
@Alkarex
Add Docker labels
5a54aa0 
And try to fix the platform metadata for ARM, and add health check
@Alkarex
Execution rights
7ea1847
@Alkarex Alkarex added this to the 1.15.0 milestone Jul 7, 2019
@Alkarex
Copy link
Member Author

Alkarex commented Jul 7, 2019 •
edited
Loading

I cannot find a way to change the architecture metadata information (visible from docker inspect). Same problem than jacobalberty/unifi-docker#84
The --platform build parameter could do the job but is apparently not yet available on Docker Hub https://docs.docker.com/engine/reference/commandline/build/
And docker manifest annotate is also experimental so far:
https://docs.docker.com/engine/reference/commandline/manifest_annotate/

Alkarex added 2 commits July 7, 2019 17:16
@Alkarex
Remove experimental features not supported by Docker Hub
d3c8932 
"--squash" is only supported on a Docker daemon with experimental
features enabled. build hook failed! (1)
@Alkarex
Fix paths
a76abca
@Alkarex
Copy link
Member Author

Alkarex commented Jul 7, 2019

Effect of HEALTHCHECK :

$ sudo docker ps -a
CONTAINER ID        IMAGE                              COMMAND                  CREATED              STATUS                        PORTS                          NAMES
6dc8081fb84e        freshrss/freshrss:dev-alpine-arm   "./Docker/entrypoint…"   About a minute ago   Up About a minute (healthy)   80/tcp                         freshrss

@Alkarex
Copy link
Member Author

Alkarex commented Jul 7, 2019

sudo docker inspect 0b6372cc52fe

[
    {
        ...
        "ContainerConfig": {
            ...
            "Healthcheck": {
                "Test": [
                    "CMD-SHELL",
                    "curl -fsS 'http://localhost/i/' | grep -q 'jsonVars' || exit 1"
                ],
                "Interval": 67000000000,
                "Timeout": 5000000000,
                "StartPeriod": 8000000000,
                "Retries": 3
            },
            ...
            "Labels": {
                "org.opencontainers.image.authors": "Alkarex",
                "org.opencontainers.image.description": "A self-hosted RSS feed aggregator",
                "org.opencontainers.image.documentation": "https://freshrss.github.io/FreshRSS/",
                "org.opencontainers.image.licenses": "AGPL-3.0",
                "org.opencontainers.image.revision": ".",
                "org.opencontainers.image.source": "https://github.com/FreshRSS/FreshRSS",
                "org.opencontainers.image.title": "FreshRSS",
                "org.opencontainers.image.url": "https://freshrss.org/",
                "org.opencontainers.image.vendor": "FreshRSS",
                "org.opencontainers.image.version": "1.14.3-dev"
            }
        },
        ...
  }
]

@Alkarex Alkarex changed the title Docker labels Docker healthcheck+ labels Jul 7, 2019
@Alkarex Alkarex merged commit 8c2cf1b into FreshRSS:dev Jul 7, 2019
@Alkarex Alkarex deleted the Docker-labels branch July 7, 2019 18:07
@Alkarex Alkarex modified the milestones: 1.15.0, 1.14.3 Jul 13, 2019
This was referenced Jul 21, 2019
Merged
Merged
@Alkarex Alkarex added the Docker 🐋 Everything related to Docker label Jan 22, 2021
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
@Alkarex @mdemoss
Docker healthcheck+ labels (FreshRSS#2438)
3ebcff9 
* Add Docker labels

And try to fix the platform metadata for ARM, and add health check

* Execution rights

* Remove experimental features not supported by Docker Hub

"--squash" is only supported on a Docker daemon with experimental
features enabled. build hook failed! (1)

* Fix paths
XtremeOwnageDotCom added a commit to XtremeOwnageDotCom/FreshRSS that referenced this pull request Oct 26, 2023
@XtremeOwnageDotCom
Added livenessProbe from details in FreshRSS#2438
b2bb214
@Pugglewuggle Pugglewuggle mentioned this pull request Feb 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Docker 🐋 Everything related to Docker

Projects

None yet

Milestone

1.14.3

Development

Successfully merging this pull request may close these issues.

1 participant

@Alkarex