Merged
Conversation
Alkarex
reviewed
Jul 22, 2019
Alkarex
reviewed
Jul 22, 2019
Alkarex
reviewed
Jul 22, 2019
Alkarex
reviewed
Jul 23, 2019
|
|
||
| for shellscript in "${shellscript_locations[@]}"; do | ||
| echo -e "${ANSI_GREEN}Running shellcheck on ${shellscript}" | ||
| shellcheck "${shellscript}" || SHELLSCRIPT_ERROR=1 |
Member
There was a problem hiding this comment.
It could be good to add a note in about this test in https://github.com/FreshRSS/FreshRSS/blob/dev/tests/README.md , and also that it requires installing shellcheck and shfmt
Frenzie
added a commit
to Frenzie/FreshRSS
that referenced
this pull request
Jul 23, 2019
Alkarex
pushed a commit
that referenced
this pull request
Jul 24, 2019
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* [CI] Run shellcheck and shfmt Cf. FreshRSS#2436 (comment) * rename * no need for disable anymore * also remove leftover indentation flags even if it makes no difference to syntax checking * define colors and reset before exit for local use
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
FreshRSS#2454 FreshRSS#2455 FreshRSS#2456 +hadolint remove PIP warning
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf. #2436 (comment)
I wrote this script years ago, long before these tools became a standard part of Travis. ShellCheck is a good idea on any script; shfmt has fewer obvious benefits given how few we have and how small they are but I'd say why not?