[CI] Run hadolint#2456
Conversation
|
Could you please also fix the issues it points out? Regarding placement, if you test for something like |
|
I changed it to only run in one job cause everything else is kinda pointless. The Dockerfiles don't change with the php version. About fixing that issue: It would require us to move the CMD to it's own file cause I don't know a way to use Or we just ignore it for now. How do we wan't to handle the GitHub Token? I don't really want to hardcode one. |
Yes, in that case it's probably clearest to stick a |
|
@SuperSandro2000 I added a GITHUB_TOKEN variable to Travis with no scopes. Is that correct? |
Yes, as we only use it for the API we don't need any special permission. Thanks. |
|
This should be done. |
|
Awesome, thanks! |
FreshRSS#2454 FreshRSS#2455 FreshRSS#2456 +hadolint remove PIP warning
As requested here
I don't like that it needs
jqbut I am to lazy to write that json select with bash. It is also probably more robust and easier to understand this way.This would also require to add a GItHub Token under
$GITHUB_TOKENin Travis. If we leave this out the CI periodically fails cause GitHub API gets rate limited quite easily.The URL would then change to:
https://api.github.com/repos/hadolint/hadolint/releases/latest?access_token="$GITHUB_TOKEN"I am a bit unsure where to put it or if it should be blocking for the other CI jobs. Let me know if I should move it to another section.