Conversation
Before, it was possible to register email as username on cli but not in the interface. This was caused by a bug in the pattern which was not working as expected. If your input was "user@example.com", the PHP verification was catching only "user" and was acting like the whole thing was catched. But on the interface, the catching was unsuccesful. Now, the catching should be working properly. I needed to add "$|^" in the pattern because without, I was catching either the beginning of a string either the last char. This was introduced as a workaround for IE/Edge pattern matching on April 27, 2017. See FreshRSS#1511 for more information. I tested it only on FF. Tests on other browsers wanted. See FreshRSS#2391
|
We also need to double-check with the 3 databases: SQLite, MySQL, PostgreSQL |
|
I was thinking about it and we should even write the pattern completely. Meaning we should provide |
|
Is there a specific reason to disallow a username like On the subject of e-mails itself, both of the suggested patterns disallow common e-mails with a is valid. This might seem like a minor semantic point (allow some e-mails vs. allow e-mails) but |
|
Keep in mind that the user has a folder on disk. There might be a limitation regarding what we can write on the file system. |
|
Only But anyway, I'm not necessarily arguing it should all be allowed, although I would like to see + and -. Just that it shouldn't be presented to the user as e-mails can be used as usernames. |
|
Agreed. I'll modify the code to allow |
Allow @ + -
|
I have just suggested a new pattern, allowing
The We should double-check with the 3 database types, and check whether the username appears anywhere else potentially problematic. In any case, we should not allow |
|
Arg, the |
|
I am (gladly) surprised to see that |
|
Seems to work fine in SQLite, MySQL, PostgreSQL. |
|
Let's add only |
|
I tried the dev branch and created a user with e-mail as login. However i cant login. I get
The user directory is created as "usermydomainde". I can't check the database now, but i think, its the same there. Please take also in account that there can be several ASCII signs in the password, like Update: The above is the result of creating the first time user during installation. If i create a user with e-mail after that, it seems to work. |
|
@Offerel Could you please open a new issue for that? It seems to be install-specific |
* Allow email as username Before, it was possible to register email as username on cli but not in the interface. This was caused by a bug in the pattern which was not working as expected. If your input was "user@example.com", the PHP verification was catching only "user" and was acting like the whole thing was catched. But on the interface, the catching was unsuccesful. Now, the catching should be working properly. I needed to add "$|^" in the pattern because without, I was catching either the beginning of a string either the last char. This was introduced as a workaround for IE/Edge pattern matching on April 27, 2017. See FreshRSS#1511 for more information. I tested it only on FF. Tests on other browsers wanted. See FreshRSS#2391 * Relax and fix username check Allow @ + - * Remove + for now FreshRSS#2407 (comment)
Before, it was possible to register email as username on cli but not in the
interface. This was caused by a bug in the pattern which was not working as
expected. If your input was "user@example.com", the PHP verification was
catching only "user" and was acting like the whole thing was catched. But
on the interface, the catching was unsuccesful.
Now, the catching should be working properly.
I needed to add "$|^" in the pattern because without, I was catching either
the beginning of a string either the last char. This was introduced as a
workaround for IE/Edge pattern matching on April 27, 2017. See #1511 for
more information.
I tested it only on FF. Tests on other browsers wanted.
See #2391