Skip to content

Fix rel issue - move noopener and noreferrer tags into existing rel tag#9992

Merged
abidhahmed merged 1 commit intoAutomattic:masterfrom
adamsilverstein:patch-1
Aug 8, 2018
Merged

Fix rel issue - move noopener and noreferrer tags into existing rel tag#9992
abidhahmed merged 1 commit intoAutomattic:masterfrom
adamsilverstein:patch-1

Conversation

@adamsilverstein
Copy link
Copy Markdown
Contributor

@adamsilverstein adamsilverstein commented Aug 7, 2018 •
edited
Loading

Summary

Fixes an issue introduced in #9644 where Google would crawl sharing links, because a duplicate rel tag meant the first rel="nofollow" was ignored. After this fix, the additional rel tags are combined with the first.

Changes

  • move noopener and noreferrer tags into existing rel tag

Testing instructions

  • Install Jetpack and enable sharing.
  • Inspect the sharing links, there should only be one rel tag.

[Status] Needs Review

See #9644 (comment)

@adamsilverstein
Fix rel issue - move noopener and noreferrer tags into existing rel tag
2d28f5f 
Fixes an issue introduced in Automattic#9644 where Google would crawl sharing links, because a duplicate rel tag meant the first rel="nofollow" was ignored. After this fix, the additional rel tags are combined with the first.


* Pre
@adamsilverstein adamsilverstein requested a review from a team as a code owner August 7, 2018 16:27
@abidhahmed abidhahmed added this to the 6.5 milestone Aug 7, 2018
@abidhahmed abidhahmed added the Bug When a feature is broken and / or not performing as intended label Aug 7, 2018
abidhahmed
abidhahmed approved these changes Aug 8, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@abidhahmed abidhahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abidhahmed abidhahmed removed the [Status] Needs Review This PR is ready for review. label Aug 8, 2018
@abidhahmed
Copy link
Copy Markdown
Contributor

abidhahmed commented Aug 8, 2018

Thanks for your contribution! I can confirm these changes work as intended, so I'll go ahead and merge these in. You can expect these to land with 6.5.

I'll also scan the linked PR for similar changes and ensure these duplicate rel tags are removed in a different PR down the line.

@abidhahmed abidhahmed merged commit 3325f44 into Automattic:master Aug 8, 2018
This was referenced Aug 8, 2018
Closed
Closed
@abidhahmed abidhahmed added [Feature] Sharing Post sharing, sharing buttons and removed General labels Aug 28, 2018
oskosk pushed a commit that referenced this pull request Aug 28, 2018
@abidhahmed @oskosk
[skip-ci] Added changelogs
7c86fd2 
#9958 
#9983 
#9992 
#10002 
#10004
#10010
#10011
#10017
#10031
#10037
#10039
#10040
#10051
oskosk pushed a commit that referenced this pull request Aug 28, 2018
@abidhahmed @oskosk
[skip-ci] Add test instructions
1942746 
#9958
#9983
#9992 
#10002
#10004
#10010
#10017
#10031
#10037
#10039
#10040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abidhahmed abidhahmed abidhahmed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Type] Janitorial

Projects

None yet

Milestone

6.5

Development

Successfully merging this pull request may close these issues.

3 participants

@adamsilverstein @abidhahmed @matticbot