Remove the old UI in `/tools.php` for site verification by Tug · Pull Request #10039 · Automattic/jetpack

Tug · 2018-08-21T14:20:18Z

Changes proposed in this Pull Request:

This PR removes the "Site Verification Services" card in Tools as it's a duplicate of the site verification card in /wp-admin/admin.php?page=jetpack#/traffic. Morevoer it seems this former version was not maintained as well as the latter, as it only accepts alpha codes.

Testing instructions:

Apply this patch
Connect to wp-admin on a jetpack site
Go to Tools ( /wp-admin/tools.php ) and notice the screen to verify your site on search engines (titled Website Verification Services (?)) has been replaced by a placeholder.

Old UI:

New UI:

Go to Jetpack > Settings > Traffic, scroll down and notice the Website Verification Services card is still available and works as expected

Proposed changelog entry:

Remove the outdated "Site Verification Services" card in Tools
Removed jetpack_enable_site_verification filter. We recommend filtering access to verification tools using jetpack_get_available_modules (docs)

kraftbj · 2018-08-21T15:45:42Z

modules/verification-tools/blog-verification-tools.php

-	echo $ver_output;
-	}
-}
-add_action( 'wp_head', 'jetpack_verification_print_meta', 1 );


This looks like it would be taking out what is actually printing the verification codes into the site. Is this intentionally being removed?

Whoops, we do still need that 😬

kraftbj · 2018-08-21T15:47:06Z

modules/verification-tools/blog-verification-tools.php

-	 *
-	 * @param bool true Should the Site Verification tools be added to the Tools menu.
-	 */
-	if ( ! apply_filters( 'jetpack_enable_site_verification', true ) )


We should note in the changelog that this filter is being deprecated.

@cbauerman you can do one better and add it to this list of deprecated hooks

https://github.com/Automattic/jetpack/blob/master/class.jetpack.php#L6597

jetpackbot · 2018-08-21T17:25:58Z

	Warnings
⚠️	The PR is missing at least one [Status] label. Suggestions: `[Status] In Progress`, `[Status] Needs Review`

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

cbauerman

These changes look good to me and work as described!

Requested changes made; did not test revised PR.

gravityrail

This looks good to me. Do we want to replace it with a placeholder that links to the Jetpack Settings area, in case people come here looking for it?

gravityrail · 2018-08-23T17:43:30Z

Added placeholder card and screenshot.

dereksmart · 2018-08-23T17:50:56Z

modules/verification-tools/blog-verification-tools.php

+		<div class="jp-verification-tools card">
+			<h3 class="title"><?php _e( 'Website Verification Services' , 'jetpack' ) ?>&nbsp;<a href="http://support.wordpress.com/webmaster-tools/" rel="noopener noreferrer" target="_blank">(?)</a></h3>
+			<p>
+				<?php _e( sprintf( 'You can verify your site using the <a href="%s">"Site verification" tool in Jetpack Settings</a>.', esc_url( admin_url( 'admin.php?page=jetpack#/traffic' ) ) ) ); ?>


Missing text domain

Whoops! Fixed

joanrho

@gravityrail LGTM and works as expected, but first please change the (?) link from https://en.support.wordpress.com/webmaster-tools/ to https://jetpack.com/support/site-verification-tools/ instead.

gravityrail · 2018-08-27T16:50:20Z

Thanks for the feedback @joanrho. This is is now ready to merge.

#9958 #9983 #9992 #10002 #10004 #10010 #10011 #10017 #10031 #10037 #10039 #10040 #10051

#9958 #9983 #9992 #10002 #10004 #10010 #10017 #10031 #10037 #10039 #10040

Fixes #21823 The tools have lived in the Jetpack dashboard for more than 3 years, since #10039. Let's retire that redirection now.

Remove the old UI in /tools.php for site verification

983ed17

Tug self-assigned this Aug 21, 2018

Tug requested review from cbauerman and gravityrail August 21, 2018 14:20

Tug requested a review from a team as a code owner August 21, 2018 14:20

Tug added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Aug 21, 2018

Automattic deleted a comment from jetpackbot Aug 21, 2018

kraftbj previously requested changes Aug 21, 2018

View reviewed changes

kraftbj added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Aug 21, 2018

Replace verification_print_meta method

a0e3ae2

Rearrange file to simplify diff

63d2b97

cbauerman approved these changes Aug 21, 2018

View reviewed changes

cbauerman added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 21, 2018

cbauerman added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 21, 2018

cbauerman added this to the 6.5 milestone Aug 22, 2018

gravityrail approved these changes Aug 23, 2018

View reviewed changes

Add depricated hook to official list

a70cd09

ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 23, 2018

gravityrail added the [Status] Needs Design Review Design has been added. Needs a review! label Aug 23, 2018

Add placeholder and link for legacy site verify tools

794cad1

dereksmart reviewed Aug 23, 2018

View reviewed changes

gravityrail added 2 commits August 23, 2018 10:55

Add text domain

50a3d03

Fix inside-out i18n args

0fbbb4a

joanrho self-requested a review August 23, 2018 22:48

joanrho approved these changes Aug 23, 2018

View reviewed changes

joanrho removed the [Status] Needs Design Review Design has been added. Needs a review! label Aug 23, 2018

Change URL in placeholder card

b2da70a

gravityrail added the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 27, 2018

abidhahmed merged commit d9f45d9 into master Aug 28, 2018

matticbot added the [Status] Needs Changelog label Aug 28, 2018

ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 28, 2018

abidhahmed deleted the remove/site-verification-in-tools branch August 28, 2018 07:44

abidhahmed added the Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Aug 28, 2018

abidhahmed added [Status] Has Changelog and removed [Status] Needs Changelog labels Aug 28, 2018

oskosk pushed a commit that referenced this pull request Aug 28, 2018

[skip-ci] Added changelogs

7c86fd2

#9958 #9983 #9992 #10002 #10004 #10010 #10011 #10017 #10031 #10037 #10039 #10040 #10051

oskosk pushed a commit that referenced this pull request Aug 28, 2018

[skip-ci] Add test instructions

1942746

#9958 #9983 #9992 #10002 #10004 #10010 #10017 #10031 #10037 #10039 #10040

jeherve mentioned this pull request Nov 22, 2021

Verification tools: remove old Tools interface #21846

Merged

jeherve added a commit that referenced this pull request Nov 22, 2021

Verification tools: remove old Tools interface

fbc65bc

Fixes #21823 The tools have lived in the Jetpack dashboard for more than 3 years, since #10039. Let's retire that redirection now.

Conversation

Tug commented Aug 21, 2018 • edited by gravityrail Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry:

Uh oh!

kraftbj Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

cbauerman Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

kraftbj Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

cbauerman Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

dereksmart Aug 23, 2018

Choose a reason for hiding this comment

Uh oh!

jetpackbot commented Aug 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbauerman left a comment

Choose a reason for hiding this comment

Uh oh!

gravityrail left a comment

Choose a reason for hiding this comment

Uh oh!

gravityrail commented Aug 23, 2018

Uh oh!

dereksmart Aug 23, 2018

Choose a reason for hiding this comment

Uh oh!

gravityrail Aug 23, 2018

Choose a reason for hiding this comment

Uh oh!

joanrho left a comment

Choose a reason for hiding this comment

Uh oh!

gravityrail commented Aug 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Tug commented Aug 21, 2018 •

edited by gravityrail

Loading

jetpackbot commented Aug 21, 2018 •

edited

Loading