Put the checkboxes to subscribe to comments above post comment button.#9983
Merged
abidhahmed merged 1 commit intoAutomattic:masterfrom Aug 24, 2018
Conversation
Collaborator
Generated by 🚫 dangerJS |
Contributor
|
Awaiting design review before proceeding further, thanks for your contribution! |
keoshi
approved these changes
Aug 23, 2018
Contributor
keoshi
left a comment
There was a problem hiding this comment.
Looks good — thanks for your contribution, Pattie!
Member
|
Definitely a great idea. Thanks @pattiereaves |
jeherve
added a commit
that referenced
this pull request
Jan 16, 2019
In #9983, we changed the way the subscription fields were hooked into the comment form. The comment_form_after_fields action we started using is not triggered for logged in users. comment_form_submit_button seems to be the only better filter right now. I also added some CSS so the fields are never too close of the submit button.
jeherve
added a commit
that referenced
this pull request
Jan 25, 2019
In #9983, we changed the way the subscription fields were hooked into the comment form. The comment_form_after_fields action we started using is not triggered for logged in users. comment_form_submit_button seems to be the only better filter right now. I also added some CSS so the fields are never too close of the submit button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes:
Moves the subscription checkboxes from after the submit comment button to before the submit button.