Skip to content

Twitter Timeline widget: Checking 'type' is an index of $instance#9958

Merged
abidhahmed merged 1 commit intoAutomattic:masterfrom
yelly:master
Aug 1, 2018
Merged

Twitter Timeline widget: Checking 'type' is an index of $instance#9958
abidhahmed merged 1 commit intoAutomattic:masterfrom
yelly:master

Conversation

@yelly
Copy link
Copy Markdown
Contributor

@yelly yelly commented Jul 27, 2018

Prevents log lines being written. Fixes #9957.

@yelly
Checking 'type' is an index of $instance
771c01c 
Prevents log lines being written. Fixes #9957.
@yelly yelly requested a review from a team as a code owner July 27, 2018 13:34
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Jul 27, 2018

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️

"Testing instructions" are missing for this PR. Please add some

Generated by 🚫 dangerJS

@abidhahmed abidhahmed added this to the 6.5 milestone Jul 31, 2018
@abidhahmed abidhahmed requested a review from Copons July 31, 2018 11:34
@abidhahmed abidhahmed added the [Status] Needs Review This PR is ready for review. label Jul 31, 2018
Copons
Copons approved these changes Jul 31, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been a while since I've worked on this, and I can't really reproduce why $instance['type'] might be undefined.
Though, the change looks sensible enough to me, and it doesn't cause any regressions.

@abidhahmed abidhahmed merged commit 106b3e8 into Automattic:master Aug 1, 2018
@abidhahmed abidhahmed removed the [Status] Needs Review This PR is ready for review. label Aug 1, 2018
@yelly
Copy link
Copy Markdown
Contributor Author

yelly commented Aug 3, 2018

@Copons I couldn't really figure out why I was getting an undefined $instance['type'] either, but it sure was happening a lot. Probably some more research would have found the answer, but it's probably not really worth it.

oskosk pushed a commit that referenced this pull request Aug 28, 2018
@abidhahmed @oskosk
[skip-ci] Added changelogs
7c86fd2 
#9958 
#9983 
#9992 
#10002 
#10004
#10010
#10011
#10017
#10031
#10037
#10039
#10040
#10051
oskosk pushed a commit that referenced this pull request Aug 28, 2018
@abidhahmed @oskosk
[skip-ci] Add test instructions
1942746 
#9958
#9983
#9992 
#10002
#10004
#10010
#10017
#10031
#10037
#10039
#10040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Copons Copons Copons approved these changes

Assignees

No one assigned

Labels

[Feature] Extra Sidebar Widgets

Projects

None yet

Milestone

6.5

Development

Successfully merging this pull request may close these issues.

5 participants

@yelly @jetpackbot @Copons @abidhahmed @matticbot