Added rel="noopener noreferrer" to links with target="_blank" (P4: modules/)#9644
Merged
oskosk merged 1 commit intoAutomattic:masterfrom Jun 8, 2018
Merged
Added rel="noopener noreferrer" to links with target="_blank" (P4: modules/)#9644oskosk merged 1 commit intoAutomattic:masterfrom
oskosk merged 1 commit intoAutomattic:masterfrom
Conversation
brbrr
approved these changes
Jun 7, 2018
Contributor
brbrr
left a comment
There was a problem hiding this comment.
LGTM! Chrome DevTools Best Practices audit score is increased
Contributor
|
This PR causes a duplicate rel tag in links, which is not valid HTML. In our case its causing Google to follow the links and index them, the first "nofollow" rel attribute is ignored - the second one overwrites it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8128