SSO: do not display JITM when not in wp-admin#14622
Merged
Conversation
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: March 3, 2020. |
gwwar
reviewed
Feb 11, 2020
zinigor
previously approved these changes
Feb 12, 2020
Contributor
zinigor
left a comment
There was a problem hiding this comment.
The change looks good to me, with one minor comment. If you decide it's fine to go like this, let's go like this.
kraftbj
approved these changes
Feb 13, 2020
jeherve
added a commit
that referenced
this pull request
Feb 25, 2020
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14547
Changes proposed in this Pull Request:
This PR introduces a change to the filter that can be used to customize the list of JITMs returned by a site for a specific query. We now pass the message path to that filter, so folks customizing the list of messages can choose to only do so on specific pages, for example.
We then use that new parameter to ensure that the custom JITM currently displayed the first time you log in to your site using SSO only appears when you access the main dashboard, where the message should be displayed.
Testing instructions:
- Visit WordPress.com/stats/day/siteslug - You should not see a JITM telling you more about the SSO feature. - Go back to wp-admin and log out. - Log back in using SSO. - You should see the JITM then.Proposed changelog entry for your changes: