Use vanilla JS instead of jQuery for the Cookies & Consents widget#14753
Merged
dereksmart merged 1 commit intomasterfrom Feb 24, 2020
Merged
Use vanilla JS instead of jQuery for the Cookies & Consents widget#14753dereksmart merged 1 commit intomasterfrom
dereksmart merged 1 commit intomasterfrom
Conversation
Remove 'jquery' as a dependency, and use vanilla JS.
Collaborator
This is an automated check which relies on |
kraftbj
approved these changes
Feb 24, 2020
Contributor
|
Reviewed in Chrome/Firefox. |
jeherve
added a commit
that referenced
this pull request
Feb 25, 2020
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
This isn't a new feature, it only modifies an existing feature.
Testing instructions:
In the Customizer, add a Cookies & Consents Banner widget to a sidebar
Exit the Customizer
Expected: the widget appears at the bottom
Expected: clicking 'Close and accept' dismisses it
Delete the
eucookielawcookie from the browserIn the Customizer, change some of the widget options. Like 'after the user scrolls the page.'
Ensure the widget works as expected
Proposed changelog entry for your changes: