Skip to content

Debugger: Pass the object to filter to allow easier addition of tests.#14736

Merged
kraftbj merged 1 commit intomasterfrom
add/this-to-hook
Feb 19, 2020
Merged

Debugger: Pass the object to filter to allow easier addition of tests.#14736
kraftbj merged 1 commit intomasterfrom
add/this-to-hook

Conversation

@kraftbj
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj commented Feb 19, 2020

Enables an easier time to add tests by doing

add_action( 'jetpack_connection_tests_loaded', 'example', 10, 2);

function example( $obj ) {
$obj->add_test(...);
}

Changes proposed in this Pull Request:

  • Passes $this to filters.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • n/a

Testing instructions:

Proposed changelog entry for your changes:

  • Debugger: Improve ability to add additional tests.

@kraftbj kraftbj added Enhancement Changes to an existing feature — removing, adding, or changing parts of it General labels Feb 19, 2020
@kraftbj kraftbj added this to the 8.3 milestone Feb 19, 2020
@kraftbj kraftbj requested review from a team and dereksmart February 19, 2020 20:09
@kraftbj kraftbj self-assigned this Feb 19, 2020
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Feb 19, 2020

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against e302e17

dereksmart
dereksmart approved these changes Feb 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works wonders

@kraftbj kraftbj merged commit b97ae10 into master Feb 19, 2020
@kraftbj kraftbj deleted the add/this-to-hook branch February 19, 2020 20:15
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14736
f69010d
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

@kraftbj kraftbj

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it General

Projects

None yet

Milestone

8.3

Development

Successfully merging this pull request may close these issues.

5 participants

@kraftbj @jetpackbot @dereksmart @jeherve @matticbot