Skip to content

Stats: hide smiley on post embeds as well#14494

Merged
jeherve merged 1 commit intomasterfrom
add/stats-embeds-hide-smiley
Feb 12, 2020
Merged

Stats: hide smiley on post embeds as well#14494
jeherve merged 1 commit intomasterfrom
add/stats-embeds-hide-smiley

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Jan 28, 2020

Fixes #14483

Changes proposed in this Pull Request:

In this case, we want to hook the CSS into the embed post template as well.

Testing instructions:

  • Start from a site using Stats. Verify that when logged out, you can see the tracking pixel in your browser dev tools at the bottom of the page.
  • Create a new post where you'll paste a link to another one of your posts inside a separate block; that post will be transformed into an embed.
  • Publish your post and access it in an incognito window.
  • Make sure no smiley face appears below the post embed.

Proposed changelog entry for your changes:

  • Stats: hide Stats smiley in post embeds

@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Status] Needs Review This PR is ready for review. [Pri] Low labels Jan 28, 2020
@jeherve jeherve added this to the 8.3 milestone Jan 28, 2020
@jeherve jeherve requested a review from a team January 28, 2020 08:47
@jeherve jeherve self-assigned this Jan 28, 2020
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Jan 28, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against 6d0e075

kraftbj
kraftbj approved these changes Feb 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. This worked for me as expected. If a theme doesn't include the hook, it wouldn't work, but I think that's akin to a theme not including wp_head: doing_it_wrong() on the theme's part.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 11, 2020
@jeherve jeherve merged commit c4a400e into master Feb 12, 2020
@jeherve jeherve deleted the add/stats-embeds-hide-smiley branch February 12, 2020 09:21
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 12, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14494
7eb14f2
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] Low

Projects

None yet

Milestone

8.3

Development

Successfully merging this pull request may close these issues.

On first view only smiley face shows although "hide the stats smiley face" is checked

4 participants

@jeherve @jetpackbot @kraftbj @matticbot