-
Notifications
You must be signed in to change notification settings - Fork 869
SSO JITM appears in Calypso Sidebar #14547
Copy link
Copy link
Closed
Labels
BugWhen a feature is broken and / or not performing as intendedWhen a feature is broken and / or not performing as intended[Feature] JITMJust In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar.Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar.
Milestone
Description
It looks like an SSO JITM is showing up in the sidebar, probably unintentionally. This was originally found and reported by @rickybanister
I believe this one is registered at
Line 1113 in e17a5c6
| private function prepare_sso_first_login_jitm() { |
But appears in two API responses on the calypso:stats-day:admin-notices and calypso:stats:sidebar_notice. For the amount of content here the API should not be returning this.
We do have an A/B test running for sidebar banners, but this is unrelated since I see the same behavior in Calypso master at 9820c2fa70292fda1db438deca943ce1b29f0faa before the PR was merged.
@Automattic/manage is happy to help review any PRs if folks have a fix.
To Reproduce This:
- Create a test site (this branch makes it easier for the SSO JITM to display), https://jurassic.ninja/create/?jetpack-beta&branch=try/sso-jitm
- Setup Jetpack and Connect to WordPress.com
- Turn on the following setting in Jetpack Settings:
- Visit WordPress.com/stats/day/siteslug
Expected: Banner appears in Stats
Actual: Banner appears in Stats and in Sidebar
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BugWhen a feature is broken and / or not performing as intendedWhen a feature is broken and / or not performing as intended[Feature] JITMJust In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar.Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar.



