Skip to content

SSO JITM appears in Calypso Sidebar #14547

@gwwar

Description

@gwwar

It looks like an SSO JITM is showing up in the sidebar, probably unintentionally. This was originally found and reported by @rickybanister

I believe this one is registered at

private function prepare_sso_first_login_jitm() {

Screen Shot 2020-01-31 at 2 16 51 PM

But appears in two API responses on the calypso:stats-day:admin-notices and calypso:stats:sidebar_notice. For the amount of content here the API should not be returning this.

Screen Shot 2020-01-31 at 2 18 31 PM

Screen Shot 2020-01-31 at 2 17 26 PM

We do have an A/B test running for sidebar banners, but this is unrelated since I see the same behavior in Calypso master at 9820c2fa70292fda1db438deca943ce1b29f0faa before the PR was merged.

@Automattic/manage is happy to help review any PRs if folks have a fix.

To Reproduce This:

Screen Shot 2020-01-31 at 1 43 35 PM

  • Visit WordPress.com/stats/day/siteslug

Expected: Banner appears in Stats
Actual: Banner appears in Stats and in Sidebar

Metadata

Metadata

Assignees

Labels

BugWhen a feature is broken and / or not performing as intended[Feature] JITMJust In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions