fix(svelte): share `<script module>`/`<script>` scope for unused-binding rules by Mokto · Pull Request #10606 · biomejs/biome

Mokto · 2026-06-11T04:02:49Z

Depends on #10473 — this PR should not be merged until that one lands. Once it does, the diff here will reduce to the single commit below.

Summary

A Svelte component's <script module> and <script> compile to one module and share a top-level scope, but Biome analyzes each block as an isolated embedded snippet. A binding (import, function, or variable) declared in one block and used only in the other was therefore reported as unused by noUnusedImports, noUnusedVariables, and useImportType:

<script module lang="ts">
  // declared here, not exported
  function formatId(id: number) { return `row-${id}`; }
</script>

<script lang="ts">
  const id = formatId(1); // used here -> formatId was falsely flagged as unused
</script>

Fix: when collecting embedded value/type references, the workspace now also visits Svelte source <script> snippets (not just template snippets), so a name referenced in the sibling block counts as used. Gated to Svelte, where the two blocks genuinely share a module scope; Vue and Astro are unchanged.

This PR was written primarily by Claude Code.

Test Plan

New fixtures under noUnusedVariables and noUnusedImports:

valid-svelte-cross-script-references.svelte — a module-declared function/const used only in the instance script.
valid-svelte-cross-script-imports.svelte — an import in each block used only by the other (both directions).
invalid-svelte-unused-module-binding.svelte — a module binding referenced in neither block is still flagged (no over-suppression).

All existing Svelte/Vue/Astro analyzer specs pass.

Docs

N/A

changeset-bot · 2026-06-11T04:02:54Z

🦋 Changeset detected

Latest commit: 5eae888

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-06-11T04:03:01Z

⚠️ Mixed activity

Activity patterns show a mix of organic and automated signals.

View full analysis →

_{This is an automated analysis by AgentScan}

codspeed-hq · 2026-06-11T04:18:17Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks¹

_{Comparing Mokto:fix/svelte-script-cross-references (de4c1aa) with main (263c7cc)}

196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai · 2026-06-24T12:22:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 92bcf2b7-014c-407e-9594-b0941154baf5

📥 Commits

Reviewing files that changed from the base of the PR and between 85133fb and 5eae888.

⛔ Files ignored due to path filters (3)

crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/valid-svelte-cross-script-imports.svelte.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/invalid-svelte-unused-module-binding.svelte.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/valid-svelte-cross-script-references.svelte.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (5)

.changeset/fix-svelte-script-module-cross-references.md
crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/valid-svelte-cross-script-imports.svelte
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/invalid-svelte-unused-module-binding.svelte
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/valid-svelte-cross-script-references.svelte
crates/biome_workspace_db/src/embedded/visitor.rs

💤 Files with no reviewable changes (1)

crates/biome_workspace_db/src/embedded/visitor.rs

✅ Files skipped from review due to trivial changes (3)

crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/valid-svelte-cross-script-imports.svelte
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/invalid-svelte-unused-module-binding.svelte
.changeset/fix-svelte-script-module-cross-references.md

🚧 Files skipped from review as they are similar to previous changes (1)

crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/valid-svelte-cross-script-references.svelte

Walkthrough

A boolean is_svelte flag is added to collect_embedded_references in visitor.rs, derived from the host HTML file source. The snippet visitation condition is broadened from !js_file_source.is_embedded_source() to !js_file_source.is_embedded_source() || is_svelte, so that sibling <script> blocks in Svelte files are visited when collecting references. Three Svelte test fixtures are added: two valid cases (cross-script noUnusedImports and noUnusedVariables) and one invalid case (genuinely unused module-scoped binding). A patch changeset entry is also included.

Possibly related PRs

biomejs/biome#9877: Extends Svelte embed parsing and binding extraction for template constructs, similarly addressing false-positive unused diagnostics in embedded Svelte regions.
biomejs/biome#10473: Aligns with this PR's embedded-reference wiring and unused lint logic changes for Svelte template/script usage.

Suggested labels

A-Project

Suggested reviewers

dyc3
ematipico

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: sharing Svelte `<script module>` and `<script>` scope for unused-binding rules.
Description check	✅ Passed	The description is directly about the same Svelte scope fix and its tests, so it is clearly on-topic.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.changeset/fix-svelte-script-module-cross-references.md:
- Line 5: Update the changeset entry to follow the bugfix convention by starting
the summary with Fixed [`#NUMBER`](issue link): and keep the existing description
about Svelte cross-reference false positives in noUnusedImports,
noUnusedVariables, and useImportType. Make sure the identifier and issue link
are included in the opening sentence of the changeset so it matches the
project’s required format.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b36bb874-2418-493f-8b68-4278dd873ea7

📥 Commits

Reviewing files that changed from the base of the PR and between f62fb8b and 85133fb.

⛔ Files ignored due to path filters (3)

crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/valid-svelte-cross-script-imports.svelte.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/invalid-svelte-unused-module-binding.svelte.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/valid-svelte-cross-script-references.svelte.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (5)

.changeset/fix-svelte-script-module-cross-references.md
crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/valid-svelte-cross-script-imports.svelte
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/invalid-svelte-unused-module-binding.svelte
crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/valid-svelte-cross-script-references.svelte
crates/biome_service/src/workspace/server.rs

coderabbitai · 2026-06-24T12:22:35Z

+"@biomejs/biome": patch
+---
+
+Fixed false positives in `noUnusedImports`, `noUnusedVariables`, and `useImportType` for Svelte components that use both a `<script module>` and a `<script>` block. The two blocks compile to a single module and share a top-level scope, so a binding (import, function, or variable) declared in one block and used only in the other is no longer reported as unused.


📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use the required bugfix changeset prefix with an issue link.

Please start the entry with Fixed [#NUMBER](issue link): ... so it follows project changeset conventions.

As per coding guidelines, bugfix changesets should start with Fixed [#NUMBER](issue link): ...; based on learnings, this exact link format is required.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.changeset/fix-svelte-script-module-cross-references.md at line 5, Update the changeset entry to follow the bugfix convention by starting the summary with Fixed [`#NUMBER`](issue link): and keep the existing description about Svelte cross-reference false positives in noUnusedImports, noUnusedVariables, and useImportType. Make sure the identifier and issue link are included in the opening sentence of the changeset so it matches the project’s required format.

Sources: Coding guidelines, Learnings

dyc3

Looks good! just need to fix the merge conflicts

…en't flagged as unused A Svelte component's `<script module>` and `<script>` compile to one module and share a top-level scope, but each block was analyzed as an isolated embedded snippet. A binding (import, function, or variable) declared in one block and used only in the other was therefore reported as unused by noUnusedImports / noUnusedVariables / useImportType. The workspace now also collects value/type references from Svelte source `<script>` snippets (not just template snippets), so a name referenced in the sibling block counts as used. Gated to Svelte, where the two blocks genuinely share a module scope; Vue/Astro are unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Mokto · 2026-06-28T05:25:52Z

@dyc3 done

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.1` -> `2.5.2`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.1/2.5.2) | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.5.2`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#252) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.1...@biomejs/biome@2.5.2) ##### Patch Changes - [#10595](biomejs/biome#10595) [`f458028`](biomejs/biome@f458028) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignoreBooleanCoercion` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||` and `||=` used inside a `Boolean()` call, where coalescing on falsy values is intentional. - [#10798](biomejs/biome#10798) [`4a32b63`](biomejs/biome@4a32b63) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignorePrimitives` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||`, `||=`, and ternary expressions whose non-nullish operands are all primitives the option opts out of. Use `true` to ignore all primitives, or an object selecting `string`, `number`, `boolean`, or `bigint`. - [#10545](biomejs/biome#10545) [`f3d4c00`](biomejs/biome@f3d4c00) Thanks [@Mokto](https://github.com/Mokto)! - Added the new nursery rule [`noSvelteUnnecessaryStateWrap`](https://biomejs.dev/linter/rules/no-svelte-unnecessary-state-wrap/), which reports unnecessary `$state()` wrapping of classes from `svelte/reactivity` that are already reactive. ```svelte <script> import { SvelteMap } from "svelte/reactivity"; const map = $state(new SvelteMap()); // redundant </script> ``` - [#10752](biomejs/biome#10752) [`f62fb8b`](biomejs/biome@f62fb8b) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10739](biomejs/biome#10739). Now the rule [`useValidAutocomplete`](https://biomejs.dev/linter/rules/use-valid-autocomplete/) correctly flags the `autoComplete` attribute. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10768](biomejs/biome#10768). Improved the performance of the Biome Language Server by cancelling certain in-flight operations when there are fast updates. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) false positive on returns that use a widening type assertion: `"a" as string` is no longer reported as misleading. The rule now also reports a literal-pinning assertion such as `false as false`, matching the existing `as const` behavior. ```ts // No longer flagged (returns are `string`): function getValue(b: boolean): string { if (b) return "a" as string; return "b" as string; } // Now also reported, like `as const` (returns `false`): function isReady(): boolean { return false as false; } ``` - [#10678](biomejs/biome#10678) [`8f073a7`](biomejs/biome@8f073a7) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#7718](biomejs/biome#7718): Biome now correctly parses CSS nesting selectors when `&` appears as a trailing sub-selector after a type selector, e.g. `h1& { color: red; }`. - [#10756](biomejs/biome#10756) [`5ec965a`](biomejs/biome@5ec965a) Thanks [@denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatter output for selector lists with `allowWrongLineComments` and `//` comments after a selector comma. Biome now keeps the selector before the line comment inline instead of breaking it across descendant combinators. ```diff -.powerPathNavigator - .helm - button.pressedButton, // pressed +.powerPathNavigator .helm button.pressedButton, // pressed .powerPathNavigator .helm button:active:not(.disabledButton) { } ``` - [#10757](biomejs/biome#10757) [`6232fcd`](biomejs/biome@6232fcd) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#8269](biomejs/biome#8269): the CSS parser now accepts Tailwind `@variant` and `@utility` names that start with a digit, such as the `2xl` breakpoint. ```css @utility container { @variant 2xl { max-width: 1400px; } } ``` - [#10777](biomejs/biome#10777) [`575ced6`](biomejs/biome@575ced6) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): the GitLab reporter now handles `--verbose` diagnostics filtering correctly. - [#10281](biomejs/biome#10281) [`0efe244`](biomejs/biome@0efe244) Thanks [@Zelys-DFKH](https://github.com/Zelys-DFKH)! - Fixed a bug where GritQL patterns rejected positional (unkeyed) arguments. - [#10758](biomejs/biome#10758) [`e36fd8a`](biomejs/biome@e36fd8a) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10697](biomejs/biome#10697): The formatter no longer removes the parentheses around an `await` or `yield` expression used as the target of a TypeScript instantiation expression. For example, `(await makeFactory)<Value>` is no longer reformatted to `await makeFactory<Value>`, which would change the meaning of the code. - [#10586](biomejs/biome#10586) [`3617094`](biomejs/biome@3617094) Thanks [@IxxyDev](https://github.com/IxxyDev)! - Fixed [#9568](biomejs/biome#9568): [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer reports a false positive when calling an overloaded function and the selected overload does not return a promise. ```ts function bestEffort(cb: () => Promise<number>): Promise<number>; function bestEffort(cb: () => number): number; function bestEffort( cb: () => number | Promise<number>, ): Promise<number> | number { return cb() as Promise<number> | number; } // This resolves to the second overload, which returns `number`, so it is no // longer flagged as a floating promise. bestEffort(() => 42); ``` - [#10766](biomejs/biome#10766) [`7aff4c1`](biomejs/biome@7aff4c1) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#2862](biomejs/biome#2862): [`noInteractiveElementToNoninteractiveRole`](https://biomejs.dev/linter/rules/no-interactive-element-to-noninteractive-role/) no longer reports custom elements (a tag name containing a dash, e.g. `<my-button role="img" />`). Per the [W3C HTML-ARIA specification](https://www.w3.org/TR/html-aria/#el-autonomous-custom-element), a custom element may be given any role or none. - [#10680](biomejs/biome#10680) [`771daa4`](biomejs/biome@771daa4) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed [#10635](biomejs/biome#10635): Biome now recognizes chained table tests such as `test.concurrent.each()` and `it.concurrent.each()` as test calls, fixing `noMisplacedAssertion` false positives and improving formatting for those test declarations. - [#10759](biomejs/biome#10759) [`34570b5`](biomejs/biome@34570b5) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10636](biomejs/biome#10636): [noStaticElementInteractions](https://biomejs.dev/linter/rules/no-static-element-interactions/) no longer reports a false positive for event handlers on Svelte special elements such as `<svelte:window>`, `<svelte:document>`, and `<svelte:body>`. These are not real DOM elements, so they are now ignored by the rule. - [#10741](biomejs/biome#10741) [`bd2364e`](biomejs/biome@bd2364e) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#6686](biomejs/biome#6686): the `rage` command now respects the `--config-path` option and the `BIOME_CONFIG_PATH` environment variable when loading the Biome configuration. Previously it always used the default configuration resolution and reported the configuration as `Not set` when no `biome.json` existed in the working directory. - [#10763](biomejs/biome#10763) [`2c3e82d`](biomejs/biome@2c3e82d) Thanks [@Aqu1bp](https://github.com/Aqu1bp)! - Fixed [#10742](biomejs/biome#10742): [`noSolidDestructuredProps`](https://biomejs.dev/linter/rules/no-solid-destructured-props) now reports destructured props in Solid function components and JSX children. - [#10606](biomejs/biome#10606) [`a4cc4ab`](biomejs/biome@a4cc4ab) Thanks [@Mokto](https://github.com/Mokto)! - Fixed false positives in `noUnusedImports`, `noUnusedVariables`, and `useImportType` for Svelte components that use both a `<script module>` and a `<script>` block. The two blocks compile to a single module and share a top-level scope, so a binding (import, function, or variable) declared in one block and used only in the other is no longer reported as unused. - [#10767](biomejs/biome#10767) [`36d5aa7`](biomejs/biome@36d5aa7) Thanks [@otkrickey](https://github.com/otkrickey)! - Fixed [#10754](biomejs/biome#10754): [`useVueValidVBind`](https://biomejs.dev/linter/rules/use-vue-valid-v-bind/) no longer reports the Vue 3.4+ same-name shorthand as missing a value. `:foo` and `v-bind:foo` are now accepted as equivalent to `:foo="foo"`, while `v-bind`, `v-bind:[dynamicArg]`, and `:[dynamicArg]` without a value continue to be reported. - [#10775](biomejs/biome#10775) [`a918af0`](biomejs/biome@a918af0) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): `biome rage` didn't detect running Biome daemon pipes on Windows. - [#10730](biomejs/biome#10730) [`5a2e65b`](biomejs/biome@5a2e65b) Thanks [@dinocosta](https://github.com/dinocosta)! - Fixed an issue where Biome was resolving [the well-known Zed settings file](https://biomejs.dev/guides/configure-biome/#well-known-files) from the wrong location on macOS and Windows. - [#10807](biomejs/biome#10807) [`d97fffe`](biomejs/biome@d97fffe) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where `.scss` files were incorrectly analyzed when running `biome check`. - [#10672](biomejs/biome#10672) [`53c6efc`](biomejs/biome@53c6efc) Thanks [@ematipico](https://github.com/ematipico)! - Fixed a bug where Biome incorrectly formatted snippets that have parsing errors. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`useAwaitThenable`](https://biomejs.dev/linter/rules/use-await-thenable/) false positive when awaiting a custom thenable that is not the global `Promise`. A value with a callable `then` member is now recognized as awaitable. ```ts interface Thenable<T> { then(onfulfilled: (value: T) => void): void; } declare const t: Thenable<number>; async function f() { await t; } ``` - [#10734](biomejs/biome#10734) [`4396496`](biomejs/biome@4396496) Thanks [@BangDori](https://github.com/BangDori)! - Fixed [#10708](biomejs/biome#10708): `biome migrate` now preserves trivia when migrating the deprecated `recommended` option to `preset`. - [#10683](biomejs/biome#10683) [`ae31a00`](biomejs/biome@ae31a00) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10657](biomejs/biome#10657) [#10671](biomejs/biome#10671) [#10661](biomejs/biome#10661) [#10637](biomejs/biome#10637) [#10718](biomejs/biome#10718): HTML rules now correctly handle dynamic attributes. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't correctly detect styles defined inside the Astro directive `is:global`. - [#10770](biomejs/biome#10770) [`dd1429c`](biomejs/biome@dd1429c) Thanks [@ematipico](https://github.com/ematipico)! - Improved the Biome Language Server DX by orchestrating certain operations, so that they won't block the editor during typing. This improvement is more visible in large documents. - [#10473](biomejs/biome#10473) [`d9b5133`](biomejs/biome@d9b5133) Thanks [@Mokto](https://github.com/Mokto)! - Improved [`noUnusedImports`](https://biomejs.dev/linter/rules/no-unused-imports/), [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/), [`noUnusedFunctionParameters`](https://biomejs.dev/linter/rules/no-unused-function-parameters/), and [`useImportType`](https://biomejs.dev/linter/rules/use-import-type/) for Svelte, Vue, and Astro files (with `html.experimentalFullSupportEnabled`). Bindings used only in the template — including component tags, attribute interpolations, directives, `bind:` shorthand, and snippet parameters — are no longer reported as unused, while genuinely unused ones still are. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where the Biome Language Server didn't enable project or type-aware lint rules, even when they were explicitly enabled. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't detect styles declared inside HTML documents. - [#10774](biomejs/biome#10774) [`bde945b`](biomejs/biome@bde945b) Thanks [@pattrickrice](https://github.com/pattrickrice)! - Fixed [#10268](biomejs/biome#10268) where a race condition resulted in internal errors such as: `The file biome.json does not exist in the workspace`. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/9

This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.1` -> `2.5.2`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.1/2.5.2) | `2.5.3` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.5.2`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#252) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.1...@biomejs/biome@2.5.2) ##### Patch Changes - [#10595](biomejs/biome#10595) [`f458028`](biomejs/biome@f458028) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignoreBooleanCoercion` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||` and `||=` used inside a `Boolean()` call, where coalescing on falsy values is intentional. - [#10798](biomejs/biome#10798) [`4a32b63`](biomejs/biome@4a32b63) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignorePrimitives` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||`, `||=`, and ternary expressions whose non-nullish operands are all primitives the option opts out of. Use `true` to ignore all primitives, or an object selecting `string`, `number`, `boolean`, or `bigint`. - [#10545](biomejs/biome#10545) [`f3d4c00`](biomejs/biome@f3d4c00) Thanks [@Mokto](https://github.com/Mokto)! - Added the new nursery rule [`noSvelteUnnecessaryStateWrap`](https://biomejs.dev/linter/rules/no-svelte-unnecessary-state-wrap/), which reports unnecessary `$state()` wrapping of classes from `svelte/reactivity` that are already reactive. ```svelte <script> import { SvelteMap } from "svelte/reactivity"; const map = $state(new SvelteMap()); // redundant </script> ``` - [#10752](biomejs/biome#10752) [`f62fb8b`](biomejs/biome@f62fb8b) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10739](biomejs/biome#10739). Now the rule [`useValidAutocomplete`](https://biomejs.dev/linter/rules/use-valid-autocomplete/) correctly flags the `autoComplete` attribute. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10768](biomejs/biome#10768). Improved the performance of the Biome Language Server by cancelling certain in-flight operations when there are fast updates. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) false positive on returns that use a widening type assertion: `"a" as string` is no longer reported as misleading. The rule now also reports a literal-pinning assertion such as `false as false`, matching the existing `as const` behavior. ```ts // No longer flagged (returns are `string`): function getValue(b: boolean): string { if (b) return "a" as string; return "b" as string; } // Now also reported, like `as const` (returns `false`): function isReady(): boolean { return false as false; } ``` - [#10678](biomejs/biome#10678) [`8f073a7`](biomejs/biome@8f073a7) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#7718](biomejs/biome#7718): Biome now correctly parses CSS nesting selectors when `&` appears as a trailing sub-selector after a type selector, e.g. `h1& { color: red; }`. - [#10756](biomejs/biome#10756) [`5ec965a`](biomejs/biome@5ec965a) Thanks [@denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatter output for selector lists with `allowWrongLineComments` and `//` comments after a selector comma. Biome now keeps the selector before the line comment inline instead of breaking it across descendant combinators. ```diff -.powerPathNavigator - .helm - button.pressedButton, // pressed +.powerPathNavigator .helm button.pressedButton, // pressed .powerPathNavigator .helm button:active:not(.disabledButton) { } ``` - [#10757](biomejs/biome#10757) [`6232fcd`](biomejs/biome@6232fcd) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#8269](biomejs/biome#8269): the CSS parser now accepts Tailwind `@variant` and `@utility` names that start with a digit, such as the `2xl` breakpoint. ```css @utility container { @variant 2xl { max-width: 1400px; } } ``` - [#10777](biomejs/biome#10777) [`575ced6`](biomejs/biome@575ced6) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): the GitLab reporter now handles `--verbose` diagnostics filtering correctly. - [#10281](biomejs/biome#10281) [`0efe244`](biomejs/biome@0efe244) Thanks [@Zelys-DFKH](https://github.com/Zelys-DFKH)! - Fixed a bug where GritQL patterns rejected positional (unkeyed) arguments. - [#10758](biomejs/biome#10758) [`e36fd8a`](biomejs/biome@e36fd8a) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10697](biomejs/biome#10697): The formatter no longer removes the parentheses around an `await` or `yield` expression used as the target of a TypeScript instantiation expression. For example, `(await makeFactory)<Value>` is no longer reformatted to `await makeFactory<Value>`, which would change the meaning of the code. - [#10586](biomejs/biome#10586) [`3617094`](biomejs/biome@3617094) Thanks [@IxxyDev](https://github.com/IxxyDev)! - Fixed [#9568](biomejs/biome#9568): [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer reports a false positive when calling an overloaded function and the selected overload does not return a promise. ```ts function bestEffort(cb: () => Promise<number>): Promise<number>; function bestEffort(cb: () => number): number; function bestEffort( cb: () => number | Promise<number>, ): Promise<number> | number { return cb() as Promise<number> | number; } // This resolves to the second overload, which returns `number`, so it is no // longer flagged as a floating promise. bestEffort(() => 42); ``` - [#10766](biomejs/biome#10766) [`7aff4c1`](biomejs/biome@7aff4c1) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#2862](biomejs/biome#2862): [`noInteractiveElementToNoninteractiveRole`](https://biomejs.dev/linter/rules/no-interactive-element-to-noninteractive-role/) no longer reports custom elements (a tag name containing a dash, e.g. `<my-button role="img" />`). Per the [W3C HTML-ARIA specification](https://www.w3.org/TR/html-aria/#el-autonomous-custom-element), a custom element may be given any role or none. - [#10680](biomejs/biome#10680) [`771daa4`](biomejs/biome@771daa4) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed [#10635](biomejs/biome#10635): Biome now recognizes chained table tests such as `test.concurrent.each()` and `it.concurrent.each()` as test calls, fixing `noMisplacedAssertion` false positives and improving formatting for those test declarations. - [#10759](biomejs/biome#10759) [`34570b5`](biomejs/biome@34570b5) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10636](biomejs/biome#10636): [noStaticElementInteractions](https://biomejs.dev/linter/rules/no-static-element-interactions/) no longer reports a false positive for event handlers on Svelte special elements such as `<svelte:window>`, `<svelte:document>`, and `<svelte:body>`. These are not real DOM elements, so they are now ignored by the rule. - [#10741](biomejs/biome#10741) [`bd2364e`](biomejs/biome@bd2364e) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#6686](biomejs/biome#6686): the `rage` command now respects the `--config-path` option and the `BIOME_CONFIG_PATH` environment variable when loading the Biome configuration. Previously it always used the default configuration resolution and reported the configuration as `Not set` when no `biome.json` existed in the working directory. - [#10763](biomejs/biome#10763) [`2c3e82d`](biomejs/biome@2c3e82d) Thanks [@Aqu1bp](https://github.com/Aqu1bp)! - Fixed [#10742](biomejs/biome#10742): [`noSolidDestructuredProps`](https://biomejs.dev/linter/rules/no-solid-destructured-props) now reports destructured props in Solid function components and JSX children. - [#10606](biomejs/biome#10606) [`a4cc4ab`](biomejs/biome@a4cc4ab) Thanks [@Mokto](https://github.com/Mokto)! - Fixed false positives in `noUnusedImports`, `noUnusedVariables`, and `useImportType` for Svelte components that use both a `<script module>` and a `<script>` block. The two blocks compile to a single module and share a top-level scope, so a binding (import, function, or variable) declared in one block and used only in the other is no longer reported as unused. - [#10767](biomejs/biome#10767) [`36d5aa7`](biomejs/biome@36d5aa7) Thanks [@otkrickey](https://github.com/otkrickey)! - Fixed [#10754](biomejs/biome#10754): [`useVueValidVBind`](https://biomejs.dev/linter/rules/use-vue-valid-v-bind/) no longer reports the Vue 3.4+ same-name shorthand as missing a value. `:foo` and `v-bind:foo` are now accepted as equivalent to `:foo="foo"`, while `v-bind`, `v-bind:[dynamicArg]`, and `:[dynamicArg]` without a value continue to be reported. - [#10775](biomejs/biome#10775) [`a918af0`](biomejs/biome@a918af0) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): `biome rage` didn't detect running Biome daemon pipes on Windows. - [#10730](biomejs/biome#10730) [`5a2e65b`](biomejs/biome@5a2e65b) Thanks [@dinocosta](https://github.com/dinocosta)! - Fixed an issue where Biome was resolving [the well-known Zed settings file](https://biomejs.dev/guides/configure-biome/#well-known-files) from the wrong location on macOS and Windows. - [#10807](biomejs/biome#10807) [`d97fffe`](biomejs/biome@d97fffe) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where `.scss` files were incorrectly analyzed when running `biome check`. - [#10672](biomejs/biome#10672) [`53c6efc`](biomejs/biome@53c6efc) Thanks [@ematipico](https://github.com/ematipico)! - Fixed a bug where Biome incorrectly formatted snippets that have parsing errors. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`useAwaitThenable`](https://biomejs.dev/linter/rules/use-await-thenable/) false positive when awaiting a custom thenable that is not the global `Promise`. A value with a callable `then` member is now recognized as awaitable. ```ts interface Thenable<T> { then(onfulfilled: (value: T) => void): void; } declare const t: Thenable<number>; async function f() { await t; } ``` - [#10734](biomejs/biome#10734) [`4396496`](biomejs/biome@4396496) Thanks [@BangDori](https://github.com/BangDori)! - Fixed [#10708](biomejs/biome#10708): `biome migrate` now preserves trivia when migrating the deprecated `recommended` option to `preset`. - [#10683](biomejs/biome#10683) [`ae31a00`](biomejs/biome@ae31a00) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10657](biomejs/biome#10657) [#10671](biomejs/biome#10671) [#10661](biomejs/biome#10661) [#10637](biomejs/biome#10637) [#10718](biomejs/biome#10718): HTML rules now correctly handle dynamic attributes. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't correctly detect styles defined inside the Astro directive `is:global`. - [#10770](biomejs/biome#10770) [`dd1429c`](biomejs/biome@dd1429c) Thanks [@ematipico](https://github.com/ematipico)! - Improved the Biome Language Server DX by orchestrating certain operations, so that they won't block the editor during typing. This improvement is more visible in large documents. - [#10473](biomejs/biome#10473) [`d9b5133`](biomejs/biome@d9b5133) Thanks [@Mokto](https://github.com/Mokto)! - Improved [`noUnusedImports`](https://biomejs.dev/linter/rules/no-unused-imports/), [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/), [`noUnusedFunctionParameters`](https://biomejs.dev/linter/rules/no-unused-function-parameters/), and [`useImportType`](https://biomejs.dev/linter/rules/use-import-type/) for Svelte, Vue, and Astro files (with `html.experimentalFullSupportEnabled`). Bindings used only in the template — including component tags, attribute interpolations, directives, `bind:` shorthand, and snippet parameters — are no longer reported as unused, while genuinely unused ones still are. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where the Biome Language Server didn't enable project or type-aware lint rules, even when they were explicitly enabled. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't detect styles declared inside HTML documents. - [#10774](biomejs/biome#10774) [`bde945b`](biomejs/biome@bde945b) Thanks [@pattrickrice](https://github.com/pattrickrice)! - Fixed [#10268](biomejs/biome#10268) where a race condition resulted in internal errors such as: `The file biome.json does not exist in the workspace`. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/22

github-actions Bot added agentscan:mixed-signals A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jun 11, 2026

Mokto force-pushed the fix/svelte-script-cross-references branch from de4c1aa to 85133fb Compare June 24, 2026 12:03

Mokto changed the title ~~[WIP - waiting for 10473] fix(svelte): share <script module>/<script> scope for unused-binding rules~~ fix(svelte): share <script module>/<script> scope for unused-binding rules Jun 24, 2026

Mokto marked this pull request as ready for review June 24, 2026 12:17

coderabbitai Bot reviewed Jun 24, 2026

View reviewed changes

dyc3 approved these changes Jun 27, 2026

View reviewed changes

Mokto force-pushed the fix/svelte-script-cross-references branch from 85133fb to 5eae888 Compare June 28, 2026 04:05

github-actions Bot removed the A-Project Area: project label Jun 28, 2026

Mokto requested a review from dyc3 June 28, 2026 05:25

ematipico approved these changes Jul 1, 2026

View reviewed changes

ematipico merged commit a4cc4ab into biomejs:main Jul 1, 2026
28 checks passed

github-actions Bot mentioned this pull request Jul 1, 2026

ci: release #10747

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(svelte): share `<script module>`/`<script>` scope for unused-binding rules#10606

fix(svelte): share `<script module>`/`<script>` scope for unused-binding rules#10606
ematipico merged 1 commit into
biomejs:mainfrom
Mokto:fix/svelte-script-cross-references

Mokto commented Jun 11, 2026

Uh oh!

changeset-bot Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 11, 2026

Uh oh!

codspeed-hq Bot commented Jun 11, 2026

Uh oh!

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 24, 2026

Uh oh!

dyc3 left a comment

Uh oh!

Mokto commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Mokto commented Jun 11, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jun 11, 2026

⚠️ Mixed activity

Uh oh!

codspeed-hq Bot commented Jun 11, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

coderabbitai Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

dyc3 left a comment

Choose a reason for hiding this comment

Uh oh!

Mokto commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot Bot commented Jun 11, 2026 •

edited

Loading

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading