fix(lint): ignore custom elements in noInteractiveElementToNoninteractiveRole by JamBalaya56562 · Pull Request #10766 · biomejs/biome

JamBalaya56562 · 2026-06-26T06:53:42Z

Summary

Fixes #2862. noInteractiveElementToNoninteractiveRole reported a false positive for autonomous custom elements (a tag name containing a dash, e.g. <my-button role="img" />). Per the W3C HTML-ARIA spec, an autonomous custom element may be given any role or none, so it carries no inherent interactivity for a non-interactive role to override.

The fix adds an early return using the existing AnyJsxElement::is_custom_element() helper — the same guard noStaticElementInteractions already uses (added in #10191). The rule already returns early for components via the is_element() check, so only is_custom_element() is needed (adding is_custom_component() would be dead code).

A changeset is included.

Test Plan

Added three cases to the rule's valid.jsx spec fixture — <my-button role="img" />, <my-element role="listitem" />, and <custom-card role="button" /> — which previously triggered the rule and now produce no diagnostics. invalid.jsx is unchanged, so no existing diagnostic regresses.

Docs

No documentation change needed.

AI assistance disclosure: the code, tests, and this PR description were produced with the help of Claude Code and reviewed by me before submission.

github-actions · 2026-06-26T06:53:51Z

✅ Organic activity

No automation signals detected in the analyzed events.

View full analysis →

_{This is an automated analysis by AgentScan}

changeset-bot · 2026-06-26T06:54:03Z

🦋 Changeset detected

Latest commit: b51ce36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-06-26T06:57:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fa41c0eb-c515-422f-ac12-24d517bc98ee

📥 Commits

Reviewing files that changed from the base of the PR and between c9438f6 and 7d83cd3.

⛔ Files ignored due to path filters (1)

crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (3)

.changeset/fix-no-interactive-role-custom-element.md
crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs
crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx

✅ Files skipped from review due to trivial changes (1)

.changeset/fix-no-interactive-role-custom-element.md

🚧 Files skipped from review as they are similar to previous changes (2)

crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx
crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs

Walkthrough

The lint rule now returns early for autonomous custom elements before analysing roles. The valid spec adds JSX cases for custom elements with ARIA roles, and a changeset records the patch release note for the rule change.

Possibly related PRs

biomejs/biome#10028: Also changes noInteractiveElementToNoninteractiveRole to exempt custom elements from the rule’s diagnostics.

Suggested reviewers

dyc3

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: custom elements are ignored by the lint rule.
Description check	✅ Passed	The description is directly about the same lint false positive and its fix.
Linked Issues check	✅ Passed	The code and tests implement the requested behaviour for autonomous custom elements in `#2862`.
Out of Scope Changes check	✅ Passed	The changes stay within the rule fix, supporting tests, and changeset with no obvious unrelated work.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs`:
- Around line 64-69: The rule logic in
no_interactive_element_to_noninteractive_role now skips autonomous custom
elements, but the inline rustdoc still describes the old behavior. Update the
rule documentation attached to the lint module and add a rustdoc example showing
a dashed custom element such as an autonomous custom element being allowed with
any role or none, so the docs match the behavior in the node.is_custom_element()
branch.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b462d1d5-8a41-4a9b-9720-a061f855012d

📥 Commits

Reviewing files that changed from the base of the PR and between 2ff160a and c254ac3.

⛔ Files ignored due to path filters (1)

crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (3)

.changeset/fix-no-interactive-role-custom-element.md
crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs
crates/biome_js_analyze/tests/specs/a11y/noInteractiveElementToNoninteractiveRole/valid.jsx

codspeed-hq · 2026-06-26T07:11:36Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks¹

_{Comparing JamBalaya56562:fix-no-interactive-role-custom-element (b51ce36) with main (d97fffe)}

196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ematipico

Can you please remove the word "autonomous" from custom elements? It doesn't mean anything. They are just "custom elements"

ematipico · 2026-06-30T10:18:18Z


 ```
+
+_Note: The parser emitted 4 diagnostics which are not shown here._


@JamBalaya56562 please fix this snapshot. You added invalid code to the fixture.

Fixed 🙏 The root cause was a missing semicolon after </picture> in the fixture: without it the parser read the following <> fragment as a < comparison (<picture/> < <>…), which produced 4 cascading parse errors. Added the ;, so the file now parses with 0 diagnostics, and regenerated the snapshot (the parser-diagnostics note is gone).

…tiveRole Fixes biomejs#2862. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.1` -> `2.5.2`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.1/2.5.2) | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.5.2`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#252) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.1...@biomejs/biome@2.5.2) ##### Patch Changes - [#10595](biomejs/biome#10595) [`f458028`](biomejs/biome@f458028) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignoreBooleanCoercion` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||` and `||=` used inside a `Boolean()` call, where coalescing on falsy values is intentional. - [#10798](biomejs/biome#10798) [`4a32b63`](biomejs/biome@4a32b63) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignorePrimitives` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||`, `||=`, and ternary expressions whose non-nullish operands are all primitives the option opts out of. Use `true` to ignore all primitives, or an object selecting `string`, `number`, `boolean`, or `bigint`. - [#10545](biomejs/biome#10545) [`f3d4c00`](biomejs/biome@f3d4c00) Thanks [@Mokto](https://github.com/Mokto)! - Added the new nursery rule [`noSvelteUnnecessaryStateWrap`](https://biomejs.dev/linter/rules/no-svelte-unnecessary-state-wrap/), which reports unnecessary `$state()` wrapping of classes from `svelte/reactivity` that are already reactive. ```svelte <script> import { SvelteMap } from "svelte/reactivity"; const map = $state(new SvelteMap()); // redundant </script> ``` - [#10752](biomejs/biome#10752) [`f62fb8b`](biomejs/biome@f62fb8b) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10739](biomejs/biome#10739). Now the rule [`useValidAutocomplete`](https://biomejs.dev/linter/rules/use-valid-autocomplete/) correctly flags the `autoComplete` attribute. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10768](biomejs/biome#10768). Improved the performance of the Biome Language Server by cancelling certain in-flight operations when there are fast updates. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) false positive on returns that use a widening type assertion: `"a" as string` is no longer reported as misleading. The rule now also reports a literal-pinning assertion such as `false as false`, matching the existing `as const` behavior. ```ts // No longer flagged (returns are `string`): function getValue(b: boolean): string { if (b) return "a" as string; return "b" as string; } // Now also reported, like `as const` (returns `false`): function isReady(): boolean { return false as false; } ``` - [#10678](biomejs/biome#10678) [`8f073a7`](biomejs/biome@8f073a7) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#7718](biomejs/biome#7718): Biome now correctly parses CSS nesting selectors when `&` appears as a trailing sub-selector after a type selector, e.g. `h1& { color: red; }`. - [#10756](biomejs/biome#10756) [`5ec965a`](biomejs/biome@5ec965a) Thanks [@denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatter output for selector lists with `allowWrongLineComments` and `//` comments after a selector comma. Biome now keeps the selector before the line comment inline instead of breaking it across descendant combinators. ```diff -.powerPathNavigator - .helm - button.pressedButton, // pressed +.powerPathNavigator .helm button.pressedButton, // pressed .powerPathNavigator .helm button:active:not(.disabledButton) { } ``` - [#10757](biomejs/biome#10757) [`6232fcd`](biomejs/biome@6232fcd) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#8269](biomejs/biome#8269): the CSS parser now accepts Tailwind `@variant` and `@utility` names that start with a digit, such as the `2xl` breakpoint. ```css @utility container { @variant 2xl { max-width: 1400px; } } ``` - [#10777](biomejs/biome#10777) [`575ced6`](biomejs/biome@575ced6) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): the GitLab reporter now handles `--verbose` diagnostics filtering correctly. - [#10281](biomejs/biome#10281) [`0efe244`](biomejs/biome@0efe244) Thanks [@Zelys-DFKH](https://github.com/Zelys-DFKH)! - Fixed a bug where GritQL patterns rejected positional (unkeyed) arguments. - [#10758](biomejs/biome#10758) [`e36fd8a`](biomejs/biome@e36fd8a) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10697](biomejs/biome#10697): The formatter no longer removes the parentheses around an `await` or `yield` expression used as the target of a TypeScript instantiation expression. For example, `(await makeFactory)<Value>` is no longer reformatted to `await makeFactory<Value>`, which would change the meaning of the code. - [#10586](biomejs/biome#10586) [`3617094`](biomejs/biome@3617094) Thanks [@IxxyDev](https://github.com/IxxyDev)! - Fixed [#9568](biomejs/biome#9568): [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer reports a false positive when calling an overloaded function and the selected overload does not return a promise. ```ts function bestEffort(cb: () => Promise<number>): Promise<number>; function bestEffort(cb: () => number): number; function bestEffort( cb: () => number | Promise<number>, ): Promise<number> | number { return cb() as Promise<number> | number; } // This resolves to the second overload, which returns `number`, so it is no // longer flagged as a floating promise. bestEffort(() => 42); ``` - [#10766](biomejs/biome#10766) [`7aff4c1`](biomejs/biome@7aff4c1) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#2862](biomejs/biome#2862): [`noInteractiveElementToNoninteractiveRole`](https://biomejs.dev/linter/rules/no-interactive-element-to-noninteractive-role/) no longer reports custom elements (a tag name containing a dash, e.g. `<my-button role="img" />`). Per the [W3C HTML-ARIA specification](https://www.w3.org/TR/html-aria/#el-autonomous-custom-element), a custom element may be given any role or none. - [#10680](biomejs/biome#10680) [`771daa4`](biomejs/biome@771daa4) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed [#10635](biomejs/biome#10635): Biome now recognizes chained table tests such as `test.concurrent.each()` and `it.concurrent.each()` as test calls, fixing `noMisplacedAssertion` false positives and improving formatting for those test declarations. - [#10759](biomejs/biome#10759) [`34570b5`](biomejs/biome@34570b5) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10636](biomejs/biome#10636): [noStaticElementInteractions](https://biomejs.dev/linter/rules/no-static-element-interactions/) no longer reports a false positive for event handlers on Svelte special elements such as `<svelte:window>`, `<svelte:document>`, and `<svelte:body>`. These are not real DOM elements, so they are now ignored by the rule. - [#10741](biomejs/biome#10741) [`bd2364e`](biomejs/biome@bd2364e) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#6686](biomejs/biome#6686): the `rage` command now respects the `--config-path` option and the `BIOME_CONFIG_PATH` environment variable when loading the Biome configuration. Previously it always used the default configuration resolution and reported the configuration as `Not set` when no `biome.json` existed in the working directory. - [#10763](biomejs/biome#10763) [`2c3e82d`](biomejs/biome@2c3e82d) Thanks [@Aqu1bp](https://github.com/Aqu1bp)! - Fixed [#10742](biomejs/biome#10742): [`noSolidDestructuredProps`](https://biomejs.dev/linter/rules/no-solid-destructured-props) now reports destructured props in Solid function components and JSX children. - [#10606](biomejs/biome#10606) [`a4cc4ab`](biomejs/biome@a4cc4ab) Thanks [@Mokto](https://github.com/Mokto)! - Fixed false positives in `noUnusedImports`, `noUnusedVariables`, and `useImportType` for Svelte components that use both a `<script module>` and a `<script>` block. The two blocks compile to a single module and share a top-level scope, so a binding (import, function, or variable) declared in one block and used only in the other is no longer reported as unused. - [#10767](biomejs/biome#10767) [`36d5aa7`](biomejs/biome@36d5aa7) Thanks [@otkrickey](https://github.com/otkrickey)! - Fixed [#10754](biomejs/biome#10754): [`useVueValidVBind`](https://biomejs.dev/linter/rules/use-vue-valid-v-bind/) no longer reports the Vue 3.4+ same-name shorthand as missing a value. `:foo` and `v-bind:foo` are now accepted as equivalent to `:foo="foo"`, while `v-bind`, `v-bind:[dynamicArg]`, and `:[dynamicArg]` without a value continue to be reported. - [#10775](biomejs/biome#10775) [`a918af0`](biomejs/biome@a918af0) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): `biome rage` didn't detect running Biome daemon pipes on Windows. - [#10730](biomejs/biome#10730) [`5a2e65b`](biomejs/biome@5a2e65b) Thanks [@dinocosta](https://github.com/dinocosta)! - Fixed an issue where Biome was resolving [the well-known Zed settings file](https://biomejs.dev/guides/configure-biome/#well-known-files) from the wrong location on macOS and Windows. - [#10807](biomejs/biome#10807) [`d97fffe`](biomejs/biome@d97fffe) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where `.scss` files were incorrectly analyzed when running `biome check`. - [#10672](biomejs/biome#10672) [`53c6efc`](biomejs/biome@53c6efc) Thanks [@ematipico](https://github.com/ematipico)! - Fixed a bug where Biome incorrectly formatted snippets that have parsing errors. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`useAwaitThenable`](https://biomejs.dev/linter/rules/use-await-thenable/) false positive when awaiting a custom thenable that is not the global `Promise`. A value with a callable `then` member is now recognized as awaitable. ```ts interface Thenable<T> { then(onfulfilled: (value: T) => void): void; } declare const t: Thenable<number>; async function f() { await t; } ``` - [#10734](biomejs/biome#10734) [`4396496`](biomejs/biome@4396496) Thanks [@BangDori](https://github.com/BangDori)! - Fixed [#10708](biomejs/biome#10708): `biome migrate` now preserves trivia when migrating the deprecated `recommended` option to `preset`. - [#10683](biomejs/biome#10683) [`ae31a00`](biomejs/biome@ae31a00) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10657](biomejs/biome#10657) [#10671](biomejs/biome#10671) [#10661](biomejs/biome#10661) [#10637](biomejs/biome#10637) [#10718](biomejs/biome#10718): HTML rules now correctly handle dynamic attributes. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't correctly detect styles defined inside the Astro directive `is:global`. - [#10770](biomejs/biome#10770) [`dd1429c`](biomejs/biome@dd1429c) Thanks [@ematipico](https://github.com/ematipico)! - Improved the Biome Language Server DX by orchestrating certain operations, so that they won't block the editor during typing. This improvement is more visible in large documents. - [#10473](biomejs/biome#10473) [`d9b5133`](biomejs/biome@d9b5133) Thanks [@Mokto](https://github.com/Mokto)! - Improved [`noUnusedImports`](https://biomejs.dev/linter/rules/no-unused-imports/), [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/), [`noUnusedFunctionParameters`](https://biomejs.dev/linter/rules/no-unused-function-parameters/), and [`useImportType`](https://biomejs.dev/linter/rules/use-import-type/) for Svelte, Vue, and Astro files (with `html.experimentalFullSupportEnabled`). Bindings used only in the template — including component tags, attribute interpolations, directives, `bind:` shorthand, and snippet parameters — are no longer reported as unused, while genuinely unused ones still are. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where the Biome Language Server didn't enable project or type-aware lint rules, even when they were explicitly enabled. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't detect styles declared inside HTML documents. - [#10774](biomejs/biome#10774) [`bde945b`](biomejs/biome@bde945b) Thanks [@pattrickrice](https://github.com/pattrickrice)! - Fixed [#10268](biomejs/biome#10268) where a race condition resulted in internal errors such as: `The file biome.json does not exist in the workspace`. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/9

This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.1` -> `2.5.2`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.1/2.5.2) | `2.5.3` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.5.2`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#252) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.1...@biomejs/biome@2.5.2) ##### Patch Changes - [#10595](biomejs/biome#10595) [`f458028`](biomejs/biome@f458028) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignoreBooleanCoercion` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||` and `||=` used inside a `Boolean()` call, where coalescing on falsy values is intentional. - [#10798](biomejs/biome#10798) [`4a32b63`](biomejs/biome@4a32b63) Thanks [@pkallos](https://github.com/pkallos)! - Added the option `ignorePrimitives` to [useNullishCoalescing](https://biomejs.dev/linter/rules/use-nullish-coalescing/). When enabled, Biome ignores `||`, `||=`, and ternary expressions whose non-nullish operands are all primitives the option opts out of. Use `true` to ignore all primitives, or an object selecting `string`, `number`, `boolean`, or `bigint`. - [#10545](biomejs/biome#10545) [`f3d4c00`](biomejs/biome@f3d4c00) Thanks [@Mokto](https://github.com/Mokto)! - Added the new nursery rule [`noSvelteUnnecessaryStateWrap`](https://biomejs.dev/linter/rules/no-svelte-unnecessary-state-wrap/), which reports unnecessary `$state()` wrapping of classes from `svelte/reactivity` that are already reactive. ```svelte <script> import { SvelteMap } from "svelte/reactivity"; const map = $state(new SvelteMap()); // redundant </script> ``` - [#10752](biomejs/biome#10752) [`f62fb8b`](biomejs/biome@f62fb8b) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10739](biomejs/biome#10739). Now the rule [`useValidAutocomplete`](https://biomejs.dev/linter/rules/use-valid-autocomplete/) correctly flags the `autoComplete` attribute. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10768](biomejs/biome#10768). Improved the performance of the Biome Language Server by cancelling certain in-flight operations when there are fast updates. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) false positive on returns that use a widening type assertion: `"a" as string` is no longer reported as misleading. The rule now also reports a literal-pinning assertion such as `false as false`, matching the existing `as const` behavior. ```ts // No longer flagged (returns are `string`): function getValue(b: boolean): string { if (b) return "a" as string; return "b" as string; } // Now also reported, like `as const` (returns `false`): function isReady(): boolean { return false as false; } ``` - [#10678](biomejs/biome#10678) [`8f073a7`](biomejs/biome@8f073a7) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#7718](biomejs/biome#7718): Biome now correctly parses CSS nesting selectors when `&` appears as a trailing sub-selector after a type selector, e.g. `h1& { color: red; }`. - [#10756](biomejs/biome#10756) [`5ec965a`](biomejs/biome@5ec965a) Thanks [@denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatter output for selector lists with `allowWrongLineComments` and `//` comments after a selector comma. Biome now keeps the selector before the line comment inline instead of breaking it across descendant combinators. ```diff -.powerPathNavigator - .helm - button.pressedButton, // pressed +.powerPathNavigator .helm button.pressedButton, // pressed .powerPathNavigator .helm button:active:not(.disabledButton) { } ``` - [#10757](biomejs/biome#10757) [`6232fcd`](biomejs/biome@6232fcd) Thanks [@PranavAchar01](https://github.com/PranavAchar01)! - Fixed [#8269](biomejs/biome#8269): the CSS parser now accepts Tailwind `@variant` and `@utility` names that start with a digit, such as the `2xl` breakpoint. ```css @utility container { @variant 2xl { max-width: 1400px; } } ``` - [#10777](biomejs/biome#10777) [`575ced6`](biomejs/biome@575ced6) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): the GitLab reporter now handles `--verbose` diagnostics filtering correctly. - [#10281](biomejs/biome#10281) [`0efe244`](biomejs/biome@0efe244) Thanks [@Zelys-DFKH](https://github.com/Zelys-DFKH)! - Fixed a bug where GritQL patterns rejected positional (unkeyed) arguments. - [#10758](biomejs/biome#10758) [`e36fd8a`](biomejs/biome@e36fd8a) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10697](biomejs/biome#10697): The formatter no longer removes the parentheses around an `await` or `yield` expression used as the target of a TypeScript instantiation expression. For example, `(await makeFactory)<Value>` is no longer reformatted to `await makeFactory<Value>`, which would change the meaning of the code. - [#10586](biomejs/biome#10586) [`3617094`](biomejs/biome@3617094) Thanks [@IxxyDev](https://github.com/IxxyDev)! - Fixed [#9568](biomejs/biome#9568): [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer reports a false positive when calling an overloaded function and the selected overload does not return a promise. ```ts function bestEffort(cb: () => Promise<number>): Promise<number>; function bestEffort(cb: () => number): number; function bestEffort( cb: () => number | Promise<number>, ): Promise<number> | number { return cb() as Promise<number> | number; } // This resolves to the second overload, which returns `number`, so it is no // longer flagged as a floating promise. bestEffort(() => 42); ``` - [#10766](biomejs/biome#10766) [`7aff4c1`](biomejs/biome@7aff4c1) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#2862](biomejs/biome#2862): [`noInteractiveElementToNoninteractiveRole`](https://biomejs.dev/linter/rules/no-interactive-element-to-noninteractive-role/) no longer reports custom elements (a tag name containing a dash, e.g. `<my-button role="img" />`). Per the [W3C HTML-ARIA specification](https://www.w3.org/TR/html-aria/#el-autonomous-custom-element), a custom element may be given any role or none. - [#10680](biomejs/biome#10680) [`771daa4`](biomejs/biome@771daa4) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed [#10635](biomejs/biome#10635): Biome now recognizes chained table tests such as `test.concurrent.each()` and `it.concurrent.each()` as test calls, fixing `noMisplacedAssertion` false positives and improving formatting for those test declarations. - [#10759](biomejs/biome#10759) [`34570b5`](biomejs/biome@34570b5) Thanks [@henrybrewer00-dotcom](https://github.com/henrybrewer00-dotcom)! - Fixed [#10636](biomejs/biome#10636): [noStaticElementInteractions](https://biomejs.dev/linter/rules/no-static-element-interactions/) no longer reports a false positive for event handlers on Svelte special elements such as `<svelte:window>`, `<svelte:document>`, and `<svelte:body>`. These are not real DOM elements, so they are now ignored by the rule. - [#10741](biomejs/biome#10741) [`bd2364e`](biomejs/biome@bd2364e) Thanks [@JamBalaya56562](https://github.com/JamBalaya56562)! - Fixed [#6686](biomejs/biome#6686): the `rage` command now respects the `--config-path` option and the `BIOME_CONFIG_PATH` environment variable when loading the Biome configuration. Previously it always used the default configuration resolution and reported the configuration as `Not set` when no `biome.json` existed in the working directory. - [#10763](biomejs/biome#10763) [`2c3e82d`](biomejs/biome@2c3e82d) Thanks [@Aqu1bp](https://github.com/Aqu1bp)! - Fixed [#10742](biomejs/biome#10742): [`noSolidDestructuredProps`](https://biomejs.dev/linter/rules/no-solid-destructured-props) now reports destructured props in Solid function components and JSX children. - [#10606](biomejs/biome#10606) [`a4cc4ab`](biomejs/biome@a4cc4ab) Thanks [@Mokto](https://github.com/Mokto)! - Fixed false positives in `noUnusedImports`, `noUnusedVariables`, and `useImportType` for Svelte components that use both a `<script module>` and a `<script>` block. The two blocks compile to a single module and share a top-level scope, so a binding (import, function, or variable) declared in one block and used only in the other is no longer reported as unused. - [#10767](biomejs/biome#10767) [`36d5aa7`](biomejs/biome@36d5aa7) Thanks [@otkrickey](https://github.com/otkrickey)! - Fixed [#10754](biomejs/biome#10754): [`useVueValidVBind`](https://biomejs.dev/linter/rules/use-vue-valid-v-bind/) no longer reports the Vue 3.4+ same-name shorthand as missing a value. `:foo` and `v-bind:foo` are now accepted as equivalent to `:foo="foo"`, while `v-bind`, `v-bind:[dynamicArg]`, and `:[dynamicArg]` without a value continue to be reported. - [#10775](biomejs/biome#10775) [`a918af0`](biomejs/biome@a918af0) Thanks [@WaterWhisperer](https://github.com/WaterWhisperer)! - Fixed an issue reported in [#10708](biomejs/biome#10708): `biome rage` didn't detect running Biome daemon pipes on Windows. - [#10730](biomejs/biome#10730) [`5a2e65b`](biomejs/biome@5a2e65b) Thanks [@dinocosta](https://github.com/dinocosta)! - Fixed an issue where Biome was resolving [the well-known Zed settings file](https://biomejs.dev/guides/configure-biome/#well-known-files) from the wrong location on macOS and Windows. - [#10807](biomejs/biome#10807) [`d97fffe`](biomejs/biome@d97fffe) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where `.scss` files were incorrectly analyzed when running `biome check`. - [#10672](biomejs/biome#10672) [`53c6efc`](biomejs/biome@53c6efc) Thanks [@ematipico](https://github.com/ematipico)! - Fixed a bug where Biome incorrectly formatted snippets that have parsing errors. - [#10719](biomejs/biome#10719) [`aa649b5`](biomejs/biome@aa649b5) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [`useAwaitThenable`](https://biomejs.dev/linter/rules/use-await-thenable/) false positive when awaiting a custom thenable that is not the global `Promise`. A value with a callable `then` member is now recognized as awaitable. ```ts interface Thenable<T> { then(onfulfilled: (value: T) => void): void; } declare const t: Thenable<number>; async function f() { await t; } ``` - [#10734](biomejs/biome#10734) [`4396496`](biomejs/biome@4396496) Thanks [@BangDori](https://github.com/BangDori)! - Fixed [#10708](biomejs/biome#10708): `biome migrate` now preserves trivia when migrating the deprecated `recommended` option to `preset`. - [#10683](biomejs/biome#10683) [`ae31a00`](biomejs/biome@ae31a00) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10657](biomejs/biome#10657) [#10671](biomejs/biome#10671) [#10661](biomejs/biome#10661) [#10637](biomejs/biome#10637) [#10718](biomejs/biome#10718): HTML rules now correctly handle dynamic attributes. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't correctly detect styles defined inside the Astro directive `is:global`. - [#10770](biomejs/biome#10770) [`dd1429c`](biomejs/biome@dd1429c) Thanks [@ematipico](https://github.com/ematipico)! - Improved the Biome Language Server DX by orchestrating certain operations, so that they won't block the editor during typing. This improvement is more visible in large documents. - [#10473](biomejs/biome#10473) [`d9b5133`](biomejs/biome@d9b5133) Thanks [@Mokto](https://github.com/Mokto)! - Improved [`noUnusedImports`](https://biomejs.dev/linter/rules/no-unused-imports/), [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/), [`noUnusedFunctionParameters`](https://biomejs.dev/linter/rules/no-unused-function-parameters/), and [`useImportType`](https://biomejs.dev/linter/rules/use-import-type/) for Svelte, Vue, and Astro files (with `html.experimentalFullSupportEnabled`). Bindings used only in the template — including component tags, attribute interpolations, directives, `bind:` shorthand, and snippet parameters — are no longer reported as unused, while genuinely unused ones still are. - [#10796](biomejs/biome#10796) [`f1b3ab2`](biomejs/biome@f1b3ab2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where the Biome Language Server didn't enable project or type-aware lint rules, even when they were explicitly enabled. - [#10746](biomejs/biome#10746) [`54e8239`](biomejs/biome@54e8239) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where [`noUndeclaredClasses`](https://biomejs.dev/linter/rules/no-undeclared-classes) didn't detect styles declared inside HTML documents. - [#10774](biomejs/biome#10774) [`bde945b`](biomejs/biome@bde945b) Thanks [@pattrickrice](https://github.com/pattrickrice)! - Fixed [#10268](biomejs/biome#10268) where a race condition resulted in internal errors such as: `The file biome.json does not exist in the workspace`. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/22

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jun 26, 2026

coderabbitai Bot reviewed Jun 26, 2026

View reviewed changes

Comment thread crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs Outdated

JamBalaya56562 force-pushed the fix-no-interactive-role-custom-element branch from c254ac3 to eba8280 Compare June 26, 2026 07:17

ematipico requested changes Jun 29, 2026

View reviewed changes

Comment thread crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs Outdated

JamBalaya56562 force-pushed the fix-no-interactive-role-custom-element branch from eba8280 to c9438f6 Compare June 29, 2026 19:57

JamBalaya56562 changed the title ~~fix(lint): ignore autonomous custom elements in noInteractiveElementToNoninteractiveRole~~ fix(lint): ignore custom elements in noInteractiveElementToNoninteractiveRole Jun 29, 2026

JamBalaya56562 force-pushed the fix-no-interactive-role-custom-element branch from c9438f6 to 7d83cd3 Compare June 29, 2026 20:23

JamBalaya56562 requested a review from ematipico June 29, 2026 20:45

ematipico requested changes Jun 30, 2026

View reviewed changes

fix(lint): ignore custom elements in noInteractiveElementToNoninterac…

b51ce36

…tiveRole Fixes biomejs#2862. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

JamBalaya56562 force-pushed the fix-no-interactive-role-custom-element branch from 7d83cd3 to b51ce36 Compare June 30, 2026 11:31

JamBalaya56562 requested a review from ematipico June 30, 2026 11:33

ematipico approved these changes Jul 1, 2026

View reviewed changes

ematipico merged commit 7aff4c1 into biomejs:main Jul 1, 2026
31 checks passed

github-actions Bot mentioned this pull request Jul 1, 2026

ci: release #10747

Merged

JamBalaya56562 deleted the fix-no-interactive-role-custom-element branch July 1, 2026 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(lint): ignore custom elements in noInteractiveElementToNoninteractiveRole#10766

fix(lint): ignore custom elements in noInteractiveElementToNoninteractiveRole#10766
ematipico merged 1 commit into
biomejs:mainfrom
JamBalaya56562:fix-no-interactive-role-custom-element

JamBalaya56562 commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

changeset-bot Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

ematipico left a comment

Uh oh!

Uh oh!

ematipico Jun 30, 2026

Uh oh!

JamBalaya56562 Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		```

		_Note: The parser emitted 4 diagnostics which are not shown here._

Uh oh!

Uh oh!

Conversation

JamBalaya56562 commented Jun 26, 2026

Summary

Test Plan

Docs

Uh oh!

github-actions Bot commented Jun 26, 2026

✅ Organic activity

Uh oh!

changeset-bot Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ematipico Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

JamBalaya56562 Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 26, 2026 •

edited

Loading