fix(json): detect global Zed settings as JSONC on macOS and Windows (#10730)

dinocosta · ematipico · web-flow · commit 5a2e65b9929e · 2026-06-24T18:34:05.000+01:00
Co-authored-by: Emanuele Stoppa &lt;my.burning@gmail.com&gt;
diff --git a/.changeset/fix-zed-global-settings-jsonc-macos.md b/.changeset/fix-zed-global-settings-jsonc-macos.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed an issue where Biome was resolving [the well-known Zed settings file](https://biomejs.dev/guides/configure-biome/#well-known-files) from the wrong location on macOS and Windows.
diff --git a/crates/biome_languages/src/json.rs b/crates/biome_languages/src/json.rs
@@ -4,6 +4,7 @@ use camino::Utf8Path;
 use core::str;
 use directories::ProjectDirs;
 use std::fmt::{Display, Formatter};
+use std::path::PathBuf;
 use std::str::FromStr;
 
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
@@ -281,7 +282,7 @@ impl JsonFileSource {
             return Ok(Self::json_allow_comments_and_trailing_commas(extension));
         }
 
-        if zed_global_directory().is_some_and(|dir| path.starts_with(dir.config_dir()))
+        if zed_global_directory().is_some_and(|dir| path.starts_with(&dir))
             || vscode_global_directory().is_some_and(|dir| path.starts_with(dir.config_dir()))
             || cursor_global_directory().is_some_and(|dir| path.starts_with(dir.config_dir()))
         {
@@ -365,8 +366,12 @@ fn vscode_global_directory() -> Option<ProjectDirs> {
     ProjectDirs::from("", "Code", "User")
 }
 
-fn zed_global_directory() -> Option<ProjectDirs> {
-    ProjectDirs::from("", "", "zed")
+fn zed_global_directory() -> Option<PathBuf> {
+    cfg_select! {
+        target_os = "macos" => directories::BaseDirs::new().map(|dirs| dirs.home_dir().join(".config").join("zed")) ,
+        target_os = "windows" => directories::BaseDirs::new().map(|dirs| dirs.config_dir().join("Zed")),
+        _ =>  directories::ProjectDirs::from("", "", "zed").map(|dirs| dirs.config_dir().to_path_buf())
+    }
 }
 
 #[cfg(test)]
@@ -395,10 +400,21 @@ mod tests {
 
     #[test]
     fn test_global_zed_settings() {
-        let path = zed_global_directory()
-            .expect("Failed to get config directory")
-            .config_dir()
-            .join("settings.json");
+        let dir = zed_global_directory().expect("Failed to get config directory");
+
+        #[cfg(target_os = "macos")]
+        {
+            let base = directories::BaseDirs::new().expect("Failed to get base dirs");
+            assert_eq!(dir, base.home_dir().join(".config").join("zed"));
+        }
+
+        #[cfg(target_os = "windows")]
+        {
+            let base = directories::BaseDirs::new().expect("Failed to get base dirs");
+            assert_eq!(dir, base.config_dir().join("Zed"));
+        }
+
+        let path = dir.join("settings.json");
         let path = Utf8Path::from_path(path.as_path()).expect("Failed to create Utf8Path");
         let file_source =
             JsonFileSource::try_from_well_known(path).expect("Failed to create JsonFileSource");

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed an issue where Biome was resolving [the well-known Zed settings file](https://biomejs.dev/guides/configure-biome/#well-known-files) from the wrong location on macOS and Windows.